From mboxrd@z Thu Jan  1 00:00:00 1970
From: Puneeth Chaganti <punchagan@gmail.com>
Subject: Re: [PATCH] org-id-goto doesn't work if buffer is narrowed.
Date: Sun, 25 Oct 2015 07:54:20 +0530
Message-ID: <CALnw1fQc63_3yxiwwCywP4tSfHBdPBh9i9b2-u5g6ca=0E+U1w@mail.gmail.com>
References: <CALnw1fRTyShwsk0_G0VMDzfC+6YCCiNxveua36y982LJFfeVNg@mail.gmail.com>
	<874mhh1u7s.fsf@gmx.us>
	<CALnw1fSycwXL-hBfm=x0ejrvSHGZVr6mxm2aV-+=Q4VFUXDkXg@mail.gmail.com>
	<87oafpz65e.fsf@gmx.us>
	<CALnw1fRk0a0SpfDASVz8G66iHH4sHGm24WnhkoW69ycBjrVnpQ@mail.gmail.com>
	<87pp04zc1r.fsf@gmx.us>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37037)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <punchagan@gmail.com>) id 1ZqAzC-0002J8-Ss
	for emacs-orgmode@gnu.org; Sat, 24 Oct 2015 22:24:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <punchagan@gmail.com>) id 1ZqAzB-0002sg-Iy
	for emacs-orgmode@gnu.org; Sat, 24 Oct 2015 22:24:42 -0400
Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:38040)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <punchagan@gmail.com>) id 1ZqAzB-0002sP-DL
	for emacs-orgmode@gnu.org; Sat, 24 Oct 2015 22:24:41 -0400
Received: by wicll6 with SMTP id ll6so73562927wic.1
	for <emacs-orgmode@gnu.org>; Sat, 24 Oct 2015 19:24:40 -0700 (PDT)
In-Reply-To: <87pp04zc1r.fsf@gmx.us>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>

Hi Rasmus,

On Sat, Oct 24, 2015 at 5:57 PM, Rasmus <rasmus@gmx.us> wrote:
>
> However, you need to make sure that it only widens if ID is in the same
> buffer and outside of the narrow.  In particular, when ID is in another
> file you shouldn=E2=80=99t widen.  When it=E2=80=99s within the scope of =
the narrow it
> shouldn=E2=80=99t widen.  This ALREADY seems to be the case.

I will fix the patch to widen only when the target location is not
within the narrow. But, I don't understand why we shouldn't be
widening if the target location is in a different buffer. Can you
explain?

> However, your patch doesn=E2=80=99t work for me in the following example,=
 starting
> from emacs -q, adding /tmp/test.org (with the below content) to my agenda
> list and requiring org-id, org-narrow-to-subtree on foo, and then
> org-open-at-point on the link

I had patched `org-id-goto' and looks like clicking on links uses
`org-id-open'.  I will resend a patch.  I wonder if these two
functions can reuse common code.

--=20
Puneeth