From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Brand <michael.ch.brand@gmail.com>
Subject: Re: [PATH] Speedups to org-table-recalculate
Date: Mon, 8 Dec 2014 13:56:51 +0100
Message-ID: <CALn3zohKv0UQ4jxAmbBxPWeKoeS0pn1mXp84uh=FjZqjX9U14w@mail.gmail.com>
References: <CAPrg3HAnBUysnoeRWWU61uN5eEjp4B-mrOE5TCfNBisTi5+tbA@mail.gmail.com>
	<CALn3zogUBcy3VZPLb7zc3N9j8ibECi41Wbar6Hw_7xiOUvA5VA@mail.gmail.com>
	<CAPrg3HALf6UDzpFvoqEV2u1Z7vHqV4r7m5v0KxyTod05m_Rf7A@mail.gmail.com>
	<CALn3zoiqUfGR6G24YDqH69ZOdiAHX72yqJ+6Xdq+ELmv2n0qmg@mail.gmail.com>
	<CAPrg3HDSAH_n4GhSQpCrv19hjqCVA3TM5VJgdj1Jhzwa+JQNyA@mail.gmail.com>
	<CALn3zogsgiN9KkgkgGKH6wy6sO0g6U+MMAht252rviBDNh0YwQ@mail.gmail.com>
	<CAPrg3HCEd7VJyyo1z9860cHuqReQLsWrEWHgq7erLiEc4oTYxg@mail.gmail.com>
	<CALn3zojScmbeU8ON6r-wyYXJJNbfuj2BbvN=co9FSxHqnoqihA@mail.gmail.com>
	<CAPrg3HDm-cz=pDz21A=Cf9OnWGV07J7CSx3NzuVd=W+MeAYE3w@mail.gmail.com>
	<CALn3zoi9E5C78NOzNxAXBRi7vU8jJkSOHeYLUM_9CMABSSrRSg@mail.gmail.com>
	<CAPrg3HDKL+oJu-6XZijhUqasWa434N8U6AGFzcUVY6-+ukpU+w@mail.gmail.com>
	<CALn3zoi9aTqLN01vXSzgPAq_diSwLEHcvfTtv7CaYxLe44VVcA@mail.gmail.com>
	<CAPrg3HA0Kv-VigNdY=PnhkWEmNbGcPC3K-T1-vj3B=pgh+43ZQ@mail.gmail.com>
	<CALn3zoj3ZNSZvPob7gkT3SB_ORhN6pC51nOv-k5yXkuaU=Ennw@mail.gmail.com>
	<CAPrg3HDkyRZPo1J4OMD11r-KvJ_e7-ZXdBh0Jc4Uq1iH38s29A@mail.gmail.com>
	<CALn3zogNTthgi0xHf3ijjEENBMKiLZuOFfp_06a=7ap34GfLyA@mail.gmail.com>
	<87oas9tnlm.fsf@selenimh.mobile.lan>
	<CAPrg3HDmcfWbdWrfSg6ZWHfDnBpCjW21xqcHNp_0o4eZMZnm1A@mail.gmail.com>
	<87oas03ze0.fsf@nicolasgoaziou.fr>
	<CAPrg3HB4So=FbLnXQOOKKUg_rk2ibuv5u61fQOgJ10h6owqUTw@mail.gmail.com>
	<CAPrg3HCwgxr-=D5S1USUeG5canLDHb3XmFiBYWfT3v8YVxtLxw@mail.gmail.com>
	<87sigt1wge.fsf@nicolasgoaziou.fr>
	<CAPrg3HDvBWM7MjhKAaN_VzrTsxgZNKSOrKc9H8V=O26AZqbn3g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51799)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <michael.ch.brand@gmail.com>) id 1Xxxrz-0000RC-Bw
	for emacs-orgmode@gnu.org; Mon, 08 Dec 2014 07:56:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <michael.ch.brand@gmail.com>) id 1Xxxrx-0004fa-7V
	for emacs-orgmode@gnu.org; Mon, 08 Dec 2014 07:56:55 -0500
Received: from mail-qc0-x234.google.com ([2607:f8b0:400d:c01::234]:62666)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <michael.ch.brand@gmail.com>) id 1Xxxrx-0004fL-2p
	for emacs-orgmode@gnu.org; Mon, 08 Dec 2014 07:56:53 -0500
Received: by mail-qc0-f180.google.com with SMTP id i8so3346419qcq.25
	for <emacs-orgmode@gnu.org>; Mon, 08 Dec 2014 04:56:51 -0800 (PST)
In-Reply-To: <CAPrg3HDvBWM7MjhKAaN_VzrTsxgZNKSOrKc9H8V=O26AZqbn3g@mail.gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nathaniel Flath <flat0103@gmail.com>
Cc: org-mode List <emacs-orgmode@gnu.org>

Hi Nathaniel

The macro did not set the time to nil, the current function does when
t1 is nil but I think it must not. This led me to the following ideas,
sorry for not thinking enough earlier:

Why not change the macro's (setq ,t1 curtime) to a function's (set t1
curtime), still conditional as it was in the macro and call the
function with "'log-*-time", quoted?

Why not factor out the action from the function that would then only
return whether any action has to be taken and in consequence also
factor out the sometimes needed test for "all"?

    (when (or (not all) (org-once-per-second 'log-*-time))
      (message [...]))

The function would not have to test t1 for nil anymore.

In my opinion this functionality should go into org-macs.el, hence
omitting "-table-" in the function name.

Michael