emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Michael Brand <michael.ch.brand@gmail.com>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Add check for assignment to hline relative references in table formulas.
Date: Fri, 8 Nov 2013 12:09:22 +0100	[thread overview]
Message-ID: <CALn3zogJdHVygsyHRLA_NFk4HPAd4HTzsm3djNMSHKsxstWePw@mail.gmail.com> (raw)
In-Reply-To: <878ux0ngv2.fsf@Rainer.invalid>

Hi Achim

On Thu, Nov 7, 2013 at 8:37 PM, Achim Gratz <Stromeko@nexgo.de> wrote:
> I've fixed the failing test since it wasn't checking hline expressions
> and hence should not have relied on undocumented behaviour in the first
> place.

I agree that testing of "LHS hline ref range" and testing of something
else (in this case "comparison") at the same time in the same
ert-deftest has also disadvantages. But why did you only remove test
coverage of "LHS hline ref range" instead of move it into a new
ert-deftest?

Michael

      parent reply	other threads:[~2013-11-08 11:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-01 17:27 [BUG] hline references on left side of table formula Rick Frankel
2013-09-02  8:10 ` Carsten Dominik
2013-09-25 17:57   ` [PATCH] Add check for assignment to hline relative references in table formulas Rick Frankel
2013-11-05 11:08     ` Bastien
2013-11-05 20:19       ` Achim Gratz
2013-11-05 20:55         ` Bastien
2013-11-07 19:37         ` Achim Gratz
2013-11-07 21:09           ` Bastien
2013-11-08 11:09           ` Michael Brand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALn3zogJdHVygsyHRLA_NFk4HPAd4HTzsm3djNMSHKsxstWePw@mail.gmail.com \
    --to=michael.ch.brand@gmail.com \
    --cc=Stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).