From: "numbchild@gmail.com" <numbchild@gmail.com>
To: "Thomas S. Dye" <tsd@tsdye.com>
Cc: Nick Dokos <ndokos@gmail.com>, Org-mode <emacs-orgmode@gnu.org>
Subject: Re: a patch to ob-lisp.el
Date: Wed, 6 Apr 2016 13:55:49 +0800 [thread overview]
Message-ID: <CAL1eYuLK_qP52iEMD0KKh6QEJawhuXO7sFte6gaerc48DfZGjw@mail.gmail.com> (raw)
In-Reply-To: <CAL1eYuKOp1PohTBcwipuB7Gq5fkaSKqcm0-YVJ0JLtibWXSu9Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3670 bytes --]
Ask a beside question. I cloned org-mode git repo, should I contribute my
patch with git way? (I mean create a git branch on my own public clone,
then paste it here to let maintainer merge it?)
[stardiviner] <Hack this world!> GPG key ID: 47C32433
IRC(freeenode): stardiviner Twitter: @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/
On Wed, Apr 6, 2016 at 1:54 PM, numbchild@gmail.com <numbchild@gmail.com>
wrote:
> My think my patch modifies less than 15 lines. Do I have to assign the
> copyright of FSF?
> I have sent one. But no response for some days. I hope Org-mode maintainer
> can merge this patch.
>
> [stardiviner] <Hack this world!> GPG key ID: 47C32433
> IRC(freeenode): stardiviner Twitter: @numbchild
> Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
> Blog: http://stardiviner.github.io/
>
> On Thu, Mar 31, 2016 at 12:52 AM, Thomas S. Dye <tsd@tsdye.com> wrote:
>
>> Aloha stardiviner,
>>
>> For instructions about the FSF papers, see
>> http://orgmode.org/worg/org-contribute.html.
>>
>> All the best,
>> Tom
>>
>> numbchild@gmail.com writes:
>>
>> > I updated all comments which you point out.
>> > I wandering how to sign the FSF papers? Sorry about this, this is my
>> first time
>> > to contribute code in open source.
>> >
>> >
>> >
>> > [stardiviner] <Hack this world!> GPG key ID: 47C32433
>> > IRC(freeenode): stardiviner Twitter: @numbchild
>> > Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
>> > Blog: http://stardiviner.github.io/
>> >
>> > On Mon, Mar 28, 2016 at 12:01 PM, Nick Dokos <ndokos@gmail.com> wrote:
>> >
>> > stardiviner <numbchild@gmail.com> writes:
>> >
>> > > I hope to merge this patch to Org-mode `ob-lisp.el`.
>> > >
>> >
>> > I have only looked at the surface of it, but I see some issues.
>> >
>> > > < ;; Copyright (C) 2016-2020 Free Software Foundation, Inc.
>> > > ---
>> > > > ;; Copyright (C) 2009-2016 Free Software Foundation, Inc.
>> >
>> > Why did you leave out the previous copyright statement?
>> > Where did 2020 come from?
>> >
>> > > < ;; Authors: stardiviner <numbchild@gmail.com>
>> > > < ;; Maintainer: stardiviner <numbchild@gmail.com>
>> > > < ;; Keywords: org babel lisp sly slime
>> > > < ;; URL: https://github.com/stardiviner/ob-lisp
>> > > < ;; Created: 1th March 2016
>> > > < ;; Version: 0.0.1
>> > > < ;; Package-Requires: ((org "8"))
>> > > ---
>> > >> ;; Authors: Joel Boehland
>> > >> ;; Eric Schulte
>> > >> ;; David T. O'Toole <dto@gnu.org>
>> > >> ;; Keywords: literate programming, reproducible research
>> > >> ;; Homepage: http://orgmode.org
>> >
>> > Why did you erase the previous authors?
>> >
>> > Are you volunteering to be the maintainer of ob-lisp.el or are you
>> > planning to keep your own repo and submit patches? Have you signed
>> FSF
>> > papers?
>> >
>> > > < ;; Requires SLY (Sylvester the Cat's Common Lisp IDE) and SLIME
>> > > < ;; See:
>> > > < ;; - https://github.com/capitaomorte/sly
>> > > < ;; - http://common-lisp.net/project/slime/
>> > > ---
>> > >> ;; Requires SLIME (Superior Lisp Interaction Mode for Emacs.)
>> > >> ;; See http://common-lisp.net/project/slime/
>> >
>> > Does it really require both? If so, I suggest you rework it so
>> > either can be used, but only one is required. If not, I suggest
>> > you fix the comment.
>> >
>> > --
>> > Nick
>>
>>
>> --
>> Thomas S. Dye
>> http://www.tsdye.com
>>
>
>
[-- Attachment #2: Type: text/html, Size: 6663 bytes --]
next prev parent reply other threads:[~2016-04-06 5:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-26 16:02 a patch to ob-lisp.el stardiviner
2016-03-28 4:01 ` Nick Dokos
2016-03-30 15:30 ` numbchild
2016-03-30 16:52 ` Thomas S. Dye
2016-04-06 5:54 ` numbchild
2016-04-06 5:55 ` numbchild [this message]
2016-04-06 9:26 ` Nicolas Goaziou
2016-04-06 10:51 ` numbchild
2016-04-06 12:49 ` Nicolas Goaziou
2016-04-06 14:51 ` numbchild
2016-04-10 8:12 ` Nicolas Goaziou
2016-04-06 9:24 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL1eYuLK_qP52iEMD0KKh6QEJawhuXO7sFte6gaerc48DfZGjw@mail.gmail.com \
--to=numbchild@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=ndokos@gmail.com \
--cc=tsd@tsdye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).