From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id AFwSMv3n2l+IDgAA0tVLHw (envelope-from ) for ; Thu, 17 Dec 2020 05:09:17 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id +B/TLf3n2l/QagAAB5/wlQ (envelope-from ) for ; Thu, 17 Dec 2020 05:09:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 12914940483 for ; Thu, 17 Dec 2020 05:09:17 +0000 (UTC) Received: from localhost ([::1]:43696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kplXP-0007Fi-TO for larch@yhetil.org; Thu, 17 Dec 2020 00:09:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41484) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kplWc-0007Fb-AG for emacs-orgmode@gnu.org; Thu, 17 Dec 2020 00:08:26 -0500 Received: from mail-vk1-xa33.google.com ([2607:f8b0:4864:20::a33]:41604) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kplWZ-0008FH-Tq; Thu, 17 Dec 2020 00:08:25 -0500 Received: by mail-vk1-xa33.google.com with SMTP id a6so800578vkb.8; Wed, 16 Dec 2020 21:08:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EbHPOtXZShppgZaUwiL4RKeDzKHdx0JzRSce6Bt4pG0=; b=A/vYYGbjFUXRnO+X2smNT9J4uDF1X8AL2z7oylPiDH+ngz34zpk8BxfVIg0IUw06ra 4kT4nfzUIcgr4o9+4vydItjTRGCIoXQlWjp48wSn0SV0yFnlAx9Av32S2AsqgLwRpP8i wnDa6eDdSUts2kgbvmGQjOeVvVI91RHRqrV4lRiCNpUZJKsyapLJKe3IL+rQcuNz7nXI msvBI/NYAFXCI5L15NKbVlNfpzxGrmqks1XlXGZLTz5zMwqp9ZEShwIzkec+z/EFQ9tM ClITOpdBRPIqjnTTNUtc1expJJewUiVoIaySMkErsdVQJWosHl9MZpLtVknpxDhBjWP6 69zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EbHPOtXZShppgZaUwiL4RKeDzKHdx0JzRSce6Bt4pG0=; b=pj0B1wrpKSMYeTLjdaUrWFHMVxrnRcGpCAUgGrsiDq2e2CKdX/UZrC/TcLTj5lra9A n5O3x4sEXZuesSTE/3LR1PuOJZHGXdIfeElHTMJAdoGUgArrciRaVl5hZ5Gck1YbiJTN j2DbfkX39Zqw+Gkbjjg8ETWKoWcFHhV2hKwqOVXrb5eI07/yDTM8Tujxwc2Z+ZMLGU2R OOVTD6p0I7dSIchW1d5kgs4Hkm+/mwq/dGqbBhi7SLzYdI7UlIKrnG2BqdBuNpALiI+a 3xUkeUSwDzrtDB7evQFgwIgiFzhpvpA2Xci5LrN+lLZAZ0WOqCaEcKn161LvcAZg68PG Gpsg== X-Gm-Message-State: AOAM530xwzUDc77Rge/P+HRZvxR6EouqsBnjdBZVg/Ef7fR0+kyDnd6T IAVz99afgjIhFtkIvGkHAef7Wf6qP4rl7ayezQ== X-Google-Smtp-Source: ABdhPJyCNkx1F1N7Q1nME+u1Cep7VLjFrVD+FX2NJoKbF66tvLuINw/i11toGHujxHimK0cz0TXlBc+lX+YS0WO4oX0= X-Received: by 2002:a1f:3643:: with SMTP id d64mr17904133vka.20.1608181702502; Wed, 16 Dec 2020 21:08:22 -0800 (PST) MIME-Version: 1.0 References: <87zh2e5e7t.fsf@localhost> <87sg86uggl.fsf@gnu.org> <87sg855ct6.fsf@localhost> In-Reply-To: <87sg855ct6.fsf@localhost> From: stardiviner Date: Thu, 17 Dec 2020 13:07:55 +0800 Message-ID: Subject: Re: Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)] To: Ihor Radchenko Content-Type: multipart/alternative; boundary="0000000000001cb05405b6a1fb40" Received-SPF: pass client-ip=2607:f8b0:4864:20::a33; envelope-from=numbchild@gmail.com; helo=mail-vk1-xa33.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastien , Org-mode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.01 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=A/vYYGbj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 12914940483 X-Spam-Score: -3.01 X-Migadu-Scanner: scn0.migadu.com X-TUID: ikUks3zhWXAo --0000000000001cb05405b6a1fb40 Content-Type: text/plain; charset="UTF-8" Supporting org-id has been considered. I will see is it easy to integrated it in. If simple, I will do it soon. Thanks for your suggestion. More detailed discussion can reference another thread in this mailing list. "More on design of org-contacts.el - Re: [UPDATED PATCH] Re: add new link type "contact:" for org-contacts.el" [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Thu, Dec 17, 2020 at 11:26 AM Ihor Radchenko wrote: > > stardiviner writes: > > > Sure, I didn't expected that soon bug appears. I checked source code, I > > commented out an condition accidentally. > > Here is the patch. Tested it should work now. > > What about adding support for org-id? Is it necessary to use headline > text as a search string even when org-id is being used (and > org-id-link-to-org-use-id is set to non-nil)? > > Best, > Ihor > > --0000000000001cb05405b6a1fb40 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Supporting org-id has been considered.
I will see is = it easy to integrated it in. If simple, I will do it soon.
Thanks for= your suggestion. More detailed discussion can reference another thread in = this mailing list.
"More on design of org-contacts.el - Re: [UPDA= TED PATCH] Re: add new link type "contact:" for org-contacts.el&q= uot;

[stardiviner]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 <Hack this world!>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 GPG key ID: 4= 7C32433
IRC(freeenode): stardiviner =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 Twitter:=C2=A0 @numbchild
Key fingerprint =3D 9BAA 92BC CDDD B9EF 3B= 36=C2=A0 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/


On Thu, Dec 17, 2020 at 11:26 AM Ihor Radchenko <= ;yantar92@gmail.com> wrote:

stardiviner <nu= mbchild@gmail.com> writes:

> Sure, I didn't expected that soon bug appears. I checked source co= de, I
> commented out an condition accidentally.
> Here is the patch. Tested it should work now.

What about adding support for org-id? Is it necessary to use headline
text as a search string even when org-id is being used (and
org-id-link-to-org-use-id is set to non-nil)?

Best,
Ihor

--0000000000001cb05405b6a1fb40--