Yeah, I have used to contrib to org-mode, but need to sign FSF papers spend my time, and I don't know how. So I decide to move code in `contrib/`. When I back home, I will try to sign FSF papers, because I have time and fixed location. If I move code into `contrib/`, do I need to do more in this code? I will add `lexical-binding`, but don't know how to write test for this. Could org-mode team pull branch code on my github repo directory? Or should I send a patch from `git format-patch`? [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Sat, Jun 10, 2017 at 4:17 PM, Nicolas Goaziou wrote: > Hello, > > "numbchild@gmail.com" writes: > > > Here is my branch > > https://github.com/stardiviner/org-mode/tree/feature/ob-sclang > > Merge this branch? > > Thank you for your work. > > I'd like to refrain more packages to contrib, unless the intent is to > eventually merge them into core later. > > However, I think this can go into core. Would you like to clean it up > a bit, activate lexical-binding, provide some tests, and send a patch > (using git format-patch)? > > You will need to sign FSF papers to do that, if you haven't done > already. If you are willing to do this, we can also move your library to > "contrib/" temporarily. > > Regards, > > -- > Nicolas Goaziou >