From: Sigmund Tzeng <sig.tzeng@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Bug: utf-8 support for ob-dot.el [9.1.14 (9.1.14-1-g4931fc-elpa @ c:/Users/sig/emacs261/.emacs.d/elpa/org-9.1.14/)]
Date: Sat, 22 Sep 2018 14:10:02 +0800 [thread overview]
Message-ID: <CAJyw0fRct+ivO8V_WKMTk0BRArN30gFUtiPnnWp0Rf5DeoFx3A@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1423 bytes --]
Hi all,
When trying to render a dot file with utf-8 encoded characters,
org babel complained about the encodings. I cross checked ob-go.el at
line 107-108 and made an identical patch to make utf-8 dot files work:
vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
diff --git "a/elpa\\org-9.1.14\\ob-dot.el"
"b/\\emacs261\\share\\emacs\\26.1\\lisp\\org\\ob-dot.el"
index 0fe50d4..31e0a4f 100644
--- "a/elpa\\org-9.1.14\\ob-dot.el"
+++ "b/\\emacs261\\share\\emacs\\26.1\\lisp\\org\\ob-dot.el"
@@ -69,8 +69,6 @@ This function is called by `org-babel-execute-src-block'."
(cmdline (or (cdr (assq :cmdline params))
(format "-T%s" (file-name-extension out-file))))
(cmd (or (cdr (assq :cmd params)) "dot"))
- (coding-system-for-read 'utf-8) ;; use utf-8 with subprocesses
- (coding-system-for-write 'utf-8)
(in-file (org-babel-temp-file "dot-")))
(with-temp-file in-file
(insert (org-babel-expand-body:dot body params)))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
It took me some time. Hope to see it in next version if you think it's OK.
Best Regards,
Sig Tzeng
Emacs : GNU Emacs 26.1 (build 1, x86_64-w64-mingw32)
of 2018-05-30
Package: Org mode version 9.1.14 (9.1.14-1-g4931fc-elpa @
c:/Users/sig/emacs261/.emacs.d/elpa/org-9.1.14/)
[-- Attachment #2: Type: text/html, Size: 1949 bytes --]
next reply other threads:[~2018-09-22 6:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-22 6:10 Sigmund Tzeng [this message]
2018-09-27 14:58 ` Bug: utf-8 support for ob-dot.el [9.1.14 (9.1.14-1-g4931fc-elpa @ c:/Users/sig/emacs261/.emacs.d/elpa/org-9.1.14/)] Nicolas Goaziou
2018-09-29 2:28 ` Sigmund Tzeng
2018-09-29 6:50 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJyw0fRct+ivO8V_WKMTk0BRArN30gFUtiPnnWp0Rf5DeoFx3A@mail.gmail.com \
--to=sig.tzeng@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).