From: Allen Li <vianchielfaura@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org, "Sebastian Reuße" <seb@wirrsal.net>
Subject: Re: [PATCH 2/2] org-refile: Fix inconsistency when listing refile targets
Date: Thu, 6 Jul 2017 23:55:34 -0700 [thread overview]
Message-ID: <CAJr1M6c4YOpu4qp2xqLffQrPvjJb4TO=wXyNN-6wprppU364zA@mail.gmail.com> (raw)
In-Reply-To: <877ezq10ku.fsf@nicolasgoaziou.fr>
Yes, 2906e50177d47 is needed on maint. However, my understanding is
that on maint we still escape filesystem slashes in the outline path?
If so, org-protect-path will be needed around the file-truename in
2906e50177d4
My workflow recently changed such that I no longer need to set
org-refile-use-outline-path to full-file-path, so my interest in this
bug has dropped accordingly, but it is still a bug on maint that
breaks refiling, so I think the fix should be backported unless there
are plans for a main -> maint merge soon.
On Sun, Jul 2, 2017 at 11:44 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Allen Li <vianchielfaura@gmail.com> writes:
>
>> I just realized that this patch was applied to the master branch, not
>> the maint branch.
>>
>> The absence of this patch results in the continued life of a bug in
>> the maint branch where it is not possible to refile to the top level
>> of an agenda file when using full-file-path for
>> org-refile-use-outline-path.
>>
>> Is it possible to backport this to the maint branch? This will
>> require adding the org-protect-slash that I mentioned earlier in this
>> thread. Otherwise, refile is basically unusable for me when
>> full-file-path is set.
>
> Wouldn't 2906e50177d47b4f4a0e75532a0c9dcc9cf72824 be sufficient in your
> case?
>
> If not, what commits are required?
>
> Regards,
>
> --
> Nicolas Goaziou
next prev parent reply other threads:[~2017-07-07 6:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 12:54 [PATCH 1/2] Add tests for org-refile-get-targets Sebastian Reuße
2017-05-15 12:54 ` [PATCH 2/2] org-refile: Fix inconsistency when listing refile targets Sebastian Reuße
2017-05-17 12:54 ` Nicolas Goaziou
2017-06-21 7:05 ` Allen Li
2017-06-21 7:55 ` Sebastian Reuße
2017-06-21 8:01 ` Allen Li
2017-06-28 22:03 ` Allen Li
2017-07-03 6:44 ` Nicolas Goaziou
2017-07-07 6:55 ` Allen Li [this message]
2017-05-15 16:38 ` [PATCH 1/2] Add tests for org-refile-get-targets Nicolas Goaziou
2017-05-17 18:43 ` Sebastian Reuße
2017-05-22 0:38 ` Nicolas Goaziou
2017-05-22 6:46 ` Sebastian Reuße
2017-05-22 6:55 ` Nicolas Goaziou
2017-05-17 18:44 ` [PATCH] " Sebastian Reuße
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJr1M6c4YOpu4qp2xqLffQrPvjJb4TO=wXyNN-6wprppU364zA@mail.gmail.com' \
--to=vianchielfaura@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
--cc=seb@wirrsal.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).