[patch] a small change

[patch] a small change

[feng shu]

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: 0001-A-small-change.patch --]
[-- Type: application/octet-stream, Size: 1275 bytes --]

From 790097f4e3c7acdcccbcc42e302e0e31c264c46d Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu@gmail.com>
Date: Tue, 1 May 2012 15:24:56 +0800
Subject: [PATCH] A small change.

* org.el (org-create-formula-image-with-imagemagick): using   'call-process to launch latex program instead of 'shell-command.
---
 lisp/org.el |    5 +++--
 1 个文件被修改，插入 3 行(+)，删除 2 行(-)

diff --git a/lisp/org.el b/lisp/org.el
index f54026c..e9e6564 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -17037,7 +17037,7 @@ Some of the options can be changed using the variable
 	       ((eq processing-type 'imagemagick)
 		(unless executables-checked
 		  (org-check-external-command
-		   "converte" "you need to install imagemagick")
+		   "convert" "you need to install imagemagick")
 		  (setq executables-checked t))
 		(unless (file-exists-p movefile)
 		  (org-create-formula-image-with-imagemagick
@@ -17312,7 +17312,8 @@ inspection."
 			   (save-match-data
 			     (shell-quote-argument (file-name-directory texfile)))
 			   t t cmd)))
-	      (shell-command cmd)))
+	      (setq cmd (split-string cmd))
+	      (eval (append (list 'call-process (pop cmd) 'nil 'nil 'nil) cmd))))
 	(error nil))
       (cd dir))
     (if (not (file-exists-p pdffile))
-- 
1.7.10

Re: [patch] a small change

[Bastien]

Hi Feng,

thanks for the patch.  Can you give it a better name?

Also split it into two patches, one for the typo one for 
the other change.

As for the code:

- don't use 'nil, use nil
- (append (list 'x 'y) 'y) => (list 'x 'y 'z)

Thanks!

-- 
 Bastien