Re: [BUG] org-mouse is activated without explicit require

[Samuel Wales <samologist@gmail.com>]

hi matt,

superb bug report.  happy human rights day.

isn't there a policy someplace in the elisp manual that states that
loading a package should have no major[tm] side effects?

the emacs behavior of loading upon completion is new to me and a
surprise.  the org list of links behavior is new to me.

n.b. i personally find org-mouse to a be excellent for accessibility
reasons.  i am always either in mouse mode or keyboard mode and it
adds a lot of functionality.  could even use a bit more, such as
selecting todo kw.

sorry cannot address your bug further.  it does seem there are things
needing fixing.



On 12/10/22, Matt Lundin <mdl@imapmail.org> wrote:
> I'm not too familiar with how emacs handles autoloads. However, I find
> org-mouse is automatically loaded if I call describe-function and then
> tab complete after typing "", "org-", "org-m", etc. This seems enough to
> load the entirely of the org-mouse.el file.
>
> The problem is that this adds a lambda function to org-mode-hook that
> activates all org-mouse functionality at the next call of org-mode or
> org-mode-restart. This has two unexpected effects:
>
> 1. It changes the behavior of mouse clicks without the user's explicit
>    request.
> 2. It advise org-open-at-point, with the result that it is no longer
>    possible to get a list of all links in an entry when calling
>    org-open-at-point on a headline. (See separate bug report on this.)
>
> I am able to reproduce this with a minimal .emacs config and the most
> recent git version (after running "make clean && make").
>
> Steps to reproduce:
>
> 1. /usr/bin/emacs -Q -l ~/minimal.el
>
> where ~/minimal.el is...
>
> --8<---------------cut here---------------start------------->8---
> (add-to-list 'load-path "~/org-mode/lisp/")
> --8<---------------cut here---------------end--------------->8---
>
> 2. C-h f org-m [tab]
>
> Note that "org-mouse-" functions appear in the completion list. Even if
> one aborts describe-function at this point, org-mouse has been loaded
> and org-mode-hook now contains a lambda function to activate the
> functionality of org-mouse (org-defkey, advice-add, etc.).
>
> 3. Open an org buffer for the first time or call "M-x org-mode-restart"
>    in an already opened buffer
>
> "C-h v org-open-at-point" now reports the following advice:
>
> --8<---------------cut here---------------start------------->8---
> This function has :around advice: ‘org--mouse-open-at-point’.
> --8<---------------cut here---------------end--------------->8---
>
> Also notice that org-mouse features are now active in org buffers.
>
> Thanks,
>
> Matt
>
>


-- 
The Kafka Pandemic

A blog about science, health, human rights, and misopathy:
https://thekafkapandemic.blogspot.com