From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samuel Wales <samologist@gmail.com>
Subject: Re: [RFC] Could we get rid of Org specific "mark ring"
Date: Tue, 30 Jan 2018 15:33:01 -0700
Message-ID: <CAJcAo8uNqmz04FuBtYv0jRHhLArowON2WyYusuXv7UNEwgZWOA@mail.gmail.com>
References: <87o9lcntdq.fsf@nicolasgoaziou.fr>
	<CAJcAo8tSChMw42foWEGQOfYXfFy7FwnMYjFVUh_cm9YMWO2+CA@mail.gmail.com>
	<87po5rxcgq.fsf@nicolasgoaziou.fr>
	<CAJcAo8ss=sn_S1JWsN=jwvY=PmN=NLQDN6xUM89gULKcst6JRA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:43870)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samologist@gmail.com>) id 1egeTG-0006Ff-8e
	for emacs-orgmode@gnu.org; Tue, 30 Jan 2018 17:34:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <samologist@gmail.com>) id 1egeSc-0005ta-Co
	for emacs-orgmode@gnu.org; Tue, 30 Jan 2018 17:33:41 -0500
Received: from mail-io0-x244.google.com ([2607:f8b0:4001:c06::244]:37800)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <samologist@gmail.com>)
	id 1egeSc-0005sw-2m
	for emacs-orgmode@gnu.org; Tue, 30 Jan 2018 17:33:02 -0500
Received: by mail-io0-x244.google.com with SMTP id f89so13225470ioj.4
	for <emacs-orgmode@gnu.org>; Tue, 30 Jan 2018 14:33:02 -0800 (PST)
In-Reply-To: <CAJcAo8ss=sn_S1JWsN=jwvY=PmN=NLQDN6xUM89gULKcst6JRA@mail.gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Org Mode List <emacs-orgmode@gnu.org>

minor followup to prev post.

here is a place where org does not but ime is useful to push the mark.
org does similarly when you follow a link, for example.

i believe this should be done to the local and global mark rings.

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 98f6034..d410d3a 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -8640,6 +8640,7 @@ displayed Org file fills the frame."
       (pop-to-buffer-same-window buffer)
       (when delete-other-windows (delete-other-windows))
       (widen)
+      (org-mark-ring-push)
       (goto-char pos)
       (when (derived-mode-p 'org-mode)
 	(org-show-context 'agenda)