emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Samuel Wales <samologist@gmail.com>
To: this nkk <thisnkk@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: Bug: (bug?) org-id-find-id-in-file doesn't close files after finding id [9.4 (9.4-7-g3eccc5-elpaplus @ ~/spacemacs/elpa/develop/org-plus-contrib-20200921/)]
Date: Tue, 6 Oct 2020 14:36:21 -0700	[thread overview]
Message-ID: <CAJcAo8smhtXiKJh0BVHAO=R0t99LD-PkSZfYUkiGQDM06S34WQ@mail.gmail.com> (raw)
In-Reply-To: <87pn5vu0bn.fsf@nicolasgoaziou.fr>

thank you to both of you from me too.

i have noticed that the same problem occurs for me with refile targets
alist.  putting a file there seems to open the buffer for some reason
and not close it even if it had not been closed.  this might require a
refile or an id lookup or so.

however, it does not require doing anything with that file.

i frequently get org archive files sticking around.  i am guessing
this is due to id lookup.


On 10/6/20, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> this nkk <thisnkk@gmail.com> writes:
>
>> when running org-id-find-id-in-file on an id and an unvisited file, the
>> buffer it creates to visit file isn't
>> closed after finding id.
>>
>> ** what should have happened
>> I was expecting it to close the buffer if the
>> file wasn't already visited by another buffer.
>>
>> Is this desired behavior?
>
> It depends. If MARKERP is non-nil, you certainly don't want to close the
> newly created buffer. Otherwise, it could be closed, indeed.
>
> I patched master along these lines. Thank you.
>
> Regards,
> --
> Nicolas Goaziou
>
>


-- 
The Kafka Pandemic

Please learn what misopathy is.
https://thekafkapandemic.blogspot.com/2013/10/why-some-diseases-are-wronged.html


      reply	other threads:[~2020-10-06 21:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-25  0:16 Bug: (bug?) org-id-find-id-in-file doesn't close files after finding id [9.4 (9.4-7-g3eccc5-elpaplus @ ~/spacemacs/elpa/develop/org-plus-contrib-20200921/)] this nkk
2020-10-06 10:15 ` Nicolas Goaziou
2020-10-06 21:36   ` Samuel Wales [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJcAo8smhtXiKJh0BVHAO=R0t99LD-PkSZfYUkiGQDM06S34WQ@mail.gmail.com' \
    --to=samologist@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=thisnkk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).