Re: comment trees in 8.3

[Samuel Wales <samologist@gmail.com>]

ok, better testcase below.  please ignore last 2 messages.

complete with code, data, explanation, and steps to reproduce.

* commented subtrees show in agenda even if org-agenda-skip-comment-trees is t
to reproduce, load the code below, find this file, put
restriction lock on this subtree (< at bol above or c-c c-x
< here) and run m-x org-agenda-list.
*** what i get
Day-agenda (W32):
2015-08-09 Sun
  comment:    Deadline:   no should not show
  comment:    Deadline:   no should not show
  comment:     4 d. ago:  TODO yes this should show
  comment:     4 d. ago:  TODO COMMENT this one is possibly bad
syntax, so don't know if it should show
  comment:     4 d. ago:  COMMENT TODO no this should not show
  comment:     4 d. ago:  yes should show
  comment:     4 d. ago:  COMMENT no should not show
*** y
***** TODO yes this should show
DEADLINE: <2015-08-05 Wed>
***** TODO COMMENT this one is possibly bad syntax, so don't know if
it should show
DEADLINE: <2015-08-05 Wed>
******* bad syntax
***** COMMENT TODO no this should not show
DEADLINE: <2015-08-05 Wed>
******* no should not show
DEADLINE: <2015-08-09 Sun>
***** yes should show
DEADLINE: <2015-08-05 Wed>
***** COMMENT no should not show
DEADLINE: <2015-08-05 Wed>
******* no should not show
DEADLINE: <2015-08-09 Sun>
*** code to reproduce with -Q
24.4.1

can repro with -Q and this old testcase code and restriction lock and
org-agenda-list.

===

;;;
;;;alpha-org-testcase.el
;;;
;;;minimal testcase for org
;;;
;;;   dorg=your-org-dir delorgsrc=your-org-src-dir emacs -Q -l
alpha-org-testcase.el
;;;

;;;
;;;for my use i do this:
;;;
"
mep=t emacs -Q -l $del/tests-and-publish/alpha-org-testcase.el \
  --geometry +0+0 \
  --geometry 60x30 \
  $dorg/tests--org--xyzzy-big/comment.org
"
;;;

(require 'cl)

;;my org files use these
(setq org-odd-levels-only t)
;; (setf org-export-initial-scope 'subtree)

;;fix abominations
(blink-cursor-mode 0)
(setf visible-bell 'top-bottom)

;;basics
(defun alpha-add-path (p) (setq load-path (cons p load-path)))
(alpha-add-path (concat (getenv "delorgsrc") "/lisp"))
(add-to-list 'auto-mode-alist '("\\.org$" . org-mode))
(require 'org-install)

(setq org-agenda-files (list (substitute-in-file-name "$dorg/todo-new--a.org")))

;;;
;;;stuff make things easier
;;;

(setq org-completion-use-ido t)
(setf org-outline-path-complete-in-steps nil)

;;;
;;;compatibility fixes
;;;

;; ;;fix compatibility bug in org [2011-05-25 Wed 08:59]
;; (when (= emacs-major-version 22)
;;   (defun activate-mark ()
;;     "Activate the mark."
;;     (when (mark t)
;;       (setq mark-active t)
;;       (unless transient-mark-mode
;;         (setq transient-mark-mode 'lambda))
;;       (when (and select-active-regions
;;                  (display-selections-p))
;;         (x-set-selection 'PRIMARY (current-buffer))))))

;; ;;[2011-05-25 Wed 09:23] fix compatibility bug in Org.
;; ;;this is redefinition.  it is for 22 for export.
;; (defcustom select-active-regions nil
;;  "If non-nil, an active region automatically becomes the window selection."
;;  :type 'boolean
;;  :group 'killing
;;  :version "23.1")

;;;
;;;accessibility fixes
;;;

(defun p ()
  (interactive)
  (message "fixing pop-up-windows")
  ;;i have /pop-up-windows/ set to nil, which works for most of
  ;;emacs.  for org, i do the following.  i need all of this just
  ;;as i need the large font above for accessibility reasons.
  ;;
  ;;(setf (cdr (assoc* 'file org-link-frame-setup)) 'find-file)
  (pushnew '(file . find-file) org-link-frame-setup :test #'equal)
  ;;it might be nice to have a 'dedicated-buffer option
  (setf org-indirect-buffer-display 'current-window)
  ;;could make pop kill the buffer
;;;(setf org-display-internal-link-with-indirect-buffer t)
  (setf org-src-window-setup 'current-window)
  (add-hook 'org-capture-mode-hook 'delete-other-windows)
  (defadvice org-agenda-set-tags (around fix-windows activate compile)
    "Restore windows."
    (save-window-excursion
      ad-do-it))
  (defadvice org-export (after fix-windows activate compile)
    "Delete other windows after every export."
    (delete-other-windows))

  (setf pop-up-windows nil)

  ;;for emacs i do this

  (add-to-list 'same-window-regexps "\\*Customize.*") ;notwork?
  (setf Man-notify-method 'pushy)
  (add-to-list 'same-window-regexps "\\*Man .*") ;notwork
  (add-to-list 'same-window-regexps "\\*.*\\*")
  (add-to-list 'same-window-buffer-names "*Remember*")
  (add-to-list 'same-window-buffer-names "*Help*")
  (add-to-list 'same-window-buffer-names "*Apropos*")
  (add-to-list 'same-window-buffer-names "*Summary*")
  (add-to-list 'same-window-buffer-names "*Compile-Log*")
  (add-to-list 'same-window-buffer-names "*Ibuffer*")
  (add-to-list 'same-window-buffer-names " *Ibuffer*")
  (message "done fixing pop-up-windows"))
(when (getenv "mep")
  ;;it is i
  (defconst alpha-alpha-p t)
  (require 'org)
  (p)
  ;;necessary for large fonts
  (scroll-bar-mode -1))

;;;
;;;basic org features likely to affect many bug reports
;;;

(setq org-todo-keywords
      '((type  "NAKA(i)" "TODO(T)" "MAYBE(y)" "DOUBTFUL(l)"
         "|"
         "MOOT(m)")))

(setq org-agenda-window-setup 'current-window)