From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CAk9JYjSqGL/OgAAbAwnHQ (envelope-from ) for ; Tue, 14 Jun 2022 20:25:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id x+EQJYjSqGLEigAAauVa8A (envelope-from ) for ; Tue, 14 Jun 2022 20:25:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 25DAC7271 for ; Tue, 14 Jun 2022 20:25:12 +0200 (CEST) Received: from localhost ([::1]:51920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1BDz-0006EE-5e for larch@yhetil.org; Tue, 14 Jun 2022 14:25:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1BD5-000654-7L for emacs-orgmode@gnu.org; Tue, 14 Jun 2022 14:24:18 -0400 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]:38900) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o1BD3-0008JH-AT for emacs-orgmode@gnu.org; Tue, 14 Jun 2022 14:24:14 -0400 Received: by mail-lj1-x22e.google.com with SMTP id g2so10695815ljk.5 for ; Tue, 14 Jun 2022 11:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vicarious-living-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b8JkbZhkgGrDJrnm/DrrbBJ8jTOqfWNGtRb6SE5dmiA=; b=qvTtPYROuG/9UkahVqS0oyDrprrUQGWPHq+oK2Z/Q1fAOFVxP06JbO2Xju8L0Hzf51 YMydWptsPKbkPkNdhDAE7OP5qoainQJ5LSFmuuYRaCnsohh2X5wZTbgGVlheG5rbKEMI Nm8/p5cVLYCSsRLJBgZUTHMIAXIhn12M8P3ixR2KO3Ldh0MOsHdjNwAc+0+vfQD252j5 nRiffQEwBCXnqgxCrwMY+Z1DUk92xLLLKuSLETxNl8OSH9ZMLRdlseBXMEjsZL8Nymti zoM41OvhrG0w47ii77YHJbPsfwrItMmHowE6F/fZ4/YHIUV+l48GnlS0TQ9dNnzYI94E OQrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b8JkbZhkgGrDJrnm/DrrbBJ8jTOqfWNGtRb6SE5dmiA=; b=awwUq7RN6WxLZ2pxKvTXW8yeychh63gaIe1ZEWUuXYBM84YUh4Z0Fkwzt/xC+NEA9p W3AfOMp0YyfR7LUlM4fml0zrKgUduZ7ejJUuDT7u5Wkzx026qhJ4LBLeUVFfd62qtU4r eJKx4/HX/B6Jxm7dLT8XHPysIdE4zY4vRCkanFxFPDAoT2FeVecmLCe19pXpb9OEIZfI +T/QXXFagdpRS40T2di8Tn+FM639biUyNYGOa9V4Rq2dGDso0jViVkip8zSCN1rveqq4 i4ZpLg9iFpoR9L3TZ6L84+6jjCNbr/ppOdm5Uywq6efGdi5/J8EL9HoJ43LIFu4+wuUE fObQ== X-Gm-Message-State: AJIora+PBngy/YLE7dJpRocUY3M6Who6Xk0evWTczGW4lOaUPiqs+NGK Fj7C3uczgNlYFRjfQwDHZcZl2/5jT8virYw81ZWkPw== X-Google-Smtp-Source: AGRyM1u1z6K1408oBy45qFgPkfnZgWizxijRhxIJgoKqT4H+k3vQCqiosIDSm6a5IQoffDv7iVR9aQb94Iq7u+q+DFA= X-Received: by 2002:a2e:a289:0:b0:258:e917:36a4 with SMTP id k9-20020a2ea289000000b00258e91736a4mr3245092lja.510.1655231051182; Tue, 14 Jun 2022 11:24:11 -0700 (PDT) MIME-Version: 1.0 References: <981938.1630590273@apollo2.minshall.org> <87czpqjqvw.fsf@localhost> <87zgkey55y.fsf@localhost> <8735i5u039.fsf@localhost> <87h74rq0ql.fsf@localhost> <87czffbc0r.fsf@localhost> <87sfo7q3xs.fsf@localhost> <87k09jwe2v.fsf@localhost> In-Reply-To: <87k09jwe2v.fsf@localhost> From: Ryan Scott Date: Tue, 14 Jun 2022 11:23:59 -0700 Message-ID: Subject: Re: [PATCH] Re: New source block results option for attaching file to node To: Ihor Radchenko Cc: numbchild@gmail.com, Greg Minshall , Timothy , emacs-orgmode@gnu.org Content-Type: multipart/alternative; boundary="000000000000d3d21305e16c8255" Received-SPF: none client-ip=2a00:1450:4864:20::22e; envelope-from=ryan@vicarious-living.com; helo=mail-lj1-x22e.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655231112; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=b8JkbZhkgGrDJrnm/DrrbBJ8jTOqfWNGtRb6SE5dmiA=; b=A2xTMDDrndlhvFQZbwReejYqQ1ov5tJzr7t9BlFBub5/ka8W2lEfavBCHSsFcyJi+1DHHH gZm8x9Z+VgGsXNdu+gITuvbFJzkgdyW1OJydBUcv0a3a52lDIjjtOyOi00Wm0OrhgOb0em tk9s5lHzOxTOOkwTLDaUcJ7//PDaBgtYVp7CJkTt+9E2wBHuBlWfC0YyF4UK6uycX37NHq PTRjgtgUfRMu+eHKreAsH7/dQKSh6hdgSDCpjhIBB5QL/NlWw0Uf+W07KlTTYjwJSY5XuG 6Noxw2EcD/zZ/DpwXbileIAEB8OiqpXpd1QTwIf8bxX+rsSOJBHZEXSGerBc1g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655231112; a=rsa-sha256; cv=none; b=qvxXC4UYtzkbDS6CmVmGFMOvfI45IelAcb8MhUMaBBGp32JTat0v7H3lGrZRybtZx+4OBW abPBgWf7yZuzXCONP5QRnG+LlUHiZo1sN1VR8D68FSWAw4Wsl9Ejkl61J+nkBvp1Y9BHA9 bLW73L4ZWnsQJNnle/JR4/747c3G528Dd5lnVsvb3NDtZchqBBwo60ntch3VXUwPR57sH0 Te7FjOQ+NoXMK9nivBsXqfClSMs2Hi7avhWFFUoFHDIkQRarxGONWdK1dVfi5Zh+z3qyO9 fb84A9LCdv2SiYnnk9OGxBWBC9eWbGgD9Ad09OwQt7ei/N0cpI1njUkOyx465w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=vicarious-living-com.20210112.gappssmtp.com header.s=20210112 header.b=qvTtPYRO; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -7.29 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=vicarious-living-com.20210112.gappssmtp.com header.s=20210112 header.b=qvTtPYRO; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 25DAC7271 X-Spam-Score: -7.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: C7xyCADD4eIX --000000000000d3d21305e16c8255 Content-Type: text/plain; charset="UTF-8" Awesome! Thanks again for all the help. It's been a crash course in org internals and the contribution process. Well prepared for next time to go much smoother. Cheers, -ryan On Tue, Jun 14, 2022 at 6:47 AM Ihor Radchenko wrote: > Ryan Scott writes: > > > I put together a clean setup in docker for running the tests and believe > > I've gotten to the source of the problem. > > However I've thought that a few times now. > > Would you be interested to share it? It might be helpful for other > people trying to develop on Windows. > > > This version of the patch has all tests passing. > > The problem was in org-results-to-file and the attach dir detection. It > > both had problems with an introduced assumption that the buffer-file-name > > would be non-nil (causing several tests to fail) as well as being > generally > > overzealous in detecting file result paths as attachment links. > > Thanks! > > Applied onto main via 226119124 with several amendments. > > I have added some missing "." at the end of sentences, made sure that > all sentences are separated by doube " " as required by our conventions > and dropped `quoting' from non-symbols. > > Best, > Ihor > --000000000000d3d21305e16c8255 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Awesome!
Thanks again for all the help. It's been = a crash course in org internals and the contribution process.
Wel= l prepared for next time to go much smoother.

Chee= rs,
=C2=A0 -ryan

On Tue, Jun 14, 2022 at 6:47 AM Ihor Radche= nko <yantar92@gmail.com> wr= ote:
Ryan Scott = <ryan@vic= arious-living.com> writes:

> I put together a clean setup in docker for running the tests and belie= ve
> I've gotten to the source of the problem.
> However I've thought that a few times now.

Would you be interested to share it? It might be helpful for other
people trying to develop on Windows.

> This version of the patch has all tests passing.
> The problem was in org-results-to-file and the attach dir detection. I= t
> both had problems with an introduced assumption that the buffer-file-n= ame
> would be non-nil (causing several tests to fail) as well as being gene= rally
> overzealous in detecting file result paths as attachment links.

Thanks!

Applied onto main via 226119124 with several amendments.

I have added some missing "." at the end of sentences, made sure = that
all sentences are separated by doube "=C2=A0 " as required by our= conventions
and dropped `quoting' from non-symbols.

Best,
Ihor
--000000000000d3d21305e16c8255--