Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

[Yu Han Quek <qythium@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3946 bytes --]

Calling org-table-insert-column in a table with formulas wrongly increments
the column number left of the newly inserted column.

Minimal example:

| 1 | 2 | 3 |
#+TBLFM: $3=$1+$2

With cursor in the `1` cell, call `M-x org-table-insert-column`.

Expected output:

| 1 |   | 2 | 3 |
#+TBLFM: $4=$1+$3

Actual output ($1 wrongly changed to $2):

| 1 |   | 2 | 3 |
#+TBLFM: $4=$2+$3


The bug seems to be in the last 2 lines of the
function org-table-insert-column:

      (org-table-fix-formulas "$" nil (1- col) 1)
      (org-table-fix-formulas "$LR" nil (1- col) 1)

Changing `(1- col)` to `col` solves the issue.


------------------------------------------------------------------------

Emacs  : GNU Emacs 28.0.50 (build 2, x86_64-apple-darwin18.7.0, NS
appkit-1671.60 Version 10.14.6 (Build 18G1012))
 of 2020-01-05
Package: Org mode version 9.3 (release_9.3 @
/usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)

current state:
==============
(setq
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
    org-src-mode-configure-edit-buffer)
 org-link-shell-confirm-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-mode-hook '(#[0 "\300\301\302\303\304$\207"
  [add-hook change-major-mode-hook org-show-all append local]
  5]
#[0 "\300\301\302\303\304$\207"
  [add-hook change-major-mode-hook org-babel-show-result-all
   append local]
  5]
org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-bibtex-headline-format-function #[257 "\300 \236A\207" [:title] 3
"\n\n(fn ENTRY)"]
 org-babel-pre-tangle-hook '(save-buffer)
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe
     org-babel-header-arg-expand)
 org-occur-hook '(org-first-headline-recenter)
 org-cycle-hook '(org-cycle-hide-archived-subtrees
org-cycle-show-empty-lines
 org-optimize-window-after-visibility-change)
 org-speed-command-hook '(org-speed-command-activate
 org-babel-speed-command-activate)
 org-confirm-shell-link-function 'yes-or-no-p
 org-link-parameters '(("attachment" :follow org-attach-open-link :export
org-attach-export-link :complete
org-attach-complete-link)
      ("id" :follow org-id-open)
      ("eww" :follow eww :store org-eww-store-link)
      ("rmail" :follow org-rmail-open :store
org-rmail-store-link)
      ("mhe" :follow org-mhe-open :store org-mhe-store-link)
      ("irc" :follow org-irc-visit :store org-irc-store-link
:export org-irc-export)
      ("info" :follow org-info-open :export org-info-export
:store org-info-store-link)
      ("gnus" :follow org-gnus-open :store
org-gnus-store-link)
      ("docview" :follow org-docview-open :export
org-docview-export :store org-docview-store-link)
      ("bibtex" :follow org-bibtex-open :store
org-bibtex-store-link)
      ("bbdb" :follow org-bbdb-open :export org-bbdb-export
:complete org-bbdb-complete-link :store
org-bbdb-store-link)
      ("w3m" :store org-w3m-store-link) ("file+sys")
      ("file+emacs") ("shell" :follow org-link--open-shell)
      ("news" :follow
#[257 "\301\300\302 Q!\207" ["news" browse-url ":"] 5
 "\n\n(fn URL)"]
)
      ("mailto" :follow
#[257 "\301\300\302 Q!\207" ["mailto" browse-url ":"]
 5 "\n\n(fn URL)"]
)
      ("https" :follow
#[257 "\301\300\302 Q!\207" ["https" browse-url ":"]
 5 "\n\n(fn URL)"]
)
      ("http" :follow
#[257 "\301\300\302 Q!\207" ["http" browse-url ":"] 5
 "\n\n(fn URL)"]
)
      ("ftp" :follow
#[257 "\301\300\302 Q!\207" ["ftp" browse-url ":"] 5
 "\n\n(fn URL)"]
)
      ("help" :follow org-link--open-help)
      ("file" :complete org-link-complete-file)
      ("elisp" :follow org-link--open-elisp)
      ("doi" :follow org-link--open-doi))
 org-link-elisp-confirm-function 'yes-or-no-p
 )

[-- Attachment #2: Type: text/html, Size: 5402 bytes --]