From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kaushal Modi <kaushal.modi@gmail.com>
Subject: Re: org-capture templates broken?
Date: Tue, 3 Nov 2015 13:51:31 -0500
Message-ID: <CAFyQvY3=twLdh-=xT6CaM0e2StfkO4M_+G95-ee9BT0BqzS73Q@mail.gmail.com>
References: <CAFyQvY2MvpDL61_GPY8-2tSjjYONzU0KhRdLNZpeFh8a_r2U0w@mail.gmail.com>
	<CAFyQvY04hccMMng1TTS=v0F20v6XnXViPMPYkv5=A+OiQ_a5ng@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51882)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kaushal.modi@gmail.com>) id 1Ztggm-0001SO-Ac
	for emacs-orgmode@gnu.org; Tue, 03 Nov 2015 13:52:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kaushal.modi@gmail.com>) id 1Ztggl-000115-G1
	for emacs-orgmode@gnu.org; Tue, 03 Nov 2015 13:52:12 -0500
Received: from mail-oi0-x22d.google.com ([2607:f8b0:4003:c06::22d]:33987)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kaushal.modi@gmail.com>) id 1Ztggl-00010r-BK
	for emacs-orgmode@gnu.org; Tue, 03 Nov 2015 13:52:11 -0500
Received: by oies66 with SMTP id s66so14351230oie.1
	for <emacs-orgmode@gnu.org>; Tue, 03 Nov 2015 10:52:11 -0800 (PST)
In-Reply-To: <CAFyQvY04hccMMng1TTS=v0F20v6XnXViPMPYkv5=A+OiQ_a5ng@mail.gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-org list <emacs-orgmode@gnu.org>, lukasz@gruner.lu

The issue got fixed when I changed the below in my local.mk file and
rebuilt org:

From

ORG_ADD_CONTRIB = org-mime org-eww

To

ORG_ADD_CONTRIB = org-eldoc org-mime org-eww

I figured out why I was seeing the problem:

I have org-plus-contrib installed too. So when `package-initialize`
was called, the below bare form in org-eldoc.el (installed via
org-plus-contrib) got evaluated too:

(add-hook 'org-mode-hook #'org-eldoc-load)


I like to have both stable and dev version installed so that I can
switch to the stable version in case of emergency. So I have this
snippet in my org setup:

;; If `org-load-version-dev' is non-nil, remove the stable version of org
;; from the `load-path'.
(when (bound-and-true-p org-load-version-dev)
  (when (version<= "25.0" emacs-version) ;
`directory-files-recursively' is not available in older emacsen
      (let ((org-stable-install-path (car (directory-files-recursively
                                           package-user-dir
                                           "org-plus-contrib-[0-9]+"
                                           :include-directories))))
        (setq load-path (delete org-stable-install-path load-path)))))


That basically removes the org-plus-contrib dir from the load-path if
I choose to use the dev version of org-mode. But that still keeps
`org-eldoc-load' in the org-mode-hook.

@Lucas: I would propose to not update the org-mode-hook automatically;
that add-hook should not be bare in the org-eldoc.el. It should be
updated only via a function call.

--
Kaushal Modi