From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kaushal Modi Subject: Re: M-S-RET doesn't work anymore? Date: Wed, 23 Jan 2019 16:04:24 -0500 Message-ID: References: <87y37bup0p.fsf@norang.ca> <84va2fhzeu.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000008493c4058026725d" Return-path: Received: from eggs.gnu.org ([209.51.188.92]:35087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmPho-0002N0-Og for emacs-orgmode@gnu.org; Wed, 23 Jan 2019 16:05:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmPhn-0002PI-WF for emacs-orgmode@gnu.org; Wed, 23 Jan 2019 16:05:04 -0500 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]:41583) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gmPhn-0002Op-Og for emacs-orgmode@gnu.org; Wed, 23 Jan 2019 16:05:03 -0500 Received: by mail-lj1-x236.google.com with SMTP id k15-v6so3243519ljc.8 for ; Wed, 23 Jan 2019 13:05:03 -0800 (PST) In-Reply-To: <84va2fhzeu.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Marco Wahl , kevin.legouguec@gmail.com Cc: Bernt Hansen , emacs-org list , Nicolas Goaziou --0000000000008493c4058026725d Content-Type: text/plain; charset="UTF-8" On Wed, Jan 23, 2019 at 3:54 PM Marco Wahl wrote: > As a workaround you can evaluate the lines (that were active before the > commit) > > (org-defkey org-mode-map (kbd "S-") #'org-table-copy-down) > (org-defkey org-mode-map (kbd "M-S-") #'org-insert-todo-heading) > (org-defkey org-mode-map (kbd "ESC S-") #'org-insert-todo-heading) > > or put them into your init file AFAICS. > Yep, that commit broke the - bindings for me too. I'll have to do the same. Copying Kevin who originally requested the change of these bindings (this switching of bindings between RET and feels like dejavu to me .. I have seen this done before in Org repo). Is this a reliable fix to add these lines to the source code again? > To be honest I don't see clearly. > May be those keys should be bound to both RET and variants? For Emacs GUI, I think that the variant is needed, RET does nothing. --0000000000008493c4058026725d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Jan 23, 2019 at 3:54 PM Marco Wahl <marcowahlsoft@gmail.com> wrote:
As a workaround you can evalua= te the lines (that were active before the
commit)

(org-defkey org-mode-map (kbd "S-<return>") #'org-table= -copy-down)
(org-defkey org-mode-map (kbd "M-S-<return>") #'org-ins= ert-todo-heading)
(org-defkey org-mode-map (kbd "ESC S-<return>") #'org-i= nsert-todo-heading)

or put them into your init file AFAICS.

Yep, that commit broke the -<return> bindings for me too. I'll h= ave to do the same.

Copying Kevin who originally r= equested the change of these bindings (this switching of bindings between R= ET and <return> feels like dejavu to me .. I have seen this done befo= re in Org repo).

Is this a reliable fix to add these lines to the source code again?
To be honest I don't see clearly.

M= ay be those keys should be bound to both RET and <return> variants? <= br>

For Emacs GUI, I think that the <return>= variant is needed, RET does nothing.
--0000000000008493c4058026725d--