From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GJeNO7y5pmGx0QAAgWs5BA (envelope-from ) for ; Wed, 01 Dec 2021 00:54:36 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YA4oN7y5pmGCNwAAbx9fmQ (envelope-from ) for ; Tue, 30 Nov 2021 23:54:36 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9CA46332BC for ; Wed, 1 Dec 2021 00:54:36 +0100 (CET) Received: from localhost ([::1]:48354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msCxH-0004ks-DT for larch@yhetil.org; Tue, 30 Nov 2021 18:54:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msCwt-0004kk-4d for emacs-orgmode@gnu.org; Tue, 30 Nov 2021 18:54:11 -0500 Received: from [2a00:1450:4864:20::329] (port=46907 helo=mail-wm1-x329.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1msCwr-0006tC-DK for emacs-orgmode@gnu.org; Tue, 30 Nov 2021 18:54:10 -0500 Received: by mail-wm1-x329.google.com with SMTP id c6-20020a05600c0ac600b0033c3aedd30aso15949087wmr.5 for ; Tue, 30 Nov 2021 15:54:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7bCSn+0oR49EwSJXsum37MaVzVwFAt7Rcn2D4L0xdZ4=; b=eJYOarwfst4d3W7ErUF45UD+GfZnPq/GnH3g/wdJBqSihS8OAfs2k7MLYL17BlHKZl vP+31TqEHFbdzHDUN3jlfbqg52IpZ8ctXvrjVyy/oaNX7gjWF87bxNkX1YCIPAMX2GHN GEngfWFb7vCktPb8YdCKIAu3t+Bvi/WqqAJNHWRMmsXpmZwYVNpGrRZ0KMshR0LPsJQo 6x2FJYSPQnkp7qSoBA/mhn5/huMdRfslxDPX8bPLaSm8+I34FbECCjetdYVHDYjBYSMT WAV1l+v1IASJ5W1uSNYKPhxLLCxAF/DDm0/5DCHlgQ2X073gkEKoPYV5n57YD0GxG2YZ 3rQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7bCSn+0oR49EwSJXsum37MaVzVwFAt7Rcn2D4L0xdZ4=; b=HIO5lMTlw32q0j6Mhg3rJ2ulol9zv3yA5Ey4COUmKe26M00qdIMf/gMm2nHk/hfNY4 kCXFwvF3seymjevfE3/SXaSmxq+OvA493kXH+f9PqrF8+VRZ6T9vAGut/kJ5cXxOP7+D 4Q+pjlm/9ELqGZRsirQTestA2CAzNLO54bqHmGeifSA7vAqnT6izRhDg1SaFQ+BqZU8y rMFEH7J1qN422+LhqndiZ08e8krSH3Nlh0Ur6EVScAwU+DgwLZS60Xy+HJaz3/siG4Iy QRc2CAsjYBrsu3AqPmYs/pSiYKXb4Fjpa8yC3rxrT4VRLTa7hCQJSr4ifQpNDYh+NGo/ p9iA== X-Gm-Message-State: AOAM530lOlen/9wQerlxzKxeSZ0gmvVOk7byz3tkgL70NIJ2RRhZ+JIm 1RNkunCDKgYZ529NyAEAkCpPYppwuQ/1lRdLvKc= X-Google-Smtp-Source: ABdhPJxzivvsKR6swH3DW/TvZQdBPn49XxDBudTK2jrFwNO3P7xh4PcuPw5N4rc4oFpZ/ZwQ/8bq3eCr1kWI/9K/K4A= X-Received: by 2002:a7b:c017:: with SMTP id c23mr2347594wmb.137.1638316447796; Tue, 30 Nov 2021 15:54:07 -0800 (PST) MIME-Version: 1.0 References: <87lf18fue9.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87v90cpcdx.fsf@yandex.com> <87ilwcf31l.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87pmqjkai3.fsf@gmail.com> <87fsrffknl.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87czmijtrp.fsf@gmail.com> <87o861o9sh.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87h7btpfbt.fsf@gmail.com> <87zgpli5nc.fsf@gmail.com> In-Reply-To: <87zgpli5nc.fsf@gmail.com> From: Kaushal Modi Date: Tue, 30 Nov 2021 18:53:57 -0500 Message-ID: Subject: Re: [PATCH] Fix org-comment-line-break-function To: Tim Cross Content-Type: multipart/alternative; boundary="000000000000e6907805d20a45bc" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::329 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=kaushal.modi@gmail.com; helo=mail-wm1-x329.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Lawrence , Marco Wahl , emacs-org list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638316476; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7bCSn+0oR49EwSJXsum37MaVzVwFAt7Rcn2D4L0xdZ4=; b=ZXUzRWQ50Nhl60f5iUw0Z2Ce57TZajOg97O9uLiN7xNujQGjsL0CWXI/mCMWjhz6Wqhz8w tGb8ja6PWi4SvXaw505SESXt/KE9Gyecy3zqhJxBFkvFo8RONXQgUDQywpN29I67IAU0e8 xdugR9YDAxhCUj3S2p5Gxj2vtAIxY9vZuLPUPVhK1Gu1wICh+d7SKlP8T7EjTYPv7RXbvI 1CeH0xvQrmFudlYycHy3M2YLQndLHmHt26CGC9xQsRr7PC0pbiCGuYVxg6VzQwEBt/UcpX AerhDCn7VBwu76QEQ0eTWFdTubI5DLAlEjbYU01lbHy5nCoMXx/+JthxcP3StA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638316476; a=rsa-sha256; cv=none; b=KQcs+K4y5Ooc0X9HcotUQyOdqCVuT/cGjZMqPODHGunNtVpAkIAg9aOlDx0wQsy6bm1zMm 9+4fKPy8Ao9nRyKOWcJAC+Yq0PCgllX9eNypFm9qvjmwT7l6btvsnjLc0X5D1EoxL6UB4X +V92M0yGmJygZD721I3tyOHjnIpVaOowV9CVo9G9b1GRQWs2gKVrv0dWHtbGddWmuaKOZ+ q9kXmJ+QJAiTl0rUCn4kyzQj6htXVMIj+BWgou58aT38aHQTwcmOqI9LL4YeZ4qTPWBC84 siURzFgxcBPhcjJM85upwW4QbQ8hja6IyKp/I73LxTTj8eQI+uQLacSxWg6orQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=eJYOarwf; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.81 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=eJYOarwf; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9CA46332BC X-Spam-Score: -1.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: Pkj5HqyohsHC --000000000000e6907805d20a45bc Content-Type: text/plain; charset="UTF-8" On Tue, Nov 30, 2021, 6:29 PM Tim Cross wrote: > > Regardless, I think that unless we understand the purpose of > insert-before-markers-and-inherit, we should make the patch such that it > still calls that function. Even if fill-prefix is nil there is > probably a good reason why the markers and properties need to be > modified for some situations. > Oops! You're right; I did not verify that binding within a comment. I just checked that it prevented the error. It would be good to understand the purpose of that function call and have a proper fix. > --000000000000e6907805d20a45bc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Nov 30, 2021, 6:29 PM Tim Cross <theophilusx@gmail.com> wrote:

Regardless, I think that unless we understand the purpose of
insert-before-markers-and-inherit, we should make the patch such that it still calls that function. Even if fill-prefix is nil there is
probably a good reason why the markers and properties need to be
modified for some situations.

Oops! You're right; I did not verify that = binding within a comment. I just checked that it prevented the error.=C2=A0=

It would be good to und= erstand the purpose of that function call and have a proper fix.=C2=A0