emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kaushal Modi <kaushal.modi@gmail.com>
To: Kyle Meyer <kyle@kyleam.com>, emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: Fix org.el compilation warnings
Date: Fri, 26 May 2017 22:31:12 +0000	[thread overview]
Message-ID: <CAFyQvY2-WN4gLexRY7pvO1=cT6Z_HSQrR2JTFGJAuoeNyXZ3UA@mail.gmail.com> (raw)
In-Reply-To: <87o9ufe48u.fsf@kyleam.com>

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

On Fri, May 26, 2017, 4:45 PM Kyle Meyer <kyle@kyleam.com> wrote:

>
> When I run byte-compile-file on org.el (no Org loaded, with master's Org
> first on the load-path), I don't see any of the above warnings aside
> from the one for org-agenda-include-inactive-timestamps, which is fixed
> by the patch.  And because running byte-compile-file from an Emacs
> instance is affected by what's already been loaded, I think it's better
> to focus on the output of 'make single'.
>

I thought that mixed org versions on load path could cause this. So I
checked the old org that ships with emacs master (About that, I'd like to
help syncing the org on emacs master with org 9.0.7 if I can.), but I didnt
find the function signature discrepancy as the warnings indicate.

So just for understanding, would like to know the root cause of those
warnings.

But yes, for true compilation checks, I'll start using make single.

Thanks.

> --

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1541 bytes --]

  reply	other threads:[~2017-05-26 22:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25 22:31 Fix org.el compilation warnings Kaushal Modi
2017-05-25 23:59 ` Kyle Meyer
2017-05-26  0:35   ` Kaushal Modi
2017-05-26  2:53     ` Kyle Meyer
2017-05-26  4:32       ` [PATCH] Silence byte-compiler under "make single" Kyle Meyer
2017-05-26 18:14       ` Fix org.el compilation warnings Kaushal Modi
2017-05-26 20:45         ` Kyle Meyer
2017-05-26 22:31           ` Kaushal Modi [this message]
2017-05-26 23:17             ` syncing with Emacs (was: Fix org.el compilation warnings) Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFyQvY2-WN4gLexRY7pvO1=cT6Z_HSQrR2JTFGJAuoeNyXZ3UA@mail.gmail.com' \
    --to=kaushal.modi@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).