Hello Nicolas,<div><br></div><div>Just pinging to check if the patch in the previous email got missed. </div><div><br></div><div>Apologies if you were already reviewing it. </div><div><br></div><div>Thanks. <br><br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 15, 2017, 2:07 PM Kaushal Modi &lt;<a href="mailto:kaushal.modi@gmail.com">kaushal.modi@gmail.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Thu, Jun 15, 2017 at 12:07 PM Nicolas Goaziou &lt;<a href="mailto:mail@nicolasgoaziou.fr" target="_blank">mail@nicolasgoaziou.fr</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">We do not need this dependency. In particular, there is already<br>
`org-trim&#39;.<br></blockquote><div><br></div></div></div><div dir="ltr"><div class="gmail_quote"><div>OK, switch from string-trim to org-trim. Thanks.</div></div></div><div dir="ltr"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It is confusing to provide two ways to achieve the same action. I&#39;d<br>
rather have &quot;-&quot; only.<br></blockquote><div><br></div></div></div><div dir="ltr"><div class="gmail_quote"><div>OK.</div></div></div><div dir="ltr"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Could you split this into smaller tests, each one testing one feature?<br></blockquote><div><br></div></div></div><div dir="ltr"><div class="gmail_quote"><div>Done. I ended up writing many more tests in the process. While I was doing that, I realized that only the first arg NAME was ws (whitespace) sensitive while the second arg wasn&#39;t. Now ws trimming is done on both args.</div><div><br></div><div>Revised patch is attached.</div></div></div><div dir="ltr">-- <br></div><div data-smartmail="gmail_signature"><p dir="ltr">Kaushal Modi</p>
</div></blockquote></div></div><div dir="ltr">-- <br></div><div data-smartmail="gmail_signature"><p dir="ltr">Kaushal Modi</p>
</div>