* org-datetree-insert-line and org-blank-before-new-entry
@ 2021-09-01 0:35 Richard Walker
2022-10-26 7:29 ` Ihor Radchenko
0 siblings, 1 reply; 6+ messages in thread
From: Richard Walker @ 2021-09-01 0:35 UTC (permalink / raw)
To: emacs-orgmode
A follow-up to the changes made to org-datetree-insert-line
in September 2020.
The definition now begins:
(defun org-datetree-insert-line (year &optional month day text)
(delete-region (save-excursion (skip-chars-backward " \t\n") (point)) (point))
(when (assq 'heading org-blank-before-new-entry)
(insert "\n"))
...
I'm getting blank lines inserted before new entries, and
I found a couple of sources of advice for setting org-blank-before-new-entry
( https://emacs.stackexchange.com/questions/51117/org-mode-control-whether-m-ret-inserts-a-newline-or-not-for-plain-lists
and
https://stackoverflow.com/questions/28351465/emacs-orgmode-do-not-insert-line-between-headers
)
that say to do this:
(setf org-blank-before-new-entry '((heading . nil) (plain-list-item . nil)))
Such a setting seems to be consistent with the help text of
org-blank-before-new-entry, and what org--blank-before-heading-p
expects to find. But, having made this setting,
(when (assq 'heading org-blank-before-new-entry)
(insert "\n"))
still does the insertion, since (assq 'heading org-blank-before-new-entry)
is non-nil.
Change (assq 'heading org-blank-before-new-entry)
to (org--blank-before-heading-p) here?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: org-datetree-insert-line and org-blank-before-new-entry
2021-09-01 0:35 org-datetree-insert-line and org-blank-before-new-entry Richard Walker
@ 2022-10-26 7:29 ` Ihor Radchenko
2022-10-26 22:50 ` Richard Walker
0 siblings, 1 reply; 6+ messages in thread
From: Ihor Radchenko @ 2022-10-26 7:29 UTC (permalink / raw)
To: Richard Walker; +Cc: emacs-orgmode
Richard Walker <walkerrichardj@gmail.com> writes:
> A follow-up to the changes made to org-datetree-insert-line
> in September 2020.
>
> The definition now begins:
>
> (defun org-datetree-insert-line (year &optional month day text)
> (delete-region (save-excursion (skip-chars-backward " \t\n") (point)) (point))
> (when (assq 'heading org-blank-before-new-entry)
> (insert "\n"))
> ...
>
> ...
> (setf org-blank-before-new-entry '((heading . nil) (plain-list-item . nil)))
>
> Such a setting seems to be consistent with the help text of
> org-blank-before-new-entry, and what org--blank-before-heading-p
> expects to find. But, having made this setting,
> (when (assq 'heading org-blank-before-new-entry)
> (insert "\n"))
> still does the insertion, since (assq 'heading org-blank-before-new-entry)
> is non-nil.
>
> Change (assq 'heading org-blank-before-new-entry)
> to (org--blank-before-heading-p) here?
You are indeed right.
Fixed on main now.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6bbd08f5aa81bd0b6b2b2f448a858516f388702a
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: org-datetree-insert-line and org-blank-before-new-entry
2022-10-26 7:29 ` Ihor Radchenko
@ 2022-10-26 22:50 ` Richard Walker
2022-10-27 4:02 ` [PATCH] org-manual: Suggest to wait for one month and followup when reporting bugs (was: org-datetree-insert-line and org-blank-before-new-entry) Ihor Radchenko
0 siblings, 1 reply; 6+ messages in thread
From: Richard Walker @ 2022-10-26 22:50 UTC (permalink / raw)
To: emacs-orgmode
On Wed, 26 Oct 2022 at 18:28, Ihor Radchenko <yantar92@posteo.net> wrote:
> Richard Walker <walkerrichardj@gmail.com> writes:
> ...
> > Change (assq 'heading org-blank-before-new-entry)
> > to (org--blank-before-heading-p) here?
>
> You are indeed right.
> Fixed on main now.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6bbd08f5aa81bd0b6b2b2f448a858516f388702a
Thank you so much. (I did wonder if anyone had seen my report.)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] org-manual: Suggest to wait for one month and followup when reporting bugs (was: org-datetree-insert-line and org-blank-before-new-entry)
2022-10-26 22:50 ` Richard Walker
@ 2022-10-27 4:02 ` Ihor Radchenko
2022-10-27 8:31 ` [PATCH] org-manual: Suggest to wait for one month and followup when reporting bugs Bastien Guerry
0 siblings, 1 reply; 6+ messages in thread
From: Ihor Radchenko @ 2022-10-27 4:02 UTC (permalink / raw)
To: Richard Walker, Bastien; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
Richard Walker <walkerrichardj@gmail.com> writes:
> Thank you so much. (I did wonder if anyone had seen my report.)
Actually, your report did slip through the cracks. I just happened to go
through some old mailing list threads without replies.
I think we can expose our mailing list policy a bit more in the manual.
We generally reply for new mails within 1 month. If it does not happen,
it may be a good idea to followup reminding the maintainers about the
unanswered bug report.
I am attaching tentative patch for manual that details this.
Any objections?
Bastien, WDYT?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-manual-Detail-one-month-response-time-in-the-mai.patch --]
[-- Type: text/x-patch, Size: 1017 bytes --]
From d8efe969e916f33ea6681046bcb6c72c4e8d0b97 Mon Sep 17 00:00:00 2001
Message-Id: <d8efe969e916f33ea6681046bcb6c72c4e8d0b97.1666843124.git.yantar92@posteo.net>
From: Ihor Radchenko <yantar92@posteo.net>
Date: Thu, 27 Oct 2022 11:57:48 +0800
Subject: [PATCH] org-manual: Detail one month response time in the mailing
list
* doc/org-manual.org (Feedback): Ask to wait up to one month for the
bug review and followup otherwise.
---
doc/org-manual.org | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/doc/org-manual.org b/doc/org-manual.org
index 18a050069..5f6a53f93 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -231,7 +231,8 @@ ** Feedback
respect the
[[https://www.gnu.org/philosophy/kind-communication.html][GNU Kind
Communications Guidelines]] when sending messages on this mailing
-list.
+list. Please allow up to one month for the response and followup if
+no response is received on the bug report.
#+findex: org-version
#+findex: org-submit-bug-report
--
2.35.1
[-- Attachment #3: Type: text/plain, Size: 225 bytes --]
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-29 9:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 0:35 org-datetree-insert-line and org-blank-before-new-entry Richard Walker
2022-10-26 7:29 ` Ihor Radchenko
2022-10-26 22:50 ` Richard Walker
2022-10-27 4:02 ` [PATCH] org-manual: Suggest to wait for one month and followup when reporting bugs (was: org-datetree-insert-line and org-blank-before-new-entry) Ihor Radchenko
2022-10-27 8:31 ` [PATCH] org-manual: Suggest to wait for one month and followup when reporting bugs Bastien Guerry
2022-10-29 9:41 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).