* [PATCH] org-todo-yesterday: Fix interactive arg when in agenda buffer
@ 2022-03-19 3:55 Aaron Zeng
2022-04-11 15:34 ` Aaron L. Zeng
0 siblings, 1 reply; 5+ messages in thread
From: Aaron Zeng @ 2022-03-19 3:55 UTC (permalink / raw)
To: emacs-orgmode
The following changes since commit 668205f7693e028f15240ffc043e037b411daf81:
Backport commit d52c929e3 from Emacs (2022-03-02 23:02:50 -0500)
are available in the Git repository at:
git@github.com:bcc32/org-mode.git bugfix
for you to fetch changes up to 0a073f0b0d7b0eb72f41e2edde4e070ca431ff71:
org-todo-yesterday: Fix interactive arg when in agenda buffer
(2022-03-18 23:31:37 -0400)
----------------------------------------------------------------
Aaron L. Zeng (1):
org-todo-yesterday: Fix interactive arg when in agenda buffer
lisp/org.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] org-todo-yesterday: Fix interactive arg when in agenda buffer
2022-03-19 3:55 [PATCH] org-todo-yesterday: Fix interactive arg when in agenda buffer Aaron Zeng
@ 2022-04-11 15:34 ` Aaron L. Zeng
0 siblings, 0 replies; 5+ messages in thread
From: Aaron L. Zeng @ 2022-04-11 15:34 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Aaron L. Zeng
* lisp/org.el (org-todo-yesterday): Fix an incorrect use of apply when
org-todo-yesterday intends to call org-agenda-todo-yesterday with the
same interactive arg. Before this change, the command incorrectly set
the todo state of the task to blank when called with C-u C-u C-u in an
agenda buffer (supposed to bypass any blocked checkboxes/subtasks).
TINYCHANGE
---
lisp/org.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org.el b/lisp/org.el
index 54350faee..5e326e765 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -9665,7 +9665,7 @@ nil or a string to be used for the todo mark." )
"Like `org-todo' but the time of change will be 23:59 of yesterday."
(interactive "P")
(if (eq major-mode 'org-agenda-mode)
- (apply 'org-agenda-todo-yesterday arg)
+ (org-agenda-todo-yesterday arg)
(let* ((org-use-effective-time t)
(hour (nth 2 (decode-time (org-current-time))))
(org-extend-today-until (1+ hour)))
--
2.33.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] org-todo-yesterday: Fix interactive arg when in agenda buffer
@ 2022-05-22 18:51 Aaron L. Zeng
2022-05-26 4:35 ` Ihor Radchenko
0 siblings, 1 reply; 5+ messages in thread
From: Aaron L. Zeng @ 2022-05-22 18:51 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Aaron L. Zeng
(I'm resubmitting this patch because my previous submission was in-reply-to
another email which I suspect was ignored. Would love to get this relatively
simple bug fixed. Thanks!)
* lisp/org.el (org-todo-yesterday): Fix an incorrect use of apply when
org-todo-yesterday intends to call org-agenda-todo-yesterday with the
same interactive arg. Before this change, the command incorrectly set
the todo state of the task to blank when called with C-u C-u C-u in an
agenda buffer (supposed to bypass any blocked checkboxes/subtasks).
TINYCHANGE
---
lisp/org.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org.el b/lisp/org.el
index 6842bfe9b..b3b9c777b 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -9666,7 +9666,7 @@ nil or a string to be used for the todo mark." )
"Like `org-todo' but the time of change will be 23:59 of yesterday."
(interactive "P")
(if (eq major-mode 'org-agenda-mode)
- (apply 'org-agenda-todo-yesterday arg)
+ (org-agenda-todo-yesterday arg)
(let* ((org-use-effective-time t)
(hour (nth 2 (decode-time (org-current-time))))
(org-extend-today-until (1+ hour)))
--
2.33.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] org-todo-yesterday: Fix interactive arg when in agenda buffer
2022-05-22 18:51 Aaron L. Zeng
@ 2022-05-26 4:35 ` Ihor Radchenko
2022-05-26 5:12 ` Aaron Zeng
0 siblings, 1 reply; 5+ messages in thread
From: Ihor Radchenko @ 2022-05-26 4:35 UTC (permalink / raw)
To: Aaron L. Zeng; +Cc: emacs-orgmode
"Aaron L. Zeng" <me@bcc32.com> writes:
> (I'm resubmitting this patch because my previous submission was in-reply-to
> another email which I suspect was ignored. Would love to get this relatively
> simple bug fixed. Thanks!)
>
> * lisp/org.el (org-todo-yesterday): Fix an incorrect use of apply when
> org-todo-yesterday intends to call org-agenda-todo-yesterday with the
> same interactive arg. Before this change, the command incorrectly set
> the todo state of the task to blank when called with C-u C-u C-u in an
> agenda buffer (supposed to bypass any blocked checkboxes/subtasks).
Thanks! Applied onto main via 713c15d85.
I have made amendments to the commit message. Function/symbol names
should be quoted as `org-todo-yesterday'.
Best,
Ihor
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] org-todo-yesterday: Fix interactive arg when in agenda buffer
2022-05-26 4:35 ` Ihor Radchenko
@ 2022-05-26 5:12 ` Aaron Zeng
0 siblings, 0 replies; 5+ messages in thread
From: Aaron Zeng @ 2022-05-26 5:12 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
Thanks Ihor! And, noted for the future.
On Thu, May 26, 2022 at 12:34 AM Ihor Radchenko <yantar92@gmail.com> wrote:
> "Aaron L. Zeng" <me@bcc32.com> writes:
>
> > (I'm resubmitting this patch because my previous submission was
> in-reply-to
> > another email which I suspect was ignored. Would love to get this
> relatively
> > simple bug fixed. Thanks!)
> >
> > * lisp/org.el (org-todo-yesterday): Fix an incorrect use of apply when
> > org-todo-yesterday intends to call org-agenda-todo-yesterday with the
> > same interactive arg. Before this change, the command incorrectly set
> > the todo state of the task to blank when called with C-u C-u C-u in an
> > agenda buffer (supposed to bypass any blocked checkboxes/subtasks).
>
> Thanks! Applied onto main via 713c15d85.
>
> I have made amendments to the commit message. Function/symbol names
> should be quoted as `org-todo-yesterday'.
>
> Best,
> Ihor
>
[-- Attachment #2: Type: text/html, Size: 1357 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-05-26 5:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-19 3:55 [PATCH] org-todo-yesterday: Fix interactive arg when in agenda buffer Aaron Zeng
2022-04-11 15:34 ` Aaron L. Zeng
-- strict thread matches above, loose matches on Subject: below --
2022-05-22 18:51 Aaron L. Zeng
2022-05-26 4:35 ` Ihor Radchenko
2022-05-26 5:12 ` Aaron Zeng
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).