From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6pbLMQ8a0GNTnQAAbAwnHQ (envelope-from ) for ; Tue, 24 Jan 2023 18:49:03 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id KCEEMA8a0GNemgAAG6o9tA (envelope-from ) for ; Tue, 24 Jan 2023 18:49:03 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5157B3F4AE for ; Tue, 24 Jan 2023 18:49:03 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKNOx-0006gF-AS; Tue, 24 Jan 2023 12:48:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKNOw-0006fz-7N for emacs-orgmode@gnu.org; Tue, 24 Jan 2023 12:48:06 -0500 Received: from mail-qt1-f177.google.com ([209.85.160.177]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKNOu-0003Pw-F3 for emacs-orgmode@gnu.org; Tue, 24 Jan 2023 12:48:05 -0500 Received: by mail-qt1-f177.google.com with SMTP id h24so9802100qta.12 for ; Tue, 24 Jan 2023 09:48:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UZcdRt9AF16KzhzHc4i2tMkuoEEkcSMOXQuRkg0Vy20=; b=aiOShTJ8GNwgJyD9UojtWTrrfrI78TZok3bfaqMNe4O1tA9cHAGeKfjbk0vZu7gn9+ pSPVPK39hODzJPm9cqywsJ1ZSMsOZeQrn8CP617UZItwON7ocKfzrsPdlFpwMj75+1Em r+xB7JC+6Szzd79ezv3xpnkd9OS8lZ9cJIezVvYZ2CY6WUE3h3Iwentl3D5K37Yv2MQL iJQLiGUjn8yIDfPgLUETQ4EnpQDyhtdR2ViYkeMQSB0c4OS3mqL+t4oPCv8OzUYxCrIk kmuV9KgThflMBLtkrTv1BnneO0H5sQAPvPy6saKYKEKJy44jKrmZTLYJakKGuiabZuhp l7Xg== X-Gm-Message-State: AFqh2kp8sPiB51YZ1k7x4En0gnSqhqQfyoH7DnupSeDIMP7AzIxC0q6U r5nSu5zgO+pJ6Ek95fjLHVH/cdq5rxs= X-Google-Smtp-Source: AMrXdXtrNItpzjkdL77e+NGcNvZ8o/VAFhzxcb8FzFZLWDF1x5omLWNP9q4m2U33OZ/ipdnMNnUWqw== X-Received: by 2002:ac8:7cb2:0:b0:3b6:3e4f:f876 with SMTP id z18-20020ac87cb2000000b003b63e4ff876mr37955995qtv.18.1674582482886; Tue, 24 Jan 2023 09:48:02 -0800 (PST) Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com. [209.85.128.169]) by smtp.gmail.com with ESMTPSA id z25-20020ac875d9000000b003b6382f66b1sm1599918qtq.29.2023.01.24.09.48.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jan 2023 09:48:02 -0800 (PST) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-4a2f8ad29d5so229070037b3.8 for ; Tue, 24 Jan 2023 09:48:02 -0800 (PST) X-Received: by 2002:a0d:df8f:0:b0:506:5648:ea8f with SMTP id i137-20020a0ddf8f000000b005065648ea8fmr208903ywe.363.1674582482239; Tue, 24 Jan 2023 09:48:02 -0800 (PST) MIME-Version: 1.0 References: <20230124025259.1301063-1-me@bcc32.com> <87358070bu.fsf@localhost> In-Reply-To: From: Aaron Zeng Date: Tue, 24 Jan 2023 12:47:26 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] lisp/org-agenda.el: Fix void-function string-pad in Emacs <28.1 To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Content-Type: multipart/alternative; boundary="000000000000004a4c05f3061e8b" Received-SPF: pass client-ip=209.85.160.177; envelope-from=zeng.aaron.l@gmail.com; helo=mail-qt1-f177.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.149, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674582543; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=UZcdRt9AF16KzhzHc4i2tMkuoEEkcSMOXQuRkg0Vy20=; b=tuyCD4U7j1YdjW4lN/bHsyvT9nuSQ5idiOwyw6kH64v9psc8qXqxu+/ndZCJ3V17rGWv2V 0WGqCNY/ol5kBc65cqgQ+HJHpnWN+jhs3pDH88vmu9mq2on0MfY54Msrmuu0LpdpqBbWqq SwXz61+1XIu4jm1uBJujEpEP4hcHhWmaVOSY0i7uZZWgjrQ5SB21ls6IBDeuZavb/IDrau kH187q37XpCVSzF3cDl1IDI+cuvyTSs1+JH3oEHoheG9GeA6FWPZN/6cBCQh3l8dQGBybW LszsLPgEJnmL25Vt8WmCkKK4uFrPNMPOE4xPQX2j0Ak4tnqeKQ4r+msiZwxGpA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674582543; a=rsa-sha256; cv=none; b=ikqM3iNjXC/VShFnMjNIYQDu9ikOw/8ADdoejugsP/fDR9piBUJuCVn2NBu94kwoam5Jga ElBVSWOQV19LJXfu7cB/g9aRPzh/aqAkKLRvmw9UXEjxwkk226ig2AFjIsr5WXmHnhc1d+ XMWYIrwhgs10oz7DtTgFmHFnwlJh0qdRDrOPpGWLGXsV3/u+VGBM52kM4ZYCk2T4EE+Sur droATB4v9svDw+zjqLO4K1NNoo8x5jfk94lcIjmJHvautvfuCNHPMVluI2iKS8KJy8rknU 802dCK4/36d1r46sySPOjTFNQqdfZAz+blnytL5wD0rAbGbvsgf47kk1wilOaQ== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Spam-Score: -1.38 X-Spam-Score: -1.38 X-Migadu-Queue-Id: 5157B3F4AE X-TUID: sZxi35IPpx+c --000000000000004a4c05f3061e8b Content-Type: text/plain; charset="UTF-8" Hi Ihor, I just noticed that this patch only fixes one of the lines calling `string-pad'. There is another callsite below which needs to be removed. On Tue, Jan 24, 2023 at 11:30 AM Aaron Zeng wrote: > Thanks for the quick response, Ihor! > > On Tue, Jan 24, 2023 at 4:23 AM Ihor Radchenko > wrote: > >> "Aaron L. Zeng" writes: >> >> > * org-compat.el (org-string-pad): Add compatibility function >> > `org-string-pad' for `string-pad', introduced in Emacs 28.1. >> > >> > * org-agenda.el (org-fix-agenda-info): Use `org-string-pad' rather >> > than `string-pad'. >> > >> > Since this is more-or-less just copying string-pad's definition from >> > subr-x.el, I think this qualifies for TINYCHANGE. >> >> Thanks! >> This issue has not been caught by byte-compilation. >> >> I applied an alternative fix not using `string-pad' at all. >> Canceled. >> >> >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5bbb97f3df9788646b8d48d60e8b8ea06566e05f >> >> -- >> Ihor Radchenko // yantar92, >> Org mode contributor, >> Learn more about Org mode at . >> Support Org development at , >> or support my work at >> > --000000000000004a4c05f3061e8b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Ihor, I just noticed that this patch only fixes on= e of the lines calling `string-pad'.=C2=A0 There is another callsite be= low which needs to be removed.

On Tue, Jan 24, 2023 at 11:30 AM Aaron = Zeng <me@bcc32.com> wrote:
Thank= s for the quick response, Ihor!

On Tue, Jan 24, 2023 at 4:23 AM Ihor Rad= chenko <yantar9= 2@posteo.net> wrote:
"Aaron L. Zeng" <me@bcc32.com> writes:

> * org-compat.el (org-string-pad): Add compatibility function
> `org-string-pad' for `string-pad', introduced in Emacs 28.1. >
> * org-agenda.el (org-fix-agenda-info): Use `org-string-pad' rather=
> than `string-pad'.
>
> Since this is more-or-less just copying string-pad's definition fr= om
> subr-x.el, I think this qualifies for TINYCHANGE.

Thanks!
This issue has not been caught by byte-compilation.

I applied an alternative fix not using `string-pad' at all.
Canceled.

https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3D5b= bb97f3df9788646b8d48d60e8b8ea06566e05f

--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,=
or support my work at <https://liberapay.com/yantar92>
--000000000000004a4c05f3061e8b--