From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SP6oKYRtL2H+cQAAgWs5BA (envelope-from ) for ; Wed, 01 Sep 2021 14:09:40 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id hSw0JYRtL2ENSQAAbx9fmQ (envelope-from ) for ; Wed, 01 Sep 2021 12:09:40 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 170BAE320 for ; Wed, 1 Sep 2021 14:09:40 +0200 (CEST) Received: from localhost ([::1]:46108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLP3j-0001vj-4c for larch@yhetil.org; Wed, 01 Sep 2021 08:09:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLOu5-0007Iz-AF for emacs-orgmode@gnu.org; Wed, 01 Sep 2021 07:59:41 -0400 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]:34635) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLOu3-0007Xs-SQ for emacs-orgmode@gnu.org; Wed, 01 Sep 2021 07:59:41 -0400 Received: by mail-ej1-x634.google.com with SMTP id u3so6139090ejz.1 for ; Wed, 01 Sep 2021 04:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=dIezMLcpi7uhhuD7rhQhi9hOMmjQ2DPY0nwGGRnEZHM=; b=i/tDqDCfvKieGpLA4XNXp1zytvpJ/RjclpwiKqdh1LswZJZV636A13OZQWAD29c6Bn dgke2S6kjYDByD9e4w18kSNDgll9e80p8/PcHdM/k/02CGVI/wkIC1vyTPqis0w04aLy n87PEkyyWT/CQpwrnCBGERqUJIaFfFaU7i4TIfpaNpZl4mzNn5w74nvtFHKGwYLfp1XP nXa5ymSRruzkjpYWP0lKzsJJUfe87EW7xOjgjuQPqRSGBkCPv7TgcY+F3Ez9+9XZ0Z9/ /XDezP3b9OTlc/O2RWAjUOYPQR+UH1HPPw8XmN1v8WSSrrUPn1OzALR9pXJjYyYs6U08 2oxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=dIezMLcpi7uhhuD7rhQhi9hOMmjQ2DPY0nwGGRnEZHM=; b=VYGzXHTC4zbpPZXlnq75Rx14N/mPQ2tV1O+jqtBc6wNv/XS/N8J1nIvaXNlHw0iIqk m3fdRjwn6BsDe6cmJHpiTHuGTClJg3JifStCjCMas9LyyzOnaRvVolbEdRXx+rs8ZX5Q VwxMRWPGJid+KKebKQl3lzrkv6/ObMAL9uNlqQuHTjpgyf7i6mG9Fmg5/qwBnw/gr9hT W5IQMsq69/Lptt0F6pNa1UN1AmqiUIDhfBt7RST8CA99a9VKi76kriEpm5ydCuP5Mshb Z8zz0sIJzIpFqqvEgs0KcJ+mBkNPfOciD5mkl66cD3LizAeVKwpmYz1fK21b+Yj0Xbep kptA== X-Gm-Message-State: AOAM533VPGBiLF8+LX3fXi3IrMhQ/1bvFNncXKCAv9t8uThhQ8Bu3PCj 0qN/MZDrKPCG80ztWVXYWpeczHmZz7anJmh6GlD58HWc3ON/3Q== X-Google-Smtp-Source: ABdhPJxT5QZrfZdOivnZ/FkXQ4lbFUawAhWYIDpnFJvW7PMWbNfbSPjydGe9a2+YT96vUQBcbH6aL97kkVRAbkMWNVY= X-Received: by 2002:a17:906:f2d8:: with SMTP id gz24mr10206725ejb.343.1630497577130; Wed, 01 Sep 2021 04:59:37 -0700 (PDT) MIME-Version: 1.0 From: Peder Stray Date: Wed, 1 Sep 2021 13:59:26 +0200 Message-ID: Subject: A small bug in org-file-url-p To: emacs-orgmode@gnu.org Content-Type: multipart/alternative; boundary="000000000000e45de305caedccd5" Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=peder.stray@gmail.com; helo=mail-ej1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630498180; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=dIezMLcpi7uhhuD7rhQhi9hOMmjQ2DPY0nwGGRnEZHM=; b=TICPOJ4JPRpsOIKIotOqX5HrlzPzSLGRLJRFUOu4BpcMWC+qxNCt5u3sBQalVmMBCTrZ4x YKdj7IyBuYPfLfCZHbeQ+7CY8Yxlvq+AO306MGIZ6Ebnk3Q58jjhYVjn6kCYjpmybpsP8e Fbq3ncN+KwZusrjB3hdyt/M/6po+NBi4c8bHNqQhzsNFrMZ2bIAJzXLD31MAYdhdKXwPmw jSK5v2ZbvBbnO/AVWqQmqcL4CkXQdNlvpS3rT7rs7eOIxX7VGeH5WNlhx8JK6+wHlRWwrD UVUOUawwXS4/bLuexqpy60qXMk32LgmYRdiT5DXeu2IaCbCnqBxUKYl8Nc6zew== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630498180; a=rsa-sha256; cv=none; b=pvD3UxPn9PBb2PfeR3JyjayZSF+jhTkrGriESYLxPwFjuY7E8nU1uGDSl8NokTg8Qbpm4g eb8EnMJxaWRaIW1X//XCkDewXNWhse30AlNZazxeTfxiLoERUU2LnMck5S1RdwwzGAZCsD WkoCsr7C/KsQys1CVPOk8iK51973btBBS/ihdvqGTeC9nkXu42rTTLrxGeuSqyFAvYyHfN ENztCTK7u2XszySrVB48bK5W0gnxw/BZPrbn/KG8Zh5RrxfXCANh71Tel4QatmFf52NtaT 5t/7VVDRYJhaR/ZIomR/32g6kyYlKJxeI6C5Sz7x2OJk/w9cv62Ois0J6h5yFw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b="i/tDqDCf"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.12 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b="i/tDqDCf"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 170BAE320 X-Spam-Score: -3.12 X-Migadu-Scanner: scn1.migadu.com X-TUID: T1ecdL8cZ+gS --000000000000e45de305caedccd5 Content-Type: text/plain; charset="UTF-8" Hi Just wanted to report a small bug in org-file-url-p, regarding its use of ffap-url-regexp. The documentation for ffap-url-regexp states: Regexp matching the beginning of a URI, for ffap. If the value is nil, disable URL-matching features in ffap. I have it set to nil in my setup, to disable url-matching, and this causes org-file-url-p to pass on nil in (string-match-p ffap-url-regexp file), thus causing string-match-p do die with an error. Othe code in ffap uses and to test the value of ffap-url-regexp before passing it on as in: (and ffap-url-regexp (string-match-p ffap-url-regexp file)) -- Peder Stray --000000000000e45de305caedccd5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

Just wanted to report a s= mall bug in org-file-url-p, regarding its use of ffap-url-regexp.

The documentation for ffap-url-regexp states:
Reg= exp matching the beginning of a URI, for ffap.
If the value is nil, disa= ble URL-matching features in ffap.

I have it set t= o nil in my setup, to disable url-matching, and this causes org-file-url-p = to pass on nil in (string-match-p ffap-url-regexp file), thus causing strin= g-match-p do die with an error.

Othe code in ffap = uses and to test the value of ffap-url-regexp before passing it on as in:
(and ffap-url-regexp (string-match-p ffap-url-regexp file))
--
=C2=A0 Peder Stray
--000000000000e45de305caedccd5--