emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Peder Stray <peder.stray@gmail.com>
To: emacs-orgmode@gnu.org
Subject: A small bug in org-file-url-p
Date: Wed, 1 Sep 2021 13:59:26 +0200	[thread overview]
Message-ID: <CAE4U0JGXz7NkPphqaowGvQ9XDbwod0+faVgcLFeRQkqCDy9B4g@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]

Hi

Just wanted to report a small bug in org-file-url-p, regarding its use of
ffap-url-regexp.

The documentation for ffap-url-regexp states:
Regexp matching the beginning of a URI, for ffap.
If the value is nil, disable URL-matching features in ffap.

I have it set to nil in my setup, to disable url-matching, and this causes
org-file-url-p to pass on nil in (string-match-p ffap-url-regexp file),
thus causing string-match-p do die with an error.

Othe code in ffap uses and to test the value of ffap-url-regexp before
passing it on as in:
(and ffap-url-regexp (string-match-p ffap-url-regexp file))

-- 
  Peder Stray

[-- Attachment #2: Type: text/html, Size: 1079 bytes --]

             reply	other threads:[~2021-09-01 12:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01 11:59 Peder Stray [this message]
2021-09-01 14:40 ` A small bug in org-file-url-p Timothy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAE4U0JGXz7NkPphqaowGvQ9XDbwod0+faVgcLFeRQkqCDy9B4g@mail.gmail.com \
    --to=peder.stray@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).