From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YIQmO/6S+2KKbwEAbAwnHQ (envelope-from ) for ; Tue, 16 Aug 2022 14:52:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 4KNAO/6S+2KcLgAAauVa8A (envelope-from ) for ; Tue, 16 Aug 2022 14:52:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B906613D3D for ; Tue, 16 Aug 2022 14:52:14 +0200 (CEST) Received: from localhost ([::1]:49594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNw3J-0001K9-Uw for larch@yhetil.org; Tue, 16 Aug 2022 08:52:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNw20-0001Jy-QV for emacs-orgmode@gnu.org; Tue, 16 Aug 2022 08:50:52 -0400 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:37797) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oNw1y-0005SI-Ef for emacs-orgmode@gnu.org; Tue, 16 Aug 2022 08:50:51 -0400 Received: by mail-lf1-x12e.google.com with SMTP id u1so14784800lfq.4 for ; Tue, 16 Aug 2022 05:50:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=nvJ52Zuap8QlXoK8JMvvWpQWHTLG2OLHUPIONT2svnk=; b=eOH6+JzaC79fbt9Y1UyV8LV4ehpEBY9ogW2BgNwrA5n7uAIfP9KvmKNhqb1fZps+tn MSDIf71QIHC3of5FzBQgjIRzibjdu5FmscMaFVm0AHgEKqF9ckvv2wGnZtMZbcBvVOye elEHI/H09IvPepxw6PbbBArMaLcXlSWuqWWZhOD0LtKdUAdOsOXdlS7kxVyl+VHcLfos hYp92zmOQhaeMRL9oTqpbguaeuvPP/EJGgrPHG5otspNNfDPcxFXiEhTwkdr3qW3DkpH 45zSoCzB+fjUbO5Dbq++g7D5Vg2eaI0SQU3SE32NFjJ3IqtqFeNWTL1lUUHXLBxplZY4 +ntw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=nvJ52Zuap8QlXoK8JMvvWpQWHTLG2OLHUPIONT2svnk=; b=Vbyh/9JNMd/MFTkKMz4pX1GcGMmFS00g7/c0lOYQRiYfTHQxHp0CYWc0CbcxYgnr8+ M1Bq7/5yY6FEvP03upkA6xeQzi45/VP3VPKdwJAWSW8ps1mifkhFfxjb6LNFES1waBfz nPm9X6suI5+kQGje2CfTia0PC9Cobm4Sh64XrsJigOy4yaVCBKF+OUNza6PLfwRg7sPI lZxJX9/PphdNsYel6XVu186JPlQbva0RLhr27cKKaeV64UG3XDXL8rWLoY/TFP5ngftF DS906mJALZET6SMF0Vu6hZuIiZ9JGNrO/s7D/UYvkYe0UXtbuZKaomew+s6QXCZRgBaZ nU9Q== X-Gm-Message-State: ACgBeo1cTlJIZX8geUv6B0F2BUjXqUuXnmAzDEXQbiKQfOrKGi7/xoAd GdrAexn/i7HZ5pEKaakJUjNZSi3JXW5NaSzaMmA= X-Google-Smtp-Source: AA6agR5ij9h5gauRjYY0mom2ehusKUPD8l8rm8k6LPICXg/o1IEDrCfmFcGUwDmIvCML7bZRVyrG6hcCzOjeJlLwHZk= X-Received: by 2002:a05:6512:280f:b0:48d:81c:27de with SMTP id cf15-20020a056512280f00b0048d081c27demr7294269lfb.378.1660654248036; Tue, 16 Aug 2022 05:50:48 -0700 (PDT) MIME-Version: 1.0 References: <877d384k99.fsf@localhost> <87zgg41jxt.fsf@localhost> In-Reply-To: From: Ihor Radchenko Date: Tue, 16 Aug 2022 20:51:43 +0800 Message-ID: Subject: Re: Potential bug: Invalid function: org-encode-time To: Max Nikulin Cc: emacs-orgmode Content-Type: multipart/alternative; boundary="0000000000008c902105e65b3239" Received-SPF: pass client-ip=2a00:1450:4864:20::12e; envelope-from=yantar92@gmail.com; helo=mail-lf1-x12e.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660654334; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=nvJ52Zuap8QlXoK8JMvvWpQWHTLG2OLHUPIONT2svnk=; b=Y5AwvDpxu3VFx/GLHOT7X86oLU0jp8sjl/KNuu6GHL2RzzUeFleZ4kGRv7HeZed4gK+A/q X+y2Z2mMwReiYsXdcjvp1zauT5QZflx0AlLK4uW/KiDbW18vZSw7cNpNjmbbpZCd3qabA1 Ziu1+P/fW+MjR9Be5JIqoDurIpBA4O2mmp2g5VyC1pVfS4gEamrM32cF2FN98EniKh6MnM TyRLDAOqDdaivGz5a6+kut7e2gMB6xiPipPAcprmbRMviZbLV9nqcaQp94eQL167gMWXYn pld3O92UmkJxobFfo8uGZqqBt8n/MX+tEOKv/QsVTbfyfz+yE0E+KP/9tzg1Rg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660654334; a=rsa-sha256; cv=none; b=FR/UotJizE/KF+pHRXZ6MyMGrHPLyhpeoVnO4O/q+a/3016YNx5Uq194xV37qbud3eIljj p/aCzxvNtzkiL/ygXiEVr1Fc44dTSP+H11KFOCBaHhqzTaT2FGClLujQZ6oYRWf4xMfCEz BF5K40KbQfW95k3O0PHORpD6WmNqScbxF9c0iUqBVsPt687NwQxh3IX1f1oa7urUxA5NNT yXaohORAR626+H6xeLoB0Ot5Of13rc3zVtmu/vgEKxKeKB3s08ZQVf1dCUWPnbmTZQNhmi bjhTRj5e6LeRNDpnAQf9TjhArjlSbZbuFSrIVNIdPlBkpG+aLuU6pcUUZNIefg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eOH6+Jza; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.66 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eOH6+Jza; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B906613D3D X-Spam-Score: -8.66 X-Migadu-Scanner: scn0.migadu.com X-TUID: g8dz2jNrtLQN --0000000000008c902105e65b3239 Content-Type: text/plain; charset="UTF-8" > Testing of `encode-time' version by running it on each macro expansion can hardly be called optimal. It will mostly impact the compile time. If you wish, you may wrap the version check and the `encode-time' test into `eval-when-compile' On Tue, Aug 16, 2022 at 8:44 PM Max Nikulin wrote: > On 16/08/2022 18:55, Ihor Radchenko wrote: > > Max Nikulin writes: > > > >>> This is Emacs bug. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56746 > >>> > >>> I just pushed a workaround that should hopefully fix the issue. > >> > >> Is there a chance that `eval-when-compile' around the original > >> definition will help? Sorry, I am still avoiding setting up of > >> development environment for emacs. > > > > It could, but I took a different approach. > > See > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=d3a9c424ba32382fff1da4f4ecb447dc99205261 > > Thank you for the fix. I asked about `eval-when-compile' because lack of > it may be my mistake and with hope to find a workaround with no > performance impact. Testing of `encode-time' version by running it on > each macro expansion can hardly be called optimal. > > > --0000000000008c902105e65b3239 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Testing of `encode-time' version by running it on=
each macro expansion can hardly be called optimal.

I= t will mostly impact the compile time. If you wish, you may wrap the versio= n check and the `encode-time' test into `eval-when-compile'

On= Tue, Aug 16, 2022 at 8:44 PM Max Nikulin <manikulin@gmail.com> wrote:
On 16/08/2022 18:55, Ihor Radchenko wrote:
> Max Nikulin writes:
>
>>> This is Emacs bug. https://debbugs= .gnu.org/cgi/bugreport.cgi?bug=3D56746
>>>
>>> I just pushed a workaround that should hopefully fix the issue= .
>>
>> Is there a chance that `eval-when-compile' around the original=
>> definition will help? Sorry, I am still avoiding setting up of
>> development environment for emacs.
>
> It could, but I took a different approach.
> See https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/= ?id=3Dd3a9c424ba32382fff1da4f4ecb447dc99205261

Thank you for the fix. I asked about `eval-when-compile' because lack o= f
it may be my mistake and with hope to find a workaround with no
performance impact. Testing of `encode-time' version by running it on <= br> each macro expansion can hardly be called optimal.


--0000000000008c902105e65b3239--