From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WFZMCvmR+F4/bgAA0tVLHw (envelope-from ) for ; Sun, 28 Jun 2020 12:50:01 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id yGz8BfmR+F74EwAAbx9fmQ (envelope-from ) for ; Sun, 28 Jun 2020 12:50:01 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BD9A99403C7 for ; Sun, 28 Jun 2020 12:49:58 +0000 (UTC) Received: from localhost ([::1]:43148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpWku-00031L-H1 for larch@yhetil.org; Sun, 28 Jun 2020 08:49:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpWkW-00030y-3o for emacs-orgmode@gnu.org; Sun, 28 Jun 2020 08:49:32 -0400 Received: from mail-ej1-f52.google.com ([209.85.218.52]:38324) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jpWkR-0000qp-SF for emacs-orgmode@gnu.org; Sun, 28 Jun 2020 08:49:31 -0400 Received: by mail-ej1-f52.google.com with SMTP id w16so13829523ejj.5 for ; Sun, 28 Jun 2020 05:49:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R57gJt6CG0+13OgWJ6pf2JPnogikH2yz9ANypVm/DDM=; b=GYhEo5cvGbdusZ4ZRtTF6sedLbYReHCWEs5/R952mxmbbs4grjLznl+6A4Nrrv6JeZ 1RISQbqwgjhJGLk/yImHCvXgnQ6g65OqbXO1eAIPAKNFZvihvG6m95MbkSvWg+2GWACv QYu+Y/NAG05GAtgCzpY/k4HiZCNOWjddV7/C6YEfKzQgLycrIQ8Io+vKdHsaUIkKshGn dIr4L7FT0Rqo5ceg+/rBs0/kXXGHe5Qn/bFSWd0jbvro+h88ARevDPezFUzHSaWI2PpY IgxNrLhr7aZYB/bFL8FhQNxOKcIoJtiqbXJrUCiBKlFmbq7P/3MKlHNZymBaIZOtG1Gr faUg== X-Gm-Message-State: AOAM533YU4WNQg6neDq2wDADSkIUy/FcTrLKMOKhgbfaZlnXZGI7jYqe 01xH/2sOuXeYgVKvFajil4DJW4Rn01is5AC8Boo= X-Google-Smtp-Source: ABdhPJzhzirlElQK1rJp51m1OH8GbiPWEv448YXQR9q8R2okmiUZqykD8lkk0oGsLnHCoxRx/dpGJqIYheLm+C15V20= X-Received: by 2002:a17:907:4240:: with SMTP id oi24mr9714379ejb.23.1593348566252; Sun, 28 Jun 2020 05:49:26 -0700 (PDT) MIME-Version: 1.0 References: <87d05nidu1.fsf@iki.fi> <87pn9l2i7z.fsf@iki.fi> <87eepz3faw.fsf@iki.fi> In-Reply-To: <87eepz3faw.fsf@iki.fi> From: ian martins Date: Sun, 28 Jun 2020 08:49:14 -0400 Message-ID: Subject: Re: Babel: parse error when output contains opening bracket To: Jarmo Hurri Content-Type: multipart/alternative; boundary="0000000000004b80cf05a9245fae" Received-SPF: pass client-ip=209.85.218.52; envelope-from=ianxm1@gmail.com; helo=mail-ej1-f52.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/28 08:49:26 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: 3 X-Spam_score: 0.3 X-Spam_bar: / X-Spam_report: (0.3 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=jhu.edu (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.91 X-TUID: 7LuJYP4LuA+u --0000000000004b80cf05a9245fae Content-Type: text/plain; charset="UTF-8" A little while back I submitted a patch to add org-babel integration for haxe and mentioned that the same could be done for java to expand the features of the java integration. There was no response which I took to mean no interest in haxe or java, so I didn't think submitting a patch for java would be fruitful. Then I thought I could just add them to the contrib directory but was mistaken since that goes through the same ML patch workflow. Since you recommend it, I will try submitting a patch for java. I still want to share the haxe integration. What is the best way to do that? -Ian On Sun, Jun 28, 2020 at 1:55 AM Jarmo Hurri wrote: > > >> ian martins writes: > >> > >> Would it be possible for us to fix the current version without > >> introducing a new one? Can you identify the parts of your code that fix > >> the issue? > >> > > The existing code creates the java program and runs it correctly, but > > it uses `org-babel-import-elisp-from-file' to interpret the results, > > and that sees the bracket and tries to make the response into a list, > > and errors when it can't. I don't see a quick fix for it. If you allow > > unbalanced brackets but that would be a change in ob-core and would > > probably cause unwanted results in other places. If you don't try to > > convert the output into a list, you can't present java results as > > lists or tables. Really the problem is that ob-java doesn't support > > functional mode, so it tries to guess if scripting mode output should > > be a table or list. The version I wrote supports functional and > > scripting modes and doesn't use `org-babel-import-elisp-from-file'. > > Ok. > > >> I am already a contributor, so if you can post your solution here I > >> can create a patch and give you the credit. > >> > > I would really appreciate that if you are willing, but it's a > > significant change (code is 400 lines, 600 lines of tests and test > > data) and there might be iterations so you might be signing up for > > more than you realize. > > Fair enough. > > 1. Have you considered writing a patch yourself? > > 2. If not, I think you lose nothing by posting your code here and > patiently waiting if I can create something out of it. > > All the best, > > Jarmo > > > --0000000000004b80cf05a9245fae Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
A little while back I submitted a patch to add org-ba= bel integration for haxe and mentioned that the same could be done for java= to expand the features of the java integration. There was no response whic= h I took to mean no interest in haxe or java, so I didn't think submitt= ing a patch for java would be fruitful. Then I thought I could just add the= m to the contrib directory but was mistaken since that goes through the sam= e ML patch workflow.

Since you recommend it, I wil= l try submitting a patch for java.

I still wa= nt to share the haxe integration. What is the best way to do that?

-Ian

On Sun, Jun 28, 2020 at 1:55 AM Jarmo Hurri = <jarmo.hurri@iki.fi> wrote:=

>> ian martins <ianxm@jhu.edu> writes:
>>
>> Would it be possible for us to fix the current version without
>> introducing a new one? Can you identify the parts of your code tha= t fix
>> the issue?
>>
> The existing code creates the java program and runs it correctly, but<= br> > it uses `org-babel-import-elisp-from-file' to interpret the result= s,
> and that sees the bracket and tries to make the response into a list,<= br> > and errors when it can't. I don't see a quick fix for it. If y= ou allow
> unbalanced brackets but that would be a change in ob-core and would > probably cause unwanted results in other places. If you don't try = to
> convert the output into a list, you can't present java results as<= br> > lists or tables.=C2=A0 Really the problem is that ob-java doesn't = support
> functional mode, so it tries to guess if scripting mode output should<= br> > be a table or list.=C2=A0 The version I wrote supports functional and<= br> > scripting modes and doesn't use `org-babel-import-elisp-from-file&= #39;.

Ok.

>> I am already a contributor, so if you can post your solution here = I
>> can create a patch and give you the credit.
>>
> I would really appreciate that if you are willing, but it's a
> significant change (code is 400 lines, 600 lines of tests and test
> data) and there might be iterations so you might be signing up for
> more than you realize.

Fair enough.

1. Have you considered writing a patch yourself?

2. If not, I think you lose nothing by posting your code here and
=C2=A0 =C2=A0patiently waiting if I can create something out of it.

All the best,

Jarmo


--0000000000004b80cf05a9245fae--