Re: :mkdirp without path specifier

["R. Michael Weylandt" <michael.weylandt@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

On Thu, May 1, 2014 at 3:47 PM, Michael Weylandt
<michael.weylandt@gmail.com> wrote:
> If it intended that setting :mkdirp yes should break tangling with 'directory-free' file names?
>
> I.e., should
> #############
> #+TITLE: test
> #+BEGIN_SRC python :mkdirp yes :tangle test.py
> print 1+2
> #+END_SRC
> ###############
>
> tangle without error?
>
> It currently doesn't because (file-name-directory "test.py"), which is nil, gets passed to make-directory, which throws an error.
>
> The manual is ambiguous, stating only that the arg to :tangle is interpreted as a path. A strict reading says this shouldn't work, regardless of :mkdirp, since we're not giving a path, but I think the "understood ./" of :mkdirp no is reasonable.
>

Patch attached. Should apply cleanly against master and maint.

Michael

[-- Attachment #2: 0001-Fix-tangle-with-mkdirp-yes-tangle-FILE.patch --]
[-- Type: application/octet-stream, Size: 1272 bytes --]

From d4dc8067f3a97fbd6061537e4f52bbcea0b50bc8 Mon Sep 17 00:00:00 2001
From: Michael Weylandt <michael.weylandt@gmail.com>
Date: Fri, 2 May 2014 23:30:42 -0400
Subject: [PATCH] Fix tangle with ":mkdirp yes :tangle FILE"

* ob-tangle.el (org-babel-tangle): Fix tangling with :mkdirp and :tangle FILE.
Since (file-name-directory FILE) returns nil, don't pass it to
make-directory without checking.

Fixes tangling of files like:
print 1 + 2 + 3

TINYCHANGE
---
 lisp/ob-tangle.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/ob-tangle.el b/lisp/ob-tangle.el
index be7e9a6..dd92345 100644
--- a/lisp/ob-tangle.el
+++ b/lisp/ob-tangle.el
@@ -234,7 +234,8 @@ used to limit the exported source code blocks by language."
 		      ;; Possibly create the parent directories for file.
 		      (when (let ((m (funcall get-spec :mkdirp)))
                               (and m (not (string= m "no"))))
-			(make-directory (file-name-directory file-name) 'parents))
+			(if (file-name-directory file-name)
+			    (make-directory (file-name-directory file-name) 'parents)))
 		      ;; delete any old versions of file
 		      (when (and (file-exists-p file-name)
 				 (not (member file-name (mapcar #'car path-collector))))
-- 
1.8.3.4 (Apple Git-47)