From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id Ybx5NhfjlmFmYwAAgWs5BA (envelope-from ) for ; Fri, 19 Nov 2021 00:34:47 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SJY8MBfjlmEbQAAAbx9fmQ (envelope-from ) for ; Thu, 18 Nov 2021 23:34:47 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 57D5C2BFDC for ; Fri, 19 Nov 2021 00:34:47 +0100 (CET) Received: from localhost ([::1]:58694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnqvV-0008Eh-H1 for larch@yhetil.org; Thu, 18 Nov 2021 18:34:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnquu-0008EZ-JT for emacs-orgmode@gnu.org; Thu, 18 Nov 2021 18:34:08 -0500 Received: from [2a00:1450:4864:20::32b] (port=37384 helo=mail-wm1-x32b.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnqut-0004eN-2a for emacs-orgmode@gnu.org; Thu, 18 Nov 2021 18:34:08 -0500 Received: by mail-wm1-x32b.google.com with SMTP id k37-20020a05600c1ca500b00330cb84834fso8983352wms.2 for ; Thu, 18 Nov 2021 15:34:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FlKxSwpu97tbQ1b7tsc7MwbJUHYrjPPms8uDatx2Q8M=; b=oCRkal39W9WTvyKh7IhGyye5HVzW3ffcnrMTeqVCq7jPKQPFQUS8qNMXeEP8VW0VLn W8giXQJZjxX1SmXDpTE8U4KcPLNKup0Pg5WBrjgkX3FgblHNBFicsQ1K0Kdxp1paG7UQ OCx7/14JxM4K3Ja/cpCqpafiLzhdNjR21ucKKmQDGGPYBGXLvIRCP+fhDpHzITeCFage La5yHG0MacF5PXQfR5PsibPsZtZkYQscKH/f5QhsRU0oucvVwAPAtiPfnjVYH0H3/6K+ hrr8rdYcEuNY33sj/giKT+Qs+9dIrVbgwItn2B3/fpUBo4M+pt/u5Bxn77H9M0+YSqK/ qLmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FlKxSwpu97tbQ1b7tsc7MwbJUHYrjPPms8uDatx2Q8M=; b=MMT7kDw4XyqWjD3RxQ1e1+wcqjh7ucvy+NiBXewOMmS2mYh0wzb/5+q//s1bUqrmr9 VDiQcPirD/0vkn73wHaA0gOBK2i/k/xEfzNCHnoF5rSQNStYEOmWkIc9tsR589+ZtnGh mlsIpkLWSAB4RoQZSIbYoOHR4fINIaFSZZqiBRg1XBOnHDAuLlpU5o9Ky3FLtL8m8g8G ZrfuNgaDiFDr9TxOmbuvca3LFm+L5rdTSpXQ+f9d5FAI92/Xwa0j/9RyuYz7rMI4KBgJ OpY727EkhgkKrFSeSHQLmbtjfB1rjR67hp9xe/O4DBvm8Oc2zZYxlxK9lYrp8WhL6afv xH7Q== X-Gm-Message-State: AOAM5337VO6o7SSiO9XdkfnU/rwkjFVCZrsPW7vgqMugcdb+q2+FQw+E /xEX07gMoOefOlFuyS2owEbelbsBRJ+G3Cazp7s= X-Google-Smtp-Source: ABdhPJwugZcHl5b4o2STw7ySwVtFfQ/d9lSdclW7Mqh2MjpsPnM7peti+IbrnEURM58U3myiCbPFHQQPfIwQTWLWTtA= X-Received: by 2002:a05:600c:202:: with SMTP id 2mr1190168wmi.134.1637278444571; Thu, 18 Nov 2021 15:34:04 -0800 (PST) MIME-Version: 1.0 References: <875yuh9b3t.fsf@gmail.com> <87czojh6m4.fsf@gmail.com> <8735ntg3ve.fsf@gmail.com> <87mtm1e5lt.fsf@gmail.com> In-Reply-To: <87mtm1e5lt.fsf@gmail.com> From: Tom Gillespie Date: Thu, 18 Nov 2021 15:33:48 -0800 Message-ID: Subject: Re: [PATCH] Accept more :tangle-mode specification forms To: Timothy Content-Type: text/plain; charset="UTF-8" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::32b (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=tgbugs@gmail.com; helo=mail-wm1-x32b.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org Mode List Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637278487; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=FlKxSwpu97tbQ1b7tsc7MwbJUHYrjPPms8uDatx2Q8M=; b=NUHNCd1xJTzPfGjNoHN4KJuB3lTOxYVNWKc9lWvZLSD/4Sfp/R8SvAGvZTl2NAevv8aQwO betc45dJkaDt6QvE45n0RTMvwIC7aevm/qfK7dtWtFyH+I9s4p0DZCWORxK3isMwV2P035 c+60Q9zVdVbWPln1NHgOhThnrxAFlOEeeUUtoOyQk4B2TcHdtA/wXfG0+KA+esbKs3Mhue /UIbbb6qIYFOiQBClK1KtPCPj4F7jDKOWG7VaLfiXMo9TDPmo6Fr8xUob7fSzSAqWXhZUH gHpvYx8ZGBEopsR6ndXnYJ3anMSNOXMkcLTIz1HOyDgGHpWktZoJzoRDh9G82Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637278487; a=rsa-sha256; cv=none; b=p5K1OvCz0hnQ2IOAZfo8+NV3mO/NVRYYLrFw7RIidlkdhRZ6wmifiTwyXhyoC97855Xkum ri/vNUkVJaVau9XLPiAC+vWVdmzQFUbx+B83ZshhD89AqwvbH/qOV+2sr9Tl3Dg7WD56iG Ht6z6PH0rdX/a2u3M5GdY5/te6CHuLUvXR6N/H63CeC5FhuN4ZlCXFBAZBvg/1d/Rek0zd UGroqkDtgSptJuYtJ0uXJHtoY3cyrZ8DPKadGlXa308lmQ89kUQUTVzXKZ4W2cDSGBtr04 41M0c1DBHvK/im21A45KnPwHnm5PJhVJNuOfuNbNK416fsjbZztqqe7rX9YuKQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oCRkal39; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -4.06 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oCRkal39; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 57D5C2BFDC X-Spam-Score: -4.06 X-Migadu-Scanner: scn1.migadu.com X-TUID: +JIvputWHRIa Hi Timothy, The confusion with 755 and "755" could lead to security issues in cases like 600 vs "600" vs #o600. The need to protect against the 600 case is fairly important, however I don't think there is anything we can do about it, because someone might want to enter their modes as base 10 integers. If we were to prepend every integer with #o (or setting the radix to 8 when reading this particular field) before passing it to org-babel-parse-header-arguments then it would be impossible to use base 10 integers unless they were provided in the #10r600 form (Emacs doesn't support #d600 notation). I think the best bet is to change the radix for bare integers to 8 when reading that particular header, however I don't know how complex that would be to implement. If we don't want to change the radix to 8 then here are some suggestions. If #o0600 already parses correctly, then I suggest we leave things as is. Adding complexity just to drop the leading # seems wasteful. We may want to warn or raise an error if someone uses a value such as the base 10 integer 600 which does not map to the usual expected octac codes so that they don't silently get bad file modes that could leave files readable to the world. Best, Tom