From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iLwKC80/lmNM0wAAbAwnHQ (envelope-from ) for ; Sun, 11 Dec 2022 21:38:37 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mCdZCs0/lmM6FgAAG6o9tA (envelope-from ) for ; Sun, 11 Dec 2022 21:38:37 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A67C682E7 for ; Sun, 11 Dec 2022 21:38:36 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4T56-0002e4-S9; Sun, 11 Dec 2022 15:37:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4T54-0002dc-DK for emacs-orgmode@gnu.org; Sun, 11 Dec 2022 15:37:50 -0500 Received: from mail-yb1-xb2d.google.com ([2607:f8b0:4864:20::b2d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4T52-0003VC-PU for emacs-orgmode@gnu.org; Sun, 11 Dec 2022 15:37:50 -0500 Received: by mail-yb1-xb2d.google.com with SMTP id g4so11467740ybg.7 for ; Sun, 11 Dec 2022 12:37:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=W6v9EvHU/G6wYlmat8q+e1Qp/p3BYydWCof9eJmHISU=; b=g24d2AdWLpPvlbSPIzYIahmFaCrMoN2Ep6yg09ptFEKWturdX7MSBQ8W+2UMw+3nPU wef7fOZ1SaN2UwkORo4MdD64vpCcOXIOkOn9FFL6q2AWv6RAmS6AE6tQzb1QGzdzyYlJ zqcnOFsLvKGfNQW6MDdRFwRHz/PIPnv+PSr+ibMG+MpEN3grt5Id53r5aRTBnaxnTBVK Ix1lQe5VlBImLM3oAB9aDtkf43E8IrqF2HREoKhPfDP6Qanp3CgffYkso+BNlPII5AD+ xCWY8IfRi3Z/2+4319n8MMk44mtkaAc7PvoTuyUb/6oZcm9XruVyB/Zi9sL0ewV2ZEpW a9mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W6v9EvHU/G6wYlmat8q+e1Qp/p3BYydWCof9eJmHISU=; b=yesSd0nUKqzaGkHQURo3Oyri3wnOAauO3QOGIAxlfA4r2uSG0RE0xEYskgwlCODupz 16soLDWRbRlfoPqGwdWbTKBcOCQQp3F8tb0UKcADv1oQAGA57u2saj5rFRlGRnnvvHCK gSZHQD+aOpvflaQKXZQ+568CU7M8/CYRP91yxF6Etc0ZnRT57lSvzi+WkRhMkhPBzbSV a3JpT8XiCQ5Th5VDlhT28fceO0Gc+Hs6T8fIWFYXRb5Ltw4aIz6izhFuythUldiQeShp 2Ye5ykH5+97Pf6DDo/G9CbzCkI2oSIWNttbdVEjlAfPAm8si7GsRN8nAwBCjQnhI8+wg wkrA== X-Gm-Message-State: ANoB5pmrUA6HsZG2tCoxZ34Vx5Cfl4uWa9M6ILiPXvlv8cuqRarpXVSZ wtpX/+gJ52eo4giQnhY46lXRxt55hcwhoLwWLeDgtCkH X-Google-Smtp-Source: AA0mqf6ETn5J2xkPWv3+tNIQl1eohZ6RctZC3e2i105EIfaGKTnlid1zIVGN0PV/h85BI34/+E3/e1vrrcGEnNh1rXs= X-Received: by 2002:a25:bd4c:0:b0:706:d47d:ef59 with SMTP id p12-20020a25bd4c000000b00706d47def59mr9293146ybm.62.1670791065137; Sun, 11 Dec 2022 12:37:45 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Tom Gillespie Date: Sun, 11 Dec 2022 12:37:33 -0800 Message-ID: Subject: Re: [PATCH] ob-core: add org-confirm-babel-evaluate-cell custom variable To: emacs-orgmode@gnu.org Content-Type: multipart/mixed; boundary="000000000000eef24d05ef935b7d" Received-SPF: pass client-ip=2607:f8b0:4864:20::b2d; envelope-from=tgbugs@gmail.com; helo=mail-yb1-xb2d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670791116; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=W6v9EvHU/G6wYlmat8q+e1Qp/p3BYydWCof9eJmHISU=; b=H2b39eQowR+BWCJkxoq87sYuLcyJk5gFXvx+3D9v09WOnqNHvH/gpygM1zIpccUTGb7rBF p4cS+6PtFHFFRhUbv7uR8s0U+N2rmpRvaGnn74ZANiX6rdjsqcqi0NDSUcHT01x7lBaH2k d7zmWqJixkruKblfCPXwXDdEQXjUO6VPotyWlhVVwfLhS1qw4+UG2XTtKmj8W/Vlk1I+2I GQEdbK0E3Z3pLohdIOGSnmjIHuXkk/PlH0K0ibrG2JWhV848t71Opuwm3xT+hX1BHRJ9Ot CFPE3CE0j6ddUNZ8O5wEwqA+FrRpqUMYFHZNF0p0T3Mc+U5csQQgUBx1cliVcA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=g24d2AdW; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670791116; a=rsa-sha256; cv=none; b=F0D0jmJ691vg6bV1oMr9wnPE/W+2RBnVPGaOqv8HkWa4D2I6Xs3kc1MfksoU5btkdlFvT2 Fi1TG02djkV6KrCGN6e2jSVKc3KrGiidR/8PiedmKdNObLSbsCMhnt/20kegtRvsKxY4gR 3uaLUhG+MAaQmEsC22nVUm2Rq0szV4+AOvaNJpAQrsN6jAUE3uxsyYFN2vmIyb6e/BvA5/ hEevdir/gXJPKD+NDViYLu2O4AV4Uzc9Ma3zzLp8zLk1jlbnsk3bNKX5laW5EZ/0kqc4CB 7/Q9nK0XlWByVHK9NfSFPh7yjnD7W4NgeaiDU4k3138PHu5L+FFDXR7X6oPzAg== X-Migadu-Spam-Score: -9.59 X-Spam-Score: -9.59 X-Migadu-Queue-Id: A67C682E7 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=g24d2AdW; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com X-TUID: dpJTkYyNyCOE --000000000000eef24d05ef935b7d Content-Type: text/plain; charset="UTF-8" Here is an updated version of the patch with the convention corrected and the docstring updated for clarity. It would be great to try to get this into any 9.6 patches before the 29 release, but I'm not sure if that is possible. If it is missing we are likely to get a lot of messages from unhappy users. Best! Tom --000000000000eef24d05ef935b7d Content-Type: text/x-patch; charset="US-ASCII"; name="0001-ob-core-add-org-confirm-babel-evaluate-cell-custom-v.patch" Content-Disposition: attachment; filename="0001-ob-core-add-org-confirm-babel-evaluate-cell-custom-v.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lbjtu79k0 RnJvbSA1NGU0NjhiNjBmMTdiNTRkODFlZGFmZDhlZTllMjIzMTFlNTE5NzkzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gR2lsbGVzcGllIDx0Z2J1Z3NAZ21haWwuY29tPgpEYXRl OiBTYXQsIDEwIERlYyAyMDIyIDEyOjExOjE3IC0wODAwClN1YmplY3Q6IFtQQVRDSF0gb2ItY29y ZTogYWRkIG9yZy1jb25maXJtLWJhYmVsLWV2YWx1YXRlLWNlbGwgY3VzdG9tIHZhcmlhYmxlCgoq IGxpc3Avb2ItY29yZS5lbCAob3JnLWNvbmZpcm0tYmFiZWwtZXZhbHVhdGUtY2VsbCk6IEFkZGVk IHRvIGNvbnRyb2wKZXhlY3V0aW9uIG9mIGNlbGxzIHNlcGFyYXRlIGZyb20gZXhlY3V0aW9uIG9m IHNyYyBibG9ja3MsIGl0IHdvcmtzIGluCmV4YWN0bHkgdGhlIHNhbWUgd2F5IGFzIG9yZy1jb25m aXJtLWJhYmVsLWV2YWx1YXRlLgoqIGxpc3Avb2ItY29yZS5lbCAob3JnLWJhYmVsLXJlYWQpOiBv cmctY29uZmlybS1iYWJlbC1ldmFsdWF0ZS1jZWxsIGlzCm5vdyB1c2VkIHRvIGNoZWNrIGNlbGxz IGluZGVwZW5kZW50IG9mIG9yZy1jb25maXJtLWJhYmVsLWV2YWx1YXRlLgoKRm9sbG93aW5nIHRo ZSBjaGFuZ2UgaW4gMTBlODU3ZDQyODU5YTU1YjIzY2Q0MjA2ZmZjZTNlYmQwZjY3ODU4MyBpdApi ZWNhbWUgZXh0cmVtZWx5IGFubm95aW5nIHRvIHRhbmdsZSBmaWxlcyB0aGF0IG1ha2UgZXh0ZW5z aXZlIHVzZSBvZgplbGlzcCBleHByZXNzaW9uIGluIHNyYyBibG9jayAjK2hlYWRlcjogc3RhdGVt ZW50cy4KClRoaXMgY29tbWl0IHJlc29sdmVzIHRoZSBpc3N1ZSBieSBtYWtpbmcgaXQgcG9zc2li bGUgdG8gaWdub3JlIGNoZWNrcwpvbiBjZWxscyAodGhlIG9sZCBiZWhhdmlvcikgd2l0aG91dCBj b21wcm9taXNpbmcgZ2VuZXJhbCBzZWN1cml0eSBmb3IKcnVubmluZyBzcmMgYmxvY2tzLgoKVGhp cyBpcyBuZWNlc3NhcnkgYmVjYXVzZSB0aGVyZSBpcyBubyBlYXN5IHdheSB0byBob3Agc3dhcApv cmctY29uZmlybS1iYWJlbC1ldmFsdWF0ZSBiZXR3ZWVuIG9yZy1nZXQtc3JjLWJsb2NrLWluZm8g d2hlcmUKb3JnLWJhYmVsLXJlYWQgaXMgY2FsbGVkIGFuZCB0aGUgZXhlY3V0aW9uIG9mIHRoYXQg c3JjIGJsb2NrLiBJdCBjb3VsZApwcm9iYWJseSBiZSBkb25lIHVzaW5nIGFkdmljZSBhcm91bmQg b3JnLWJhYmVsLXJlYWQsIGJ1dCB0aGF0IGlzIGEKbGV2ZWwgb2YgaGFja2VyeSB0aGF0IHNob3Vs ZCBiZSBhdm9pZGVkLgotLS0KIGxpc3Avb2ItY29yZS5lbCB8IDIwICsrKysrKysrKysrKysrKyst LS0tCiAxIGZpbGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9saXNwL29iLWNvcmUuZWwgYi9saXNwL29iLWNvcmUuZWwKaW5kZXggNjJiMGQz NjEyLi42MGRhYmFiMGEgMTAwNjQ0Ci0tLSBhL2xpc3Avb2ItY29yZS5lbAorKysgYi9saXNwL29i LWNvcmUuZWwKQEAgLTEyOCw2ICsxMjgsMTUgQEAgcmVtb3ZlIGNvZGUgYmxvY2sgZXhlY3V0aW9u IGZyb20gdGhlIGBcXFtvcmctY3RybC1jLWN0cmwtY10nIGtleWJpbmRpbmcuIgogOzsgZG9uJ3Qg YWxsb3cgdGhpcyB2YXJpYWJsZSB0byBiZSBjaGFuZ2VkIHRocm91Z2ggZmlsZSBzZXR0aW5ncwog KHB1dCAnb3JnLWNvbmZpcm0tYmFiZWwtZXZhbHVhdGUgJ3NhZmUtbG9jYWwtdmFyaWFibGUgKGxh bWJkYSAoeCkgKGVxIHggdCkpKQogCisoZGVmY3VzdG9tIG9yZy1jb25maXJtLWJhYmVsLWV2YWx1 YXRlLWNlbGwgdAorICAiQ29uZmlybSBiZWZvcmUgZXZhbHVhdGluZyBhIGNlbGwuCitUaGlzIGZv bGxvd3MgdGhlIHNhbWUgY29udmVudGlvbnMgYXMgYG9yZy1jb25maXJtLWJhYmVsLWV2YWx1YXRl Jy4iCisgIDpncm91cCAnb3JnLWJhYmVsCisgIDp2ZXJzaW9uICIyOS4xIgorICA6dHlwZSAnKGNo b2ljZSBib29sZWFuIGZ1bmN0aW9uKSkKKzs7IGRvbid0IGFsbG93IHRoaXMgdmFyaWFibGUgdG8g YmUgY2hhbmdlZCB0aHJvdWdoIGZpbGUgc2V0dGluZ3MKKyhwdXQgJ29yZy1jb25maXJtLWJhYmVs LWV2YWx1YXRlLWNlbGwgJ3NhZmUtbG9jYWwtdmFyaWFibGUgKGxhbWJkYSAoeCkgKGVxIHggdCkp KQorCiAoZGVmY3VzdG9tIG9yZy1iYWJlbC1uby1ldmFsLW9uLWN0cmwtYy1jdHJsLWMgbmlsCiAg ICJcXDxvcmctbW9kZS1tYXA+XAogUmVtb3ZlIGNvZGUgYmxvY2sgZXZhbHVhdGlvbiBmcm9tIHRo ZSBgXFxbb3JnLWN0cmwtYy1jdHJsLWNdJyBrZXkgYmluZGluZy4iCkBAIC0zMTgwLDExICszMTg5 LDE0IEBAIHNpdHVhdGlvbnMgaW4gd2hpY2ggaXMgaXQgbm90IGFwcHJvcHJpYXRlLiIKIAkJICAo c3RyaW5nPSBjZWxsICIqdGhpcyoiKSkpCiAgICAgICAgICA7OyBQcmV2ZW50IGFyYml0cmFyeSBm dW5jdGlvbiBjYWxscy4KICAgICAgICAgIChpZiAoYW5kIChtZW1xIChzdHJpbmctdG8tY2hhciBj ZWxsKSAnKD9cKCA/YCkpCisgICAgICAgICAgICAgICAgICAoaWYgKGZ1bmN0aW9ucCBvcmctY29u ZmlybS1iYWJlbC1ldmFsdWF0ZS1jZWxsKQorICAgICAgICAgICAgICAgICAgICAgIChmdW5jYWxs IG9yZy1jb25maXJtLWJhYmVsLWV2YWx1YXRlLWNlbGwgImVtYWNzLWxpc3AiIGNlbGwpCisgICAg ICAgICAgICAgICAgICAgIG9yZy1jb25maXJtLWJhYmVsLWV2YWx1YXRlLWNlbGwpCiAgICAgICAg ICAgICAgICAgICAobm90IChvcmctYmFiZWwtY29uZmlybS1ldmFsdWF0ZQotICAgICAgICAgICAg ICAgICAgICAgIDs7IFNlZSBgb3JnLWJhYmVsLWdldC1zcmMtYmxvY2staW5mbycuCi0gICAgICAg ICAgICAgICAgICAgICAgKGxpc3QgImVtYWNzLWxpc3AiIChmb3JtYXQgIiVTIiBjZWxsKQotICAg ICAgICAgICAgICAgICAgICAgICAgICAgICcoKDpldmFsIC4geWVzKSkgbmlsIChmb3JtYXQgIiVT IiBjZWxsKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5pbCBuaWwpKSkpCisgICAgICAg ICAgICAgICAgICAgICAgICA7OyBTZWUgYG9yZy1iYWJlbC1nZXQtc3JjLWJsb2NrLWluZm8nLgor ICAgICAgICAgICAgICAgICAgICAgICAgKGxpc3QgImVtYWNzLWxpc3AiIChmb3JtYXQgIiVTIiBj ZWxsKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJygoOmV2YWwgLiB5ZXMpKSBuaWwg KGZvcm1hdCAiJVMiIGNlbGwpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBuaWwgbmls KSkpKQogICAgICAgICAgICAgIDs7IE5vdCBhbGxvd2VkLgogICAgICAgICAgICAgICh1c2VyLWVy cm9yICJFdmFsdWF0aW9uIG9mIGVsaXNwIGNvZGUgJVMgYWJvcnRlZC4iIGNlbGwpCiAJICAgKGV2 YWwgKHJlYWQgY2VsbCkgdCkpKQotLSAKMi4zNy40Cgo= --000000000000eef24d05ef935b7d--