From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MKn7L6LzlGMRIQAAbAwnHQ (envelope-from ) for ; Sat, 10 Dec 2022 22:01:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id cGgLMKLzlGPVgQAA9RJhRA (envelope-from ) for ; Sat, 10 Dec 2022 22:01:22 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 472E795A3 for ; Sat, 10 Dec 2022 22:01:22 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p46xS-0000HZ-2w; Sat, 10 Dec 2022 16:00:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p46xQ-0000HO-2b for emacs-orgmode@gnu.org; Sat, 10 Dec 2022 16:00:28 -0500 Received: from mail-yw1-x1133.google.com ([2607:f8b0:4864:20::1133]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p46xO-0003Gz-0I for emacs-orgmode@gnu.org; Sat, 10 Dec 2022 16:00:27 -0500 Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-3b10392c064so96553497b3.0 for ; Sat, 10 Dec 2022 13:00:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WHOC5MH1jy/jmMvHn6vFzH+7nOkaK0j+D8JxQYcrPa0=; b=fKdfYgmw1T4oW2LlnGXoYOZJVhnabbCnGQC+qmXuQtVvLFp4WLr4PUEl47tLC+Rybt YwSir0tg1mrCsOc0QGkTVxr63Hy5TxKxBj8KKDKtqIe9J6e9hIUfuPzWu6QkU9zvMsSr kZVx05zV2JKRZs3loRpt6Y/x8xl1qcQBzff4sHbs6AJOsOjqn+tbmA6lgc/um6S+sCSp R9p8lxW/U+i91L3kC/QBhjkES3JZ4GsFspQjkz+wzEh/RARTPbb2lB1vGPG6yUaJOAtL S9E7hoQpTxx/+y07gbEOBWQ0LyI81xCaQzf9k1w8NAMMHCVEA0YtB/eJ7XidXwYWv2xB jZIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WHOC5MH1jy/jmMvHn6vFzH+7nOkaK0j+D8JxQYcrPa0=; b=cG2vOqAwJ+q5IrZyO1OgVOAC3ZZ8M6hMGK46ik3HnzK0r5cwqIt9WV3GJmD06B1PRh WMTKzwg+jXJ0L1E6fp0G/DfKMtO1AtSwFwXqbpT5HKxqs0TBHDBrPFnMQLZMbuDRpRvM eH7MKVs+lvyjk2B2l/KormPTWWmX++y+kRc+D6ZwBZ3PBTfwz/zJdpM3J034pVmvmPtO E5wLUCfVU5XsXI27z1IQu2916GH7707omovSF8jtV6MQkIkGlh12ijhe7D3btF0lcR9W sw7ymB/8WvgNmCbZw+lleYooAPNpOpYqeaepRk0Uj9WPxlVH4uLLFJ6Fb0qB0OTB6qSK uFcw== X-Gm-Message-State: ANoB5plfAQxnVNU67zcCrQfPHQZX9GQfxQTjeji4Svy2nO/ygfCM/5pl SJzy+sJmWO69KXt0MzxiDXdmA8fMVRp0urdPhWgqYk2b X-Google-Smtp-Source: AA0mqf6t/MVom6axXNH5Uops/srHUqaQq77sphPO1EK5L19FQuR/48r7tV77OI9cv2Ud3e7Qk/A2pwlGOko/naJ3o7Y= X-Received: by 2002:a81:4b05:0:b0:38d:e8f4:c8ba with SMTP id y5-20020a814b05000000b0038de8f4c8bamr24759776ywa.159.1670706024884; Sat, 10 Dec 2022 13:00:24 -0800 (PST) MIME-Version: 1.0 References: <87leni86l5.fsf@localhost> In-Reply-To: <87leni86l5.fsf@localhost> From: Tom Gillespie Date: Sat, 10 Dec 2022 13:00:13 -0800 Message-ID: Subject: Re: [PATCH] lisp/org-expiry.el: Account for org-time-stamp-formats To: Ihor Radchenko Cc: emacs-orgmode Content-Type: multipart/mixed; boundary="0000000000002385f905ef7f8f49" Received-SPF: pass client-ip=2607:f8b0:4864:20::1133; envelope-from=tgbugs@gmail.com; helo=mail-yw1-x1133.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670706082; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=WHOC5MH1jy/jmMvHn6vFzH+7nOkaK0j+D8JxQYcrPa0=; b=e+GxQRxEup5zU9zbEWc/8KkIYdAx3SZuCmgUTwj6Bc3zIO/c+5TjG1IemHaeoqT0KsL3ke PSY3QVuXBDefYzQDzeyeNHbohkNXG7RjpucomQ3XY/aSdIo8Lj0m29a9w7IpTQm3l0xy2t UMtmo6Syi/ovyH8gdhPEQzMb9dmuBSgQIUWRjSyBZwIKMWXg6FI2/FHWqT2ZlJNIA9vWyt DMElZGGKr9e7bEs9J/AOWy4BPETCrIig/QSps1vTq4hR9XuYqE2+mNYp6SSHwE+fVaUjXp jH8Xlz9947LCATRxuoZlzbH2SQM7gXOyKQk4AIeGI9YYZP4bpCRFfxWakYHUqg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670706082; a=rsa-sha256; cv=none; b=ayyoKy36zb35htTvkrsvhtHHFjITkev5oYgkpJZVoz4XUYcxXNsobz0HXMDiQLVLb+atIx 7WrkN/pfuZK9g/ksLIzuxuUAz6DCoFMU57ySYBMVA2JwTHbXa1jf2cfWPC+KMWTAQn/5pR XZqoYcfqbvoFt9B7ekqjNfooukWPP3Fu4jfl3Ej7dB3d5Ur8+G2cYFFGS3npZMLuYHh7g2 p6w0Ay4Pg2VwGeYtdnLstwbqt+TTJ7HWN7Mslc6ccpEs2WHpMHKL71KeRCX1JfgmxOrPBi jKuEPszBK83Rf0QqjN0r4lxGYb/e1JcDz7dHVAhIxUTG3ksR3SZlgeNOEUc2aw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=fKdfYgmw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.35 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=fKdfYgmw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 472E795A3 X-Spam-Score: -1.35 X-Migadu-Scanner: scn1.migadu.com X-TUID: keGhQr3zhSYW --0000000000002385f905ef7f8f49 Content-Type: text/plain; charset="UTF-8" Here is an updated patch. Best! Tom On Thu, Dec 8, 2022 at 3:42 AM Ihor Radchenko wrote: > > Tom Gillespie writes: > > > Hi, > > Here is a patch for org-contrib/lisp/org-expiry.el to account for > > recent changes to org-time-stamp-formats. Best, > > Tom > > > > PS is this list still the best place to send org-contrib patches? > > Yes, this list is suitable as long as org-expiry is orphaned. > > For the patch, note that it is not a good idea to bump the minimal > required Org version of Org 9.6. I'd rather suggest keeping backwards > compatibility by stripping "<" and ">" from org-time-stamp-formats, if > any. That will not affect existing users of older Emacs versions and > built-in Org. > > -- > Ihor Radchenko // yantar92, > Org mode contributor, > Learn more about Org mode at . > Support Org development at , > or support my work at --0000000000002385f905ef7f8f49 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-lisp-org-expiry.el-Account-for-org-time-stamp-format.patch" Content-Disposition: attachment; filename="0001-lisp-org-expiry.el-Account-for-org-time-stamp-format.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lbif7zky0 RnJvbSAyNDgxMDQ5NTU3MDdhNzE5NWE1OTQ3MTJkMWM3YWQ5ZDY0ZGVlMWMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gR2lsbGVzcGllIDx0Z2J1Z3NAZ21haWwuY29tPgpEYXRl OiBTdW4sIDQgRGVjIDIwMjIgMDE6MDI6MzUgLTA4MDAKU3ViamVjdDogW1BBVENIXSBsaXNwL29y Zy1leHBpcnkuZWw6IEFjY291bnQgZm9yIG9yZy10aW1lLXN0YW1wLWZvcm1hdHMKIHJlZmFjdG9y CgoqIGxpc3Avb3JnLWV4cGlyeS5lbCAob3JnLWV4cGlyeS1pbnNlcnQtY3JlYXRlZCkKKG9yZy1l eHBpcnktaW5zZXJ0LWV4cGlyeSk6IHRpbWVzdGFtcCBmb3JtYXRzIGRyb3BwZWQgZGVsaW1pdGVy cyBzbyBhCnNsaWdodCBtb2RpZmljYXRpb24gaXMgcmVxdWlyZWQgZm9sbG93aW5nIG9yZyBjb21t aXQKZTNhN2MwMTg3NGM5YmI4MGUwNGZmYTU4YzU3ODYxOWZhZjA5ZTdmMCwgdGhlIGNoYW5nZSBp cyBtYWRlIGJhY2t3YXJkCmNvbXBhdGlibGUgYnkgcmVtb3ZpbmcgPCBhbmQgPiBmcm9tIHRoZSBv bGQgdGltZXN0YW1wIGZvcm1hdAotLS0KIGxpc3Avb3JnLWV4cGlyeS5lbCB8IDIyICsrKysrKysr KysrKysrLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCA4IGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avb3JnLWV4cGlyeS5lbCBiL2xpc3Avb3JnLWV4cGly eS5lbAppbmRleCA5OGFkNThhLi4wOTA5YWFmIDEwMDY0NAotLS0gYS9saXNwL29yZy1leHBpcnku ZWwKKysrIGIvbGlzcC9vcmctZXhwaXJ5LmVsCkBAIC0yOTksMTAgKzI5OSwxMyBAQCB1cGRhdGUg dGhlIGRhdGUuIgogICAgICAgKHNldHEgZC1ob3VyIChmb3JtYXQtdGltZS1zdHJpbmcgIiVIOiVN IiBkLXRpbWUpKQogICAgICAgKHNldHEgdGltZXN0cgogCSAgICA7OyB0d28gQy11IHByZWZpeGVz IHdpbGwgY2FsbCBvcmctcmVhZC1kYXRlCi0JICAgIChpZiAoZXF1YWwgYXJnICcoMTYpKQotCQko Y29uY2F0ICI8IiAob3JnLXJlYWQtZGF0ZQotCQkJICAgICBuaWwgbmlsIG5pbCBuaWwgZC10aW1l IGQtaG91cikgIj4iKQotCSAgICAgIChmb3JtYXQtdGltZS1zdHJpbmcgKGNkciBvcmctdGltZS1z dGFtcC1mb3JtYXRzKSkpKQorICAgICAgICAgICAgKGNvbmNhdCAiPCIKKyAgICAgICAgICAgICAg ICAgICAgKGlmIChlcXVhbCBhcmcgJygxNikpCisgICAgICAgICAgICAgICAgICAgICAgICAob3Jn LXJlYWQtZGF0ZSBuaWwgbmlsIG5pbCBuaWwgZC10aW1lIGQtaG91cikKKyAgICAgICAgICAgICAg ICAgICAgICAoZm9ybWF0LXRpbWUtc3RyaW5nCisgICAgICAgICAgICAgICAgICAgICAgIChzdHJp bmctcmVwbGFjZSAiPCIgIiIKKyAgICAgICAgICAgICAgICAgICAgICAgKHN0cmluZy1yZXBsYWNl ICI+IiAiIiAoY2RyIG9yZy10aW1lLXN0YW1wLWZvcm1hdHMpKSkpKQorICAgICAgICAgICAgICAg ICAgICAiPiIpKQogICAgICAgOzsgbWF5YmUgdHJhbnNmb3JtIHRvIGluYWN0aXZlIHRpbWVzdGFt cAogICAgICAgKGlmIG9yZy1leHBpcnktaW5hY3RpdmUtdGltZXN0YW1wcwogCSAgKHNldHEgdGlt ZXN0ciAoY29uY2F0ICJbIiAoc3Vic3RyaW5nIHRpbWVzdHIgMSAtMSkgIl0iKSkpCkBAIC0zMjAs MTAgKzMyMywxMyBAQCBhbmQgaW5zZXJ0IHRvZGF5J3MgZGF0ZS4iCiAgICAgKHNldHEgZC10aW1l IChpZiBkIChvcmctdGltZS1zdHJpbmctdG8tdGltZSBkKQogCQkgICAoY3VycmVudC10aW1lKSkp CiAgICAgKHNldHEgZC1ob3VyIChmb3JtYXQtdGltZS1zdHJpbmcgIiVIOiVNIiBkLXRpbWUpKQot ICAgIChzZXRxIHRpbWVzdHIgKGlmIHRvZGF5Ci0JCSAgICAgIChmb3JtYXQtdGltZS1zdHJpbmcg KGNkciBvcmctdGltZS1zdGFtcC1mb3JtYXRzKSkKLQkJICAgIChjb25jYXQgIjwiIChvcmctcmVh ZC1kYXRlCi0JCQkJIG5pbCBuaWwgbmlsIG5pbCBkLXRpbWUgZC1ob3VyKSAiPiIpKSkKKyAgICAo c2V0cSB0aW1lc3RyIChjb25jYXQgIjwiCisgICAgICAgICAgICAgICAgICAgICAgICAgIChpZiB0 b2RheQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGZvcm1hdC10aW1lLXN0cmluZwor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzdHJpbmctcmVwbGFjZSAiPCIgIiIKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoc3RyaW5nLXJlcGxhY2UgIj4iICIiIChjZHIg b3JnLXRpbWUtc3RhbXAtZm9ybWF0cykpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAo b3JnLXJlYWQtZGF0ZSBuaWwgbmlsIG5pbCBuaWwgZC10aW1lIGQtaG91cikpCisgICAgICAgICAg ICAgICAgICAgICAgICAgICI+IikpCiAgICAgOzsgbWF5YmUgdHJhbnNmb3JtIHRvIGluYWN0aXZl IHRpbWVzdGFtcAogICAgIChpZiBvcmctZXhwaXJ5LWluYWN0aXZlLXRpbWVzdGFtcHMKIAkoc2V0 cSB0aW1lc3RyIChjb25jYXQgIlsiIChzdWJzdHJpbmcgdGltZXN0ciAxIC0xKSAiXSIpKSkKLS0g CjIuMzcuNAoK --0000000000002385f905ef7f8f49--