emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: Bernt Hansen <bernt@norang.ca>
Cc: Carsten Dominik <carsten@orgmode.org>, emacs-orgmode@gnu.org
Subject: Re: Agenda clock reporting
Date: Sun, 3 Jan 2010 16:44:38 +0100	[thread overview]
Message-ID: <BCA43657-BC06-4721-B877-C7D12FF19835@gmail.com> (raw)
In-Reply-To: <87aawvi4fx.fsf@gollum.intra.norang.ca>


On Jan 3, 2010, at 4:38 PM, Bernt Hansen wrote:

> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> On Jan 3, 2010, at 3:22 PM, Bernt Hansen wrote:
>>
>>> Carsten Dominik <carsten.dominik@gmail.com> writes:
>>>
>>>> I think the right place would be `org-clock-sum'.  Right now,
>>>> this looks only for complete clock lines.  You could modify the
>>>> regexp
>>>> to check for incomplete lines (first time stamp only) and then  
>>>> check
>>>> if the org-clock-marker points to the current line.  If yes, you
>>>> could
>>>> use the current time as the end time and proceed.
>>>>
>>>> Send me a patch if you get this to work, with a customization
>>>> variable
>>>> to turn this off.
>>>>
>>>> HTH
>>>
>>> Yes it does thanks.  I found the logic that uses the regexp for
>>> parsing
>>> the times and summing them in reverse up to the headline in
>>> org-clock-sum.  I haven't modified the regexp yet but was planning
>>> something similar to what you describe above.
>>>
>>>  - org-clock-sum
>>>  - Runs through headings in reverse order
>>>  - counts clock entries bottom up to headline
>>>  - adds a text property to the headline with total time
>>>  - need to find out if current heading is clocking
>>
>> Yes, the alternative approach would be to *not* modify the regexp,  
>> but
>> to
>> check if org-clock-hd-marker points to the current headline and then
>> add the time since the clock started (in `org-clock-start-time') to
>> the appropriate
>> field in the ltimes vector before extracting the total time.  So you
>> would do
>> this as the first thing when you find a headline, and the proceed
>> normally.
>>
>> Sounds simpler than modifying the regexp and would not cause any
>> problems
>> with other incomplete clock entries that may have been left behind  
>> and
>> never
>> properly resolved......
>
> That does sound simpler ... I'll give that a try.

In fact, you only need to add the time to t1, not to the ltimes  
vector.....

- Carsten

      reply	other threads:[~2010-01-03 15:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-22 13:03 Agenda clock reporting Bernt Hansen
2009-12-22 15:16 ` Clock logging -- possible to include seconds? Bill Powell
2009-12-22 17:11   ` Scot Becker
2009-12-26 11:14   ` Carsten Dominik
2009-12-26 12:40     ` Bernt Hansen
2010-01-03 13:24 ` Agenda clock reporting Carsten Dominik
2010-01-03 14:22   ` Bernt Hansen
2010-01-03 14:41     ` Carsten Dominik
2010-01-03 15:38       ` Bernt Hansen
2010-01-03 15:44         ` Carsten Dominik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BCA43657-BC06-4721-B877-C7D12FF19835@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=bernt@norang.ca \
    --cc=carsten@orgmode.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).