From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] org-clock-select-task bugfix (XEmacs incompatibility) Date: Thu, 3 Dec 2009 12:47:53 +0100 Message-ID: References: <87y6lmwj8o.fsf@gmail.com> <252E914A-E305-4841-B39E-470700D355F6@gmail.com> <87ws15blp6.fsf@gmail.com> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NGAAG-0002yS-Sx for emacs-orgmode@gnu.org; Thu, 03 Dec 2009 06:48:04 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NGAAC-0002wk-AL for emacs-orgmode@gnu.org; Thu, 03 Dec 2009 06:48:04 -0500 Received: from [199.232.76.173] (port=39966 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NGAAC-0002wf-2I for emacs-orgmode@gnu.org; Thu, 03 Dec 2009 06:48:00 -0500 Received: from pony.ic.uva.nl ([145.18.40.181]:54635) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NGAAB-0005fV-II for emacs-orgmode@gnu.org; Thu, 03 Dec 2009 06:47:59 -0500 In-Reply-To: <87ws15blp6.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Richard KLINDA Cc: emacs-orgmode@gnu.org Hi Richard, I ave fixed this in a different way. Please verify! - Carsten On Dec 2, 2009, at 1:32 PM, Richard KLINDA wrote: > Hello Carsten, this failed for me ever since, but as I haven't needed > the functionality I was just lazy to report it. Oh:) I see why my > patch > must be problematic, sorry about that. > > The problem is that, when pressed a number as a reply to the question, > this cond command (see below) always goes to the error clause, because > rpl gets the value of ?1 for example, but sel-list look like > ((49 . ...) > (50 . ...)) so the assoc can't find ?1. With my patch, the assoc > finds > it because rpl is converted to ASCII code, but now ?q and ?x clauses > don't work.:) > > (cond > ((eq rpl ?q) nil) > ((eq rpl ?x) nil) > ((assoc rpl sel-list) (cdr (assoc rpl sel-list))) > (t (error "Invalid task choice %c" rpl))) > > I hope you see what the problem is, I think it must be an XEmacs > issue. > >>>>>> Regarding 'Re: [Orgmode] [PATCH] org-clock-select-task bugfix >>>>>> (XEmacs incompatibility)'; Carsten Dominik adds: > >> Hi Richard, I don't see why this would be necessary? Under what >> circumstances does this fail? > >> - Carsten > >> On Dec 1, 2009, at 9:07 PM, Richard KLINDA wrote: > >>> See attached simple patch. > >>> From 795d529d622f509f47c2bf17a0139fbe1659cc5f Mon Sep 17 00:00:00 >>> 2001 From: Richard Klinda Date: Tue, 1 Dec 2009 >>> 21:03:39 +0100 Subject: [PATCH] org-clock: org-clock-select-task >>> bugfix (XEmacs) > >>> --- lisp/org-clock.el | 4 ++++ 1 files changed, 4 insertions(+), 0 >>> deletions(-) > >>> diff --git a/lisp/org-clock.el b/lisp/org-clock.el index >>> 56dbab5..87017fc 100644 >>> --- a/lisp/org-clock.el >>> +++ b/lisp/org-clock.el >>> @@ -344,6 +344,10 @@ of a different task.") >>> (org-fit-window-to-buffer) (message (or prompt "Select task for >>> clocking:")) (setq rpl (read-char-exclusive)) >>> + (when (featurep 'xemacs) >>> + ;; in XEmacs read-char-exclusive returns character, instead >>> of >>> + ;; ascii value >>> + (setq rpl (char-octet rpl))) >>> (cond ((eq rpl ?q) nil) ((eq rpl ?x) nil) -- 1.6.2.1 > > >>> -- Richard _______________________________________________ >>> Emacs-orgmode mailing list Please use `Reply All' to send replies >>> to the list. Emacs-orgmode@gnu.org >>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode > >> - Carsten > > -- > Richard - Carsten