[PATCH] org-timestamp-change changes minutes in multiples of rounding time

[PATCH] org-timestamp-change changes minutes in multiples of rounding time

[Puneeth]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

Hi,

(org-timestamp-change n 'minutes) changes timestamp only by 5 minutes
(when my org-time-stamp-rounding-minutes is (0 5)) for any non-zero
value of n.

I think the timestamp should change by an integer multiple of 5. Do
you think this is correct behaviour?

A patch for the same has been attached.

Thanks,
Puneeth

[-- Attachment #2: org-timestamp-change.patch --]
[-- Type: application/octet-stream, Size: 589 bytes --]

diff --git a/lisp/org.el b/lisp/org.el
index e25194c..b4d2bd7 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -14981,7 +14981,8 @@ in the timestamp determines what will be changed."
       (setq time0 (org-parse-time-string ts))
       (when (and (eq org-ts-what 'minute)
 		 (eq current-prefix-arg nil))
-	(setq n (* dm (cond ((> n 0) 1) ((< n 0) -1) (t 0))))
+	(setq n (* dm (cond ((> n 0) (max (/ n dm) 1)) 
+			    ((< n 0) (min (/ n dm) -1)) (t 0))))
 	(when (not (= 0 (setq rem (% (nth 1 time0) dm))))
 	  (setcar (cdr time0) (+ (nth 1 time0)
 				 (if (> n 0) (- rem) (- dm rem))))))

[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: [PATCH] org-timestamp-change changes minutes in multiples of rounding time

[Puneeth]

On Tue, Jun 22, 2010 at 4:40 PM, Puneeth <punchagan@gmail.com> wrote:
[..]
> A patch for the same has been attached.

Sorry hadn't looked at this piece of documentation in the manual[1]
          (/ -17 6)
               ⇒ -2   (could in theory be −3 on some machines)

The patch could be modified to make it consistent.

[1] http://www.gnu.org/s/emacs/manual/html_node/elisp/Arithmetic-Operations.html

-- 
Puneeth

Re: [PATCH] org-timestamp-change changes minutes in multiples of rounding time

[Carsten Dominik]

On Jun 22, 2010, at 1:10 PM, Puneeth wrote:

> Hi,
>
> (org-timestamp-change n 'minutes) changes timestamp only by 5 minutes
> (when my org-time-stamp-rounding-minutes is (0 5)) for any non-zero
> value of n.
>
> I think the timestamp should change by an integer multiple of 5. Do
> you think this is correct behaviour?

Hi Puneeth,

no, I do not think so.  The variable is called "-rounding", not "-step".

Cheers

- Carsten

Re: [PATCH] org-timestamp-change changes minutes in multiples of rounding time

[Puneeth]

Hi Carsten,

On Tue, Jun 22, 2010 at 7:03 PM, Carsten Dominik
<carsten.dominik@gmail.com> wrote:
>
> On Jun 22, 2010, at 1:10 PM, Puneeth wrote:
[..]
> no, I do not think so.  The variable is called "-rounding", not "-step".

Sorry for the unclear message. Let me explain.

I tried to use the function shown below (imitating a similar function
by Juan Pechier [1]). But this function only changes the time by
either +5 or -5 minutes for whatever value of "n". Should it not,
increase the time by a multiple of 5 mins?

8<----------------------------------------

(defun upminutes ( n )
  "update all timestamps n minutes"
  (interactive "nAdd minutes: ")
  (save-excursion
    (goto-char (point-min))
     (while (re-search-forward "[[<]" nil t)
       (when (org-at-timestamp-p t)
         (org-timestamp-change n 'minute)
         ))))

8<----------------------------------------

Thanks,
Puneeth

[1] http://lists.gnu.org/archive/html/emacs-orgmode/2010-06/msg00229.html

Re: [PATCH] org-timestamp-change changes minutes in multiples of rounding time

[Carsten Dominik]

Hi Puneeth,

I have now understood, and changed the behavior so that
your function should work correctly.

Note that the rounding only works now if you use S-up and S-down
on the minutes.  If you give your function of 13 minutes, it will  
change all time stamps by 13 minutes, not a rounded number.

HTH

- Carsten


On Jun 22, 2010, at 3:48 PM, Puneeth wrote:

> Hi Carsten,
>
> On Tue, Jun 22, 2010 at 7:03 PM, Carsten Dominik
> <carsten.dominik@gmail.com> wrote:
>>
>> On Jun 22, 2010, at 1:10 PM, Puneeth wrote:
> [..]
>> no, I do not think so.  The variable is called "-rounding", not "- 
>> step".
>
> Sorry for the unclear message. Let me explain.
>
> I tried to use the function shown below (imitating a similar function
> by Juan Pechier [1]). But this function only changes the time by
> either +5 or -5 minutes for whatever value of "n". Should it not,
> increase the time by a multiple of 5 mins?
>
> 8<----------------------------------------
>
> (defun upminutes ( n )
>  "update all timestamps n minutes"
>  (interactive "nAdd minutes: ")
>  (save-excursion
>    (goto-char (point-min))
>     (while (re-search-forward "[[<]" nil t)
>       (when (org-at-timestamp-p t)
>         (org-timestamp-change n 'minute)
>         ))))
>
> 8<----------------------------------------
>
> Thanks,
> Puneeth
>
> [1] http://lists.gnu.org/archive/html/emacs-orgmode/2010-06/msg00229.html

- Carsten

Re: [PATCH] org-timestamp-change changes minutes in multiples of rounding time

[Puneeth]

Hi Carsten,

On Tue, Jun 22, 2010 at 7:47 PM, Carsten Dominik
<carsten.dominik@gmail.com> wrote:
[..]
> Note that the rounding only works now if you use S-up and S-down
> on the minutes.  If you give your function of 13 minutes, it will change all
> time stamps by 13 minutes, not a rounded number.
>
> HTH

Thanks!

--
Puneeth