From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Use integer syntax for the MODE argument to #'set-file-modes Date: Mon, 23 Aug 2010 12:08:08 +0200 Message-ID: References: <19568.24176.636168.145227@parhasard.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Return-path: Received: from [140.186.70.92] (port=34681 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OnTwq-0004ue-4g for emacs-orgmode@gnu.org; Mon, 23 Aug 2010 06:08:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OnTwo-0002GO-EY for emacs-orgmode@gnu.org; Mon, 23 Aug 2010 06:08:11 -0400 Received: from mail-iw0-f169.google.com ([209.85.214.169]:64778) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnTwo-0002GF-BD for emacs-orgmode@gnu.org; Mon, 23 Aug 2010 06:08:10 -0400 Received: by iwn33 with SMTP id 33so4618151iwn.0 for ; Mon, 23 Aug 2010 03:08:09 -0700 (PDT) In-Reply-To: <19568.24176.636168.145227@parhasard.net> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Aidan Kehoe Cc: emacs-orgmode@gnu.org Applied, thanks. - Carsten On Sun, Aug 22, 2010 at 1:17 AM, Aidan Kehoe wrote: > > Hello! > > We need this change to get org-mode compiling with recent XEmacs 21.5. On > previous 21.5 and current 21.4, the problem manifests itself at runtime, = not > compile time, like so: > > =A0(set-file-modes "/tmp/aidan/foo.el" ?\755) > =A0=3D> Wrong type argument: integerp, ?=ED > > One old reason to go for the ?\755 syntax instead of the #o755 syntax und= er > GNU Emacs was to be that older versions of GNU Emacs didn=92t support #o7= 55, > but, to my knowledge, every released GNU Emacs since March 2000 has > supported the latter syntax. > > Best, > > Aidan Kehoe, the XEmacs project. > > ChangeLog addition: > > 2010-08-21 =A0Aidan Kehoe =A0 > > =A0 =A0 =A0 =A0* ob-tangle.el (org-babel-tangle): Change the MODE argumen= t to > =A0 =A0 =A0 =A0#'set-file-modes to use integer, not character syntax, avo= iding > =A0 =A0 =A0 =A0compile problems with recent XEmacs. > > diff --git a/lisp/ob-tangle.el b/lisp/ob-tangle.el > index a7ba072..adc054a 100644 > --- a/lisp/ob-tangle.el > +++ b/lisp/ob-tangle.el > @@ -187,7 +187,7 @@ exported source code blocks by language." > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(insert content) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(write-region nil nil = file-name)))) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0;; if files contain she-bangs, the= n make the executable > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (when she-bang (set-file-modes file= -name ?\755)) > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (when she-bang (set-file-modes file= -name #o755)) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ;; update counter > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (setq block-counter (+ 1 block-co= unter)) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (add-to-list 'path-collector file= -name))))) > > > -- > =93Apart from the nine-banded armadillo, man is the only natural host of > Mycobacterium leprae, although it can be grown in the footpads of mice.= =94 > =A0-- Kumar & Clark, Clinical Medicine, summarising improbable leprosy re= search > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode >