emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ruijie Yu via "General discussions about Org-mode." <emacs-orgmode@gnu.org>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Gustavo Barros <gusbrs.2016@gmail.com>,
	emacs-orgmode@gnu.org, Bastien Guerry <bzg@gnu.org>
Subject: Re: [BUG] org-latex-packages-alist type specification [9.6.3 (release_9.6.3-2-gf2949d @ /usr/local/share/emacs/29.0.90/lisp/org/)]
Date: Thu, 13 Apr 2023 19:30:43 +0800	[thread overview]
Message-ID: <A0F0BE34-70CB-4AF1-8917-518D6E380DC5@netyu.xyz> (raw)
In-Reply-To: <87wn2gdnvk.fsf@localhost>


> On Apr 13, 2023, at 19:23, Ihor Radchenko <yantar92@posteo.net> wrote:
> 
> Ruijie Yu via "General discussions about Org-mode."
> <emacs-orgmode@gnu.org> writes:
> 
>> From 0be8702357ddf699c5ff1814a5fa57a6443b10de Mon Sep 17 00:00:00 2001
>> From: Ruijie Yu <ruijie@netyu.xyz>
>> Date: Thu, 13 Apr 2023 13:14:36 +0800
>> Subject: [PATCH] * lisp/org.el org-latex-packages-alist: fixed type definition
> 
> Thanks!
> May I know if you got any reply about your FSF assignment?

Yes, it is now complete.  I presume you want to check with Bastien, so I took the liberty of CC’ing him myself. 

>> ---
>> lisp/org.el | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>> diff --git a/lisp/org.el b/lisp/org.el
>> index 26d2a8610..5bad16fd9 100644
>> --- a/lisp/org.el
>> +++ b/lisp/org.el
>> @@ -3490,7 +3490,8 @@ Make sure that you only list packages here which:
>>      (list :tag "options/package pair"
>>        (string :tag "options")
>>        (string :tag "package")
>> -         (boolean :tag "Snippet"))
>> +         (boolean :tag "snippet")
>> +                 (repeat :tag "compilers" string))
> 
> Compiler list may also be nil.

This should be covered by the repeat case?  Unless you want to be explicit about this, in which case you can wrap it in a choice, whose first choice being (const :tag “description” nil), and the second choice being the repeat case.  Can’t change the patch myself because I don’t have access to a computer ATM. 

> -- 
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>

--
Best,


RY


  reply	other threads:[~2023-04-13 11:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12 19:40 [BUG] org-latex-packages-alist type specification [9.6.3 (release_9.6.3-2-gf2949d @ /usr/local/share/emacs/29.0.90/lisp/org/)] Gustavo Barros
2023-04-13  5:12 ` Ruijie Yu via General discussions about Org-mode.
2023-04-13 11:26   ` Ihor Radchenko
2023-04-13 11:30     ` Ruijie Yu via General discussions about Org-mode. [this message]
2023-04-19  9:48       ` Bastien Guerry
2023-04-22 13:29         ` Ihor Radchenko
2023-04-20  8:53       ` Ihor Radchenko
2023-04-20  9:28         ` Ruijie Yu via General discussions about Org-mode.
2023-04-22 13:30           ` Ihor Radchenko
2023-04-22 13:35             ` Gustavo Barros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A0F0BE34-70CB-4AF1-8917-518D6E380DC5@netyu.xyz \
    --to=emacs-orgmode@gnu.org \
    --cc=bzg@gnu.org \
    --cc=gusbrs.2016@gmail.com \
    --cc=ruijie@netyu.xyz \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).