From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id kJiDCN7RI2ZdOwEAqHPOHw:P1 (envelope-from ) for ; Sat, 20 Apr 2024 16:31:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id kJiDCN7RI2ZdOwEAqHPOHw (envelope-from ) for ; Sat, 20 Apr 2024 16:31:58 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713623518; a=rsa-sha256; cv=none; b=CaScXC3mHr6RHpCqgLEjiDcrzvPfvtX4ATLClWpaYW5pDltRnskOAhOuuiqkK1OVilFwyN RZlqdlhTjAk581YI6LKUuCtBCq27Vr7iG6/YNDtxXF647V+t116Eq1+wOG6KGiWDqUSQii itmXwQUnPUACZ7dNgUdAe+kfWhsR+Btn9VTkt2jCQi0AbIM8xHoPoEJLFzzMHuuBlO0H1I dGDdqSvv/ndadDo93cGpNO/5ubKfaB0pkRCIutfE0jPYdLVvHZDYTRyAAMGrImhld4WUtN GoxD4mrhQULJX8KkubBBW2jFTiH8XpVa87tT62YOETXMo/W/rrFtlpWNUbUZXQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713623518; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=ffxVpJOx2ZirAjHkqZagU+RB3IUWxE/6B+zsYGSRb4U=; b=pVb9rvD2h/39W4l+5o32T9QkcNrthLcQk9Wgb2acejTbPvkqTyJ7g5MXK0t4IukEQV0caI wj5s6nGi/0b61mUsS4U0Zq0UR0ZkuEebhk9j68m1wEWXDESk/X7YdkyEo7Fo+xDJRjBfjM tn4ChXaGq4+VBLErwAdBKvWEGrSX1NCj7LZHl+P9LQ+6o+yDMHXUeUBVz0d3nuHuGeGhuH qwgdl17Gt9Dpi8JAcZEOFYCLPFhC+WpEobZ/6DpMyvF1VRDy+zJTPAU2RTMpa5Tuwu3Vqq p5o9SjgcM30y6f77bwsZhrug+8XRzHAmwdwXG8uyiGYLRjVv1zbdMXjLCyQ7DA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DA92AE335 for ; Sat, 20 Apr 2024 16:31:57 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ryBk1-0000rZ-H5; Sat, 20 Apr 2024 10:30:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ryBjz-0000rO-3C for emacs-orgmode@gnu.org; Sat, 20 Apr 2024 10:30:55 -0400 Received: from smtprelay02.ispgateway.de ([80.67.18.44]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ryBjw-0005Y2-Hb for emacs-orgmode@gnu.org; Sat, 20 Apr 2024 10:30:53 -0400 Received: from [185.17.206.107] (helo=condition-alpha.com) by smtprelay02.ispgateway.de with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1ryBjt-0000000025S-16Qg; Sat, 20 Apr 2024 16:30:49 +0200 Message-Id: <98f04a910f31ff9ab38e2ddf9e7f2f5c@condition-alpha.com> From: Alexander Adolf To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM In-Reply-To: <87zftp6zz3.fsf@localhost> References: <486d2b818b62c71b3f307305c06c4318@condition-alpha.com> <871q7cypxl.fsf@localhost> <00aa9bf72dc93f6554bdd236fdfba192@condition-alpha.com> <87y19hbb05.fsf@localhost> <8b72386d118136210f27b553f0a13066@condition-alpha.com> <87cyqtyzgt.fsf@localhost> <91dfeb0fed1a1fe0564e5eb9b95a409d@condition-alpha.com> <87a5lpeiey.fsf@localhost> <87zftp6zz3.fsf@localhost> Date: Sat, 20 Apr 2024 16:30:48 +0200 MIME-Version: 1.0 Content-Type: text/plain X-Df-Sender: YWxleGFuZGVyLmFkb2xmQGNvbmRpdGlvbi1hbHBoYS5jb20= Received-SPF: pass client-ip=80.67.18.44; envelope-from=alexander.adolf@condition-alpha.com; helo=smtprelay02.ispgateway.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -3.46 X-Migadu-Queue-Id: DA92AE335 X-Migadu-Spam-Score: -3.46 X-Migadu-Scanner: mx10.migadu.com X-TUID: PDfPd0L77YxF Many thanks for your swift response! Ihor Radchenko writes: > [...] > When suggesting #+vindex, I was referring to > org-columns-dblock-formatter variable. > [...] > #+cindex: @samp{formatter}, dynamic block parameter I see; thanks for explaining. I've added both: ---------------------------- Begin Quote ----------------------------- - =:formatter= :: #+cindex: @samp{formatter}, dynamic block parameter #+vindex: org-columns-dblock-formatter A function to format column view data and insert it into the buffer. See the option ~org-columns-dblock-formatter~. ----------------------------- End Quote ------------------------------ > [...] > I see how. It is because CELL-CONTENT is not the original heading. It is > the heading name processed with `org-columns--clean-item'. > > `org-column--clean-item' removes statistics cookies among other things. > It actually removes more, leading to some edge cases in your patch: > > ** TODO Foo > > ** TODO src_elisp{"Hello"} world > > > #+begin: columnview :id global :link t > | <25> | | <3> | | > | ITEM | TODO | PRIORITY | TAGS | > |-------+------+----------+------| > | [[file:/tmp/test.org::*Foo][Foo]] | TODO | B | | > | [[file:/tmp/test.org::*src_elisp{"Hello"} world][world]] | TODO | B | | > #+end: > > Note how inline src block is stripped from the link description. Ah, `org-column--clean-item'; well spotted! Two observations: 1) As is now, I'm generating the links in the data collection function `org-columns--capture-view'. As `org-column--clean-item' is called from code that runs after the data collection, `org-column--clean-item' was probably never designed to be able to handle strings containing links. That it still did sort of "the right thing" seems more luck than anything else? 2) Considering what happens when I do `org-store-link' and `org-insert-link', it would seem more advisable to: a) move the link generation to the new formatting function (re-removing it from `org-columns--capture-view'); b) pass the "cleaned" string to `org-link-make-string' as both, the link and the description parameter. > We should probably also change org-clock to use > `org-columns--clean-item'. > [...] As a separate patch, or as a third commit to the patch we are discussing now? Many thanks and looking forward to your thoughts, --alexander