From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: BUG - Attachment directories with newlines Date: Fri, 7 Nov 2008 06:49:57 +0100 Message-ID: <96428E6F-2245-465A-81F9-48E892E7697F@uva.nl> References: <87r65q9ee3.fsf@gollum.intra.norang.ca> <007C04D3-DD4B-4CDD-AE75-D6733A4EDCB6@uva.nl> <87od0tpyfx.fsf@gollum.intra.norang.ca> <87k5bhpxdx.fsf@gollum.intra.norang.ca> <87fxm5px6m.fsf@gollum.intra.norang.ca> <878wrwjmj6.fsf@gollum.intra.norang.ca> <9937C40F-3683-4376-B7C5-7F59A97EE062@uva.nl> Mime-Version: 1.0 (Apple Message framework v929.2) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KyKEN-00080E-PI for emacs-orgmode@gnu.org; Fri, 07 Nov 2008 00:50:03 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KyKEL-0007zq-Vb for emacs-orgmode@gnu.org; Fri, 07 Nov 2008 00:50:03 -0500 Received: from [199.232.76.173] (port=49969 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KyKEL-0007zk-L0 for emacs-orgmode@gnu.org; Fri, 07 Nov 2008 00:50:01 -0500 Received: from nf-out-0910.google.com ([64.233.182.187]:45484) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KyKEK-0006yi-TN for emacs-orgmode@gnu.org; Fri, 07 Nov 2008 00:50:01 -0500 Received: by nf-out-0910.google.com with SMTP id c7so608170nfi.26 for ; Thu, 06 Nov 2008 21:50:00 -0800 (PST) In-Reply-To: <9937C40F-3683-4376-B7C5-7F59A97EE062@uva.nl> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: Bernt Hansen , emacs-orgmode@gnu.org On Nov 7, 2008, at 6:45 AM, Carsten Dominik wrote: > This is very strange. I cannot reproduce this. When I evaluate in > your example > >> | (org-id-get (point)) >> | (org-entry-get (point) "ID") > > I get in both cases just the ID, no newline with it. Also, new > newlines *no* new newlines are created...... > are created for me after the attachment property. Can please more > people try Bernt's example? > > Thanks > > - Carsten > > On Nov 7, 2008, at 3:30 AM, Bernt Hansen wrote: > >> Okay It's back... :) >> >> I'm creating attachments using C-c C-a a using the latest version of >> org-mode in git. >> >> The first time the attachment is created correctly. This creates the >> property ID. The second attachment is the one that fails. It reads >> the property from the entry and includes the newline at the end. >> >> This then creates the directory with the newline and attachments 2 >> and >> later end up in the directory with a trailing newline. >> >> Only attachments in the entry with a trailing newline are returned >> for >> me using C-c C-a o >> >> In the following entry >> >> ,---- >> | ** TODO Bug report for attachments :ATTACH: >> | :CLOCK: >> | CLOCK: [2008-11-06 Thu 20:36] >> | CLOCK: [2008-11-05 Wed 18:28]--[2008-11-05 Wed 19:56] => 1:28 >> | :END: >> | :PROPERTIES: >> | :Attachments: r1.xml r2.xml outputXML.asp r6.xml >> | :ID: 202aa5c-111e-46ec-8461-144d4f492a41 >> | :END: >> | [2008-11-05 Wed] >> | (org-id-get (point)) >> | (org-entry-get (point) "ID") >> | >> `---- >> >> (org-id-get (point)) and >> (org-entry-get (point) "ID") both return >> >> "202aa5c-111e-46ec-8461-144d4f492a41 >> " >> >> Also when each new attachment is added a newline is added between >> :Attachments: and :ID: (I deleted them from the example above) >> >> After C-c C-a a two more times attaching r3.xml and r4.xml I get >> >> ,---- >> | ** TODO Bug report for attachments :ATTACH: >> | :CLOCK: >> | CLOCK: [2008-11-06 Thu 20:36] >> | CLOCK: [2008-11-05 Wed 18:28]--[2008-11-05 Wed 19:56] => 1:28 >> | :END: >> | :PROPERTIES: >> | :Attachments: r4.xml r3.xml r1.xml r2.xml outputXML.asp r6.xml >> | >> | >> | :ID: 202aa5c-111e-46ec-8461-144d4f492a41 >> | :END: >> | [2008-11-05 Wed] >> | (org-id-get (point)) >> | (org-entry-get (point) "ID") >> | >> `---- >> >> I'm not sure if org-entry-get or org-id-get should strip the newline >> from the returned value so I didn't supply a patch for this. >> >> Regards, >> Bernt >> >> >> Carsten Dominik writes: >> >>> Isn't that nice that there are bugs that go away by themselves? >>> >>> Thanks for investigating this. >>> >>> - Carsten >>> >>> On Nov 6, 2008, at 12:31 AM, Bernt Hansen wrote: >>> >>>> Sorry about all the replies to my own mail. >>>> >>>> I checked out the master branch on Oct 24 and it breaks right away. >>>> >>>> git checkout master@{oct.24} >>>> >>>> and running uncompiled sources creates attachment directories >>>> with a >>>> newline at the end. It's been fixed since then. >>>> >>>> I'll go and move all my attachments which are in directories with >>>> embedded newlines to the correct location and all should be well >>>> for >>>> me >>>> at that point. >>>> >>>> Other users might want to check if they have attachments in broken >>>> directories too. >>>> >>>> -Bernt >>>> >>>> Bernt Hansen writes: >>>> >>>>> Attachments work fine today. They also worked fine on Oct >>>>> 15th. But >>>>> all of the attachments I made on Oct 24 have a newline embedded as >>>>> the >>>>> last character of the directory name. >>>>> >>>>> I'll try to see if I can duplicate this error. Your time is >>>>> better >>>>> spent on other things I think. >>>>> >>>>> I'll let you know what I find out. >>>>> >>>>> Regards, >>>>> Bernt >>>>> >>>>> Bernt Hansen writes: >>>>> >>>>>> I've only every created files in my data directory with the C-c >>>>>> a a >>>>>> command. >>>>>> >>>>>> I'll try to get more useful information about this tonight >>>>>> >>>>>> -Bernt >>>>>> >>>>>> >>>>>> Carsten Dominik writes: >>>>>> >>>>>>> Hi Bernt, >>>>>>> >>>>>>> it would be useful to know if the files in the directory with >>>>>>> the >>>>>>> \n >>>>>>> where attached there or created there by a different method than >>>>>>> the >>>>>>> files in the directory without. >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> - Carsten >>>>>>> >>>>>>> On Nov 5, 2008, at 8:11 PM, Bernt Hansen wrote: >>>>>>> >>>>>>>> Hi Carsten, >>>>>>>> >>>>>>>> I've run into a problem with attachments. I tried opening an >>>>>>>> attachment >>>>>>>> for one of my tasks and it can't find it. >>>>>>>> >>>>>>>> As it turns out the attachment directory has an embedded >>>>>>>> newline >>>>>>>> in it >>>>>>>> like this: >>>>>>>> >>>>>>>> ,---- >>>>>>>> | bernt@gollum:~/git/org/data/c6$ find . -type d -ls >>>>>>>> | 5581153 4 drwxr-xr-x 4 bernt bernt 4096 Oct 24 >>>>>>>> 15:59 . >>>>>>>> | 5581154 4 drwxr-xr-x 2 bernt bernt 4096 Oct 24 >>>>>>>> 15:59 ./47cbe-2158-46ce-bd93-8faf5ca95725 >>>>>>>> | 5581156 4 drwxr-xr-x 2 bernt bernt 4096 Oct 24 >>>>>>>> 17:05 ./47cbe-2158-46ce-bd93-8faf5ca95725\n >>>>>>>> | bernt@gollum:~/git/org/data/c6$ >>>>>>>> `---- >>>>>>>> >>>>>>>> and any files that were stored in the directory with the >>>>>>>> newline >>>>>>>> can't >>>>>>>> be found. >>>>>>>> >>>>>>>> The files are still there - just not retrievable from the org >>>>>>>> attachment >>>>>>>> system. >>>>>>>> >>>>>>>> I haven't bisected to find out where the problem was >>>>>>>> introduced. >>>>>>>> >>>>>>>> -Bernt >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> Emacs-orgmode mailing list >>>>>>>> Remember: use `Reply All' to send replies to the list. >>>>>>>> Emacs-orgmode@gnu.org >>>>>>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode >>> >>> >>> >>> _______________________________________________ >>> Emacs-orgmode mailing list >>> Remember: use `Reply All' to send replies to the list. >>> Emacs-orgmode@gnu.org >>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode >