From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Lundin Subject: [PATCH] Removed unecessary invocations of org-agenda-show. Date: Mon, 13 Sep 2010 12:48:27 -0400 Message-ID: <87zkvly3m3.fsf@archdesk.localdomain> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from [140.186.70.92] (port=50207 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OvCUh-0006OA-Tr for emacs-orgmode@gnu.org; Mon, 13 Sep 2010 13:07:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OvCUg-0004wU-El for emacs-orgmode@gnu.org; Mon, 13 Sep 2010 13:07:03 -0400 Received: from out2.smtp.messagingengine.com ([66.111.4.26]:58380) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OvCUg-0004wO-7L for emacs-orgmode@gnu.org; Mon, 13 Sep 2010 13:07:02 -0400 Received: from archdesk.localdomain (67-197-63-212.rh2.dyn.cm.comporium.net [67.197.63.212]) by mail.messagingengine.com (Postfix) with ESMTPSA id 6E27E5E3D00 for ; Mon, 13 Sep 2010 13:07:01 -0400 (EDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Org Mode lisp/org-agenda.el (org-agenda-set-tags): Remove org-agenda-show to prevent disrupting windows and changing point in original buffer. (org-agenda-set-property): Same (org-agenda-set-effort): Same (org-agenda-toggle-archive-tag): Same When setting a tag in the agenda, org-mode displays the corresponding entry in the original org buffer by calling org-agenda-show. This has the unwelcome side-effect of disrupting the current window arrangement and changing the position of the point in the original buffer. This behavior is inconsistent with the that of org-agenda-todo, which makes all its changes "silently." Here is the offending line (6799) in org-agenda-set-tags: --8<---------------cut here---------------start------------->8--- (org-agenda-show) ;;; FIXME This is a stupid hack and should not be needed --8<---------------cut here---------------end--------------->8--- The same line occurs in org-agenda-set-property, org-agenda-set-effort, and org-agenda-toggle-archive tag. --- lisp/org-agenda.el | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 32c65db..784ba6a 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -6796,7 +6796,6 @@ the same tree node, and the headline of the tree node in the Org-mode file." (org-agenda-check-no-diary) (if (and (org-region-active-p) (interactive-p)) (call-interactively 'org-change-tag-in-region) - (org-agenda-show) ;;; FIXME This is a stupid hack and should not be needed (let* ((hdmarker (or (org-get-at-bol 'org-hd-marker) (org-agenda-error))) (buffer (marker-buffer hdmarker)) @@ -6825,7 +6824,6 @@ the same tree node, and the headline of the tree node in the Org-mode file." "Set a property for the current headline." (interactive) (org-agenda-check-no-diary) - (org-agenda-show) ;;; FIXME This is a stupid hack and should not be needed (let* ((hdmarker (or (org-get-at-bol 'org-hd-marker) (org-agenda-error))) (buffer (marker-buffer hdmarker)) @@ -6848,7 +6846,6 @@ the same tree node, and the headline of the tree node in the Org-mode file." "Set the effort property for the current headline." (interactive) (org-agenda-check-no-diary) - (org-agenda-show) ;;; FIXME This is a stupid hack and should not be needed (let* ((hdmarker (or (org-get-at-bol 'org-hd-marker) (org-agenda-error))) (buffer (marker-buffer hdmarker)) @@ -6872,7 +6869,6 @@ the same tree node, and the headline of the tree node in the Org-mode file." "Toggle the archive tag for the current entry." (interactive) (org-agenda-check-no-diary) - (org-agenda-show) ;;; FIXME This is a stupid hack and should not be needed (let* ((hdmarker (or (org-get-at-bol 'org-hd-marker) (org-agenda-error))) (buffer (marker-buffer hdmarker)) -- 1.7.2.3