emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Marcin Borkowski <mbork@mbork.pl>
Cc: Org-Mode mailing list <emacs-orgmode@gnu.org>
Subject: Re: How about lifting the limit of 35 tasks in org-clock-history?
Date: Thu, 06 Sep 2018 16:18:08 +0200	[thread overview]
Message-ID: <87zhwuu2u7.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87zhx0ymvc.fsf@mbork.pl> (Marcin Borkowski's message of "Sun, 02 Sep 2018 16:50:31 +0200")

Hello,

Marcin Borkowski <mbork@mbork.pl> writes:

> I decided to put a warning about this in the docstring in my patch.  My
> assumption was that this is enough.  If a user wants to change the
> default, he will most probably see the docstring and will have to
> actively ignore the warning.

I don't think this is enough. As you put it, it instills doubt without
explaining anything. Why 35? Why "may not work"? What "may not work"?

> I do not use the vanilla Org way of selecting tasks to clock from
> history - I use org-mru-clock, for which the restriction doesn't make
> sense.  So we have something else to use,

I meant "have something else to use out of the box". I.e., not with an
external library.

I agree with the idea of removing this limitation, but I'm not convinced
your patch is ideal yet.

Regards,

-- 
Nicolas Goaziou

  parent reply	other threads:[~2018-09-06 14:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-31  5:56 How about lifting the limit of 35 tasks in org-clock-history? Marcin Borkowski
2018-09-02 12:45 ` Nicolas Goaziou
2018-09-02 14:50   ` Marcin Borkowski
2018-09-06 14:11     ` Marcin Borkowski
2018-09-06 14:18     ` Nicolas Goaziou [this message]
2018-09-08 15:28       ` Marcin Borkowski
2018-10-02  6:12       ` Marcin Borkowski
2018-10-03 10:51         ` Nicolas Goaziou
2018-10-03 12:19           ` Marcin Borkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhwuu2u7.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=mbork@mbork.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).