From: Bastien <bzg@gnu.org>
To: "Sébastien Miquel" <sebastien.miquel@posteo.eu>
Cc: Eric S Fraga <e.fraga@ucl.ac.uk>,
emacs-orgmode@gnu.org, Timothy <tecosaur@gmail.com>
Subject: Re: [PATCH] tangling seems to have broken today
Date: Thu, 06 May 2021 13:19:27 +0200 [thread overview]
Message-ID: <87zgx8qfcw.fsf@gnu.org> (raw)
In-Reply-To: <af32e9a3-5158-1cc8-856b-1e6bc33f6928@posteo.eu> ("Sébastien Miquel"'s message of "Wed, 5 May 2021 16:22:16 +0000")
Hi Sébastien,
Sébastien Miquel <sebastien.miquel@posteo.eu> writes:
> The issue is that currently tangling a single block by calling
> `org-babel-tangle` with a prefix argument fails. This is unrelated to
> the earlier thread today, but was introduced by my original commit
> a2cb9b853d.
>
> Unfortunately, fixing it requires some refactorisation to avoid code
> duplication. To keep the patch as simple as possible, I have
> introduced a new helper function, I hope this is okay.
>
> I have tested the attached patch with the uses cases shown so far, as
> well as my own and the org test suite.
I think this should be applied to the maint branch, right? In this
case, the patch does not apply. Can you check and repropose a patch
against maint? Or just let me know if I'm mistaken.
Thanks,
--
Bastien
next prev parent reply other threads:[~2021-05-06 11:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 13:38 tangling seems to have broken today Eric S Fraga
2021-05-05 13:41 ` Timothy
2021-05-05 13:45 ` Bastien
2021-05-05 16:22 ` [PATCH] " Sébastien Miquel
2021-05-06 11:14 ` Bastien
2021-05-06 11:35 ` Sébastien Miquel
2021-05-06 11:38 ` Bastien
2021-05-06 11:19 ` Bastien [this message]
2021-05-05 13:54 ` Sébastien Miquel
2021-05-05 14:08 ` Eric S Fraga
2021-05-05 14:17 ` Sébastien Miquel
2021-05-05 14:20 ` Eric S Fraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgx8qfcw.fsf@gnu.org \
--to=bzg@gnu.org \
--cc=e.fraga@ucl.ac.uk \
--cc=emacs-orgmode@gnu.org \
--cc=sebastien.miquel@posteo.eu \
--cc=tecosaur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).