From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cPXIF+6TL2HQxAAAgWs5BA (envelope-from ) for ; Wed, 01 Sep 2021 16:53:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id oPAkE+6TL2F7GwAAB5/wlQ (envelope-from ) for ; Wed, 01 Sep 2021 14:53:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BAFF6F6FA for ; Wed, 1 Sep 2021 16:53:33 +0200 (CEST) Received: from localhost ([::1]:45290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLRcK-00066m-QV for larch@yhetil.org; Wed, 01 Sep 2021 10:53:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLRSB-00032Y-Ry for emacs-orgmode@gnu.org; Wed, 01 Sep 2021 10:43:03 -0400 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:39919) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLRS8-0001od-Mr for emacs-orgmode@gnu.org; Wed, 01 Sep 2021 10:43:03 -0400 Received: by mail-pl1-x629.google.com with SMTP id m17so1622561plc.6 for ; Wed, 01 Sep 2021 07:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:references:user-agent:in-reply-to :message-id:mime-version; bh=kLUkhjkhymzMrGGymlaBwTeLgF70IFpTb/EhU0w0rbk=; b=m6b7sODpQVFbfiJ7ahP43WIGkER0MVEH+AARR/hRs8Qx8izwt+ukrf1beE9rlvDt8A ZCC5qMxpu+6tlc+AW1jj862em7QQYxhhHbqCsl7DA5zfP0Jvq0xysmvTbZk5OPXK8Yo9 iqCGRrkfX7p/EuMnpybrrvYri4rbagHqSPuHEv/1dGFr9n63mZVOcJYTttTSqez67pMd jwYifYFpkxPy7VjhmORK5l4Vgavap1Xa+f38HDhOYvlEYz5hTHYluZvtrxvo+THYGmia L5rD772KnQlgrhziAevhbtpSE+vpAzdwc0sHkpq+xGuHNMDzJwstdtpzb8sW8KDSDCHl Lsfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:references:user-agent :in-reply-to:message-id:mime-version; bh=kLUkhjkhymzMrGGymlaBwTeLgF70IFpTb/EhU0w0rbk=; b=GDNUN5P58MsfyDixL0YTRqMYekwTJGhlO7U/5ZJFWan95bSt6BvgOZsWrEQk7GttuH LyJXUcTgmw4MZIIDHwkWzU1fPksEW7p2FqnZCXD4yvCtJgT5B6D3zjvGsvmUFn9VLn5d bUdXu0oVbhLpUAWrDLjOQm0Kbh8OseteFGeAN7NlvTpjd1wVjb6Ie7Pe2CBu0lKT8hPP m2qlM6/wQiubbYbatnDJTMRl40BW0DN7eN/WD4q9jMrztcVKHeVTRzLEkl6Pu63rAduV 54HiGyeWATKMztWdmL032otv6dC5vEIhcVMzhmeb1Amzzz3zSXIxkS0/eNri5MbWVHeC qEfw== X-Gm-Message-State: AOAM532BWxH40LGjOl8IFDaZvskW2xdDhsBN1QVCsW8T9O+ksTtHpgfQ XgRdYbd2vjluXqvtzzMKkiY= X-Google-Smtp-Source: ABdhPJzrPFPB8oqQTVPZhiAK+NuH6374jLieW4zdDFJYIduSI5Ft5HbnHPqUSK0JtAE+e6LYB7Nh5g== X-Received: by 2002:a17:902:6e02:b0:137:b47e:d779 with SMTP id u2-20020a1709026e0200b00137b47ed779mr10024975plk.50.1630507378560; Wed, 01 Sep 2021 07:42:58 -0700 (PDT) Received: from localhost (61-245-128-160.3df580.per.nbn.aussiebb.net. [61.245.128.160]) by smtp.gmail.com with ESMTPSA id v6sm237245pfv.83.2021.09.01.07.42.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Sep 2021 07:42:58 -0700 (PDT) From: Timothy To: Peder Stray Subject: Re: A small bug in org-file-url-p Date: Wed, 01 Sep 2021 22:40:59 +0800 References: User-agent: mu4e 1.6.5; emacs 28.0.50 In-reply-to: Message-ID: <87zgswmk5t.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=tecosaur@gmail.com; helo=mail-pl1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630508013; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=kLUkhjkhymzMrGGymlaBwTeLgF70IFpTb/EhU0w0rbk=; b=T8cUkEAwPKmex9Q6sdVzQQA5LQQgHjMV0bp8xxm3DCIxprww7T6u63WoUdBDbRJ+kID57T pjEVXZMp4XnzsVvy2bsa21P5oPcmoCIq0G3p3GMuK8QWSFOn+Fav62CFklKccaNH1C2N+n jhE3RzGT+6QXQmdtQjikEsjiINJtiusGNZiQBVp7GDG3IMoF825u14ty3lWYiQwU8bNHzK t2pD/+tu1k0nqtjuIOOpPQhngplFMj0c5rGu/2YSlMXjgqlf3uj3mxAlqXAXisuVhBYhBr G3/Wazz1mAzzp5MpUtfJVPNpapgxMi8j/JXPsSK0a02dX87/KqeMuBDjygsvMg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630508013; a=rsa-sha256; cv=none; b=azhhvgu+VPr4f6yDCiir7iI9O5U4zY9ZzPozkEqpnKqqXl5r7zY6hCnJmjY44+Yw3WcbTN ZhQ3iVaLIfb+uN6xj6nGTlgDHMAT7uzvCx5TCLAy8dTfv+B0buTTY8MSD365qFm+85Hv7k 8SWIw7nl7rwSbdpBYx5QwpKeJahIgiNCndGxw6vMrOtNGonrTr4i2MQIAKCTXX0NQMjU6J 9w/6nxczIGwnLaaqUIwz/EIrEwh3Y5ozmkBE2Z+N29yL/wIPIaGtI3eySCFKOuMagxU87j 1PyegPqgt2oewGFWuKmOgJU9Nw9QaE765tjKbbHoQqLn9h/pNr2+EFGhtrmzBA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=m6b7sODp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.61 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=m6b7sODp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: BAFF6F6FA X-Spam-Score: -1.61 X-Migadu-Scanner: scn1.migadu.com X-TUID: k2MQdAXV771I --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Peder, Thanks for reporting this bug =F0=9F=99=82, and explaining the issue well. = I=E2=80=99ve just pushed a fix in fbfcd79f8. All the best, Timothy --==-=-= Content-Type: text/html; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable

Hi Peder,

Thanks for reporting this bug =F0=9F=99=82, and explaining the issue well. = I=E2=80=99ve just pushed a fix in fbfcd79f8.

All the best,
Timothy

From: Peder Str= ay
Subject: A small bug in org-file-url-p
To: emacs-orgmode@gnu.org
Date: Wed, 01 Sep 2021 19:59:26 +0800

Hi

Just wanted to report a = small bug in org-file-url-p, regarding its use of ffap-url-regexp.

The documentation for ffap-url-regexp states:
R= egexp matching the beginning of a URI, for ffap.
If the value is nil, d= isable URL-matching features in ffap.

I have it s= et to nil in my setup, to disable url-matching, and this causes org-file-ur= l-p to pass on nil in (string-match-p ffap-url-regexp file), thus causing s= tring-match-p do die with an error.

Othe code in = ffap uses and to test the value of ffap-url-regexp before passing it on as in:
(and ffap-url-regexp (string-match-p ffap-url-regexp file))

--
  Peder Stray
--==-=-=-- --=-=-=--