emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* A small bug in org-file-url-p
@ 2021-09-01 11:59 Peder Stray
  2021-09-01 14:40 ` Timothy
  0 siblings, 1 reply; 2+ messages in thread
From: Peder Stray @ 2021-09-01 11:59 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]

Hi

Just wanted to report a small bug in org-file-url-p, regarding its use of
ffap-url-regexp.

The documentation for ffap-url-regexp states:
Regexp matching the beginning of a URI, for ffap.
If the value is nil, disable URL-matching features in ffap.

I have it set to nil in my setup, to disable url-matching, and this causes
org-file-url-p to pass on nil in (string-match-p ffap-url-regexp file),
thus causing string-match-p do die with an error.

Othe code in ffap uses and to test the value of ffap-url-regexp before
passing it on as in:
(and ffap-url-regexp (string-match-p ffap-url-regexp file))

-- 
  Peder Stray

[-- Attachment #2: Type: text/html, Size: 1079 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: A small bug in org-file-url-p
  2021-09-01 11:59 A small bug in org-file-url-p Peder Stray
@ 2021-09-01 14:40 ` Timothy
  0 siblings, 0 replies; 2+ messages in thread
From: Timothy @ 2021-09-01 14:40 UTC (permalink / raw)
  To: Peder Stray; +Cc: emacs-orgmode


[-- Attachment #1.1: Type: text/plain, Size: 147 bytes --]

Hi Peder,

Thanks for reporting this bug 🙂, and explaining the issue well. I’ve just
pushed a fix in fbfcd79f8.

All the best,
Timothy

[-- Attachment #1.2: Type: text/html, Size: 3727 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-01 14:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 11:59 A small bug in org-file-url-p Peder Stray
2021-09-01 14:40 ` Timothy

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).