From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
Received: from mp11.migadu.com ([2001:41d0:2:bcc0::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms5.migadu.com with LMTPS
	id ogR0MOxHsGOtdgEAbAwnHQ
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sat, 31 Dec 2022 15:32:12 +0100
Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp11.migadu.com with LMTPS
	id iGi3L+xHsGOQtwAA9RJhRA
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sat, 31 Dec 2022 15:32:12 +0100
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 7126131B75
	for <larch@yhetil.org>; Sat, 31 Dec 2022 15:32:12 +0100 (CET)
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-orgmode-bounces@gnu.org>)
	id 1pBctP-0000gC-Tq; Sat, 31 Dec 2022 09:31:23 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <yantar92@posteo.net>)
 id 1pBctM-0000fa-E7
 for emacs-orgmode@gnu.org; Sat, 31 Dec 2022 09:31:22 -0500
Received: from mout01.posteo.de ([185.67.36.65])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <yantar92@posteo.net>)
 id 1pBctJ-0004rL-3N
 for emacs-orgmode@gnu.org; Sat, 31 Dec 2022 09:31:20 -0500
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id F1B2E240186
 for <emacs-orgmode@gnu.org>; Sat, 31 Dec 2022 15:31:13 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1672497074; bh=UxEKrgZa3rnOsCTEMmP4Oc2jticHlztE3mUb/LEN1Us=;
 h=From:To:Cc:Subject:Date:From;
 b=Qs6FlJ5/KQKBh2zT2noT+VJzt/0cZTZQE0aYCtPUo2/KIZDhcI91KYT0SjkPz/ccz
 WFFBAQoSOzxZGCfAMTcJY8TXYlNomPZzcyS+j5e9jsA8x0emI8ivFPpUq/EkAFYswi
 sUgjfsjTcWIGQo6/ixIQcMzHEOLU0tW1OYtQveipL/G9PaMz2BxCrB9wlEJeiLpoa8
 9vgJ/oevuh+Aaz4m+DHw4SkuyrsJ5XvVygTLOp55KXOJMVtjk4tcKBOgn6Zk3qDDBF
 py/9R32+H3EL/cYoKBujb0WODElspIA1+QZU8FXgAB0dfhZHBz+0lz4xfMUkhs48Mj
 8sIXnrjcy7THA==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4Nkl1F3Cc5z6tm9;
 Sat, 31 Dec 2022 15:31:13 +0100 (CET)
From: Ihor Radchenko <yantar92@posteo.net>
To: Matt <matt@excalamus.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: ob-shell intentions and paperwork (was Bash results broken?)
In-Reply-To: <185645af285.f16730c9981316.8238066002530458068@excalamus.com>
References: <m2tu1v8gj8.fsf@me.com> <878rj7s0ti.fsf@localhost>
 <1853354beb4.fce54d8d902653.6359367327256505471@excalamus.com>
 <18555580d75.d7b471f9370716.1497263973038999899@excalamus.com>
 <87edsiv54k.fsf@localhost>
 <18561866f8c.f22a62b3866025.8634474263936272339@excalamus.com>
 <185645af285.f16730c9981316.8238066002530458068@excalamus.com>
Date: Sat, 31 Dec 2022 14:31:44 +0000
Message-ID: <87zgb38x0v.fsf@localhost>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net;
 helo=mout01.posteo.de
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-orgmode@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
X-Migadu-Country: US
X-Migadu-Flow: FLOW_IN
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1672497132;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=f4oH8U+yRsS4d062xkMPcT6ml5z18WAdQomHQXTfUbo=;
	b=jBk2RH0ocdxwfYcErPOe3ffSngshYOkICqp7AFRGPbu9qLFLRjOeQTE/T2qr0MH6kIkaCC
	5rMPOJZZyHOfFuG7rDTpBy9Wg/3bhKhXmMAYgF+SoisyJLrs+5TVYH0oiJTCZpLVNreuip
	BjsDCqt0Nnp6vYKDO+mDCwKtbhzsmGtfM3cK6PF/SocR5BiU7fmZaVOxlwPjOlf+pxpDed
	VvEw8BdbNgWzS+nvAyHm0vlq+0msYa0rceoD7W8MzLsp09VxsR1t93wW+OJI92Gl2UVJTi
	TlP+MuKbwLN7iPtTgMZIC/vfqlVoWX++StIexWjCcM58g3OQ8XoVW8dMb75dFA==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=pass header.d=posteo.net header.s=2017 header.b="Qs6FlJ5/";
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org";
	dmarc=pass (policy=none) header.from=posteo.net
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1672497132; a=rsa-sha256; cv=none;
	b=h4kkHmz22+mx6ldAj92TcseN3umIxD5xQJWq/o6KGPWu1lb0rOeggtv638xn3XmrXmngeP
	H2CoNiZAoVf+2Snm5wN6Arb8C79fY4hDa6X10bmlFzTAK9yHgcvlu01zzSeClTFcNEiE0U
	dLubeLOR8WalCaf+bzRT7MK6UBRVLWu+cLYCayPAzVw4hbR7r6ng8nBtWCICx/mhUaahqu
	sFJseqVsb/dY4Dr5WafDn8Unxlnh9vX6te7QmGh2yQEVvPO39lagw6XOIEhRhU9/K+W+xf
	Hv3dvspO7Tzbf7HpHOLQLFfwSunljUGzK1wsyRZATksSRD78vMgEqYZJwzfB6g==
X-Spam-Score: -4.47
X-Migadu-Queue-Id: 7126131B75
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=posteo.net header.s=2017 header.b="Qs6FlJ5/";
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org";
	dmarc=pass (policy=none) header.from=posteo.net
X-Migadu-Scanner: scn1.migadu.com
X-Migadu-Spam-Score: -4.47
X-TUID: ZrTSkCWSCV/m

Matt <matt@excalamus.com> writes:

> I've backed out the `require' change and adjusted everything else based on your feedback.  There is a separate patch for each refactor that created a new test.   The remaining refactors are in a single patch.  I was also able to resolve the issue I had with inserting the test name for the session (the "yes" string in `test-ob-shell/session').  The issue with `org-babel-shell-initialize' still stands but is outside the scope of these patches and isn't dealt with here.

Thanks!

I can see that you still prefer to use `string-join' for Org body.
Why not a bare string? There is no particular problem with
`string-join', but the rest of the tests are all using direct string
when possible - your patch makes ob-shell stand out of common style.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>