From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id sBNmK3+lImZN9gAAe85BDQ:P1 (envelope-from ) for ; Fri, 19 Apr 2024 19:10:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id sBNmK3+lImZN9gAAe85BDQ (envelope-from ) for ; Fri, 19 Apr 2024 19:10:23 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="WW4zqP/E"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713546623; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZW1z71sDv+OjZJ8AwOn1wOmKug4jNRp4vnTXG2MMkRI=; b=TJWs9wWemywmzagq+qVGTpIJQZ9AzTzOgMlBJNL98DfCoGqMBoEbYL02tQiLm6OlxJZ6hq gy/nL+DNQOs36bES4zZhGrSffoMK6TyRSYcN3tbXBUE0X4x+cLr2AkHGdp5O+gVBoXLSoA eVeqVLMDBykqEAU+2L846b/cyDqCYYpffJmgbGM2DGrnHdjtewfvTVXgxsU6gSl09u3hvi MjYyDzxJZI/2oCiORq01dvFe255K3rvdBVZwJIlssPmtf34HRyM7JPksUyIhH4Eyt3bl0W byjEum0b3+Jtzb2w2HFBNOKfkrMSdIvzjRc/H3a0atAV2O72VQVCQB7I82KgJA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713546623; a=rsa-sha256; cv=none; b=f+p7gd8HylfkKF+xW0rNh4tBape1WEMZFaD6PV+8Ar+v0Fm7Rd/ACkaejRnxx4Vcimvgfu 8cCJTl+I+Q69wRTnJznd/FKZC+KkYL1h9ulDJpEnLgkOXBkMKfdb/nQmlGszlKH0zHWrZM /UgEd1FXTWiYg9docTU9UsnWHhR9/w29qq/UbavYn56C+/GqYY81yRLGBhqeKPpujQIu97 XQ1X5xGwjAEjEZ3MELOCjEk49KxihYgOyEcuX7c+/sa8DYhPUTsmVsw0CoJ9gD/rCtOsDb GrvgP7p+Usd6Ik7dfRXp6M0RRxt1AOS7JgktxoASsRLAdsuJI9AlSxvjHLeLcQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="WW4zqP/E"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5FCCB3A49F for ; Fri, 19 Apr 2024 19:10:23 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxrjp-0004tk-NI; Fri, 19 Apr 2024 13:09:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxrji-0004tC-Ju for emacs-orgmode@gnu.org; Fri, 19 Apr 2024 13:09:19 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxrjg-0006uE-5t for emacs-orgmode@gnu.org; Fri, 19 Apr 2024 13:09:18 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 26FC0240028 for ; Fri, 19 Apr 2024 19:09:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1713546550; bh=0iE8hqQfTWglOoRj/Jw3HtD4tP+OUPxL2yU25kw/h+s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=WW4zqP/Ewn/vIn1MswZ01UMSG3dQJsxmx27gr8GQj9xMvgbIvhFS/mreQT6mOgWWw HN/70JcRZj/Aj9sXr5Yadry4cCYUYfETA5EthKv2MAY5md9BKFqgGTZ/5a6dtvuNaU pd8xUteJw7xqeH1NzkRvZCUPUEVxMstnPYVnjQUQ02gJ1tovUrJJ9+s1QLsbZPz3dF RcpWFlTmM52g28DESOrUTZnn3ok9WryCAGb0NTXFvZ2+SD+YQ+8lYFHj0A92YLlQFp rvoQ8yeqcXIdoA5rcWA+I6DfyR3c+WEz96XJP/S9ROFopTL/H+PrXKhSbWnnES6OKv WlNS64HwKXOWg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VLh2F1T0jz6twh; Fri, 19 Apr 2024 19:09:09 +0200 (CEST) From: Ihor Radchenko To: Alexander Adolf Cc: emacs-orgmode@gnu.org Subject: Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM In-Reply-To: References: <486d2b818b62c71b3f307305c06c4318@condition-alpha.com> <871q7cypxl.fsf@localhost> <00aa9bf72dc93f6554bdd236fdfba192@condition-alpha.com> <87y19hbb05.fsf@localhost> <8b72386d118136210f27b553f0a13066@condition-alpha.com> <87cyqtyzgt.fsf@localhost> <91dfeb0fed1a1fe0564e5eb9b95a409d@condition-alpha.com> <87a5lpeiey.fsf@localhost> Date: Fri, 19 Apr 2024 17:09:52 +0000 Message-ID: <87zftp6zz3.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -8.16 X-Spam-Score: -8.16 X-Migadu-Queue-Id: 5FCCB3A49F X-Migadu-Scanner: mx13.migadu.com X-TUID: xJdopN37ExlZ Alexander Adolf writes: >> Also, if you mention a variable in the manual, please add #+vindex: >> entry. Maybe even #+cindex: entry for "formatter", to make the parameter >> more discoverable. > > I kept it to the format of the existing parameter descriptions, which > don't create index entries. Happy to add one though. #+cindex would seem > more appropriate, as it's not a variable? When suggesting #+vindex, I was referring to org-columns-dblock-formatter variable. > On a loosely related note: the description of the :formatter parameter > of the clock table does not have and index entry either. Should it get > one too, then? Within the scope of this patch, it is enough to add the index entry to the newly added parameter. More generally, we do want index entries for various parameters in dynamic blocks and clock tables. As we do for header arguments: #+cindex: @samp{file}, header argument But that should be a separate patch. For colview dynamic blocks, cindex entry may look like #+cindex: @samp{formatter}, dynamic block parameter >> Is there any reason why you did not remove the statistics cookies here >> as well? >> [...] > > Somehow (how?) the statistics cookies get removed in my current > implementation. org-link-make-string does not remove them (I double > checked). I would thus speculate that perhaps the overlay creation (to > show description only) removes them? OTOH, I'm happy to add the > org-trim part to make things more robust. I see how. It is because CELL-CONTENT is not the original heading. It is the heading name processed with `org-columns--clean-item'. `org-column--clean-item' removes statistics cookies among other things. It actually removes more, leading to some edge cases in your patch: ** TODO Foo ** TODO src_elisp{"Hello"} world #+begin: columnview :id global :link t | <25> | | <3> | | | ITEM | TODO | PRIORITY | TAGS | |-------+------+----------+------| | [[file:/tmp/test.org::*Foo][Foo]] | TODO | B | | | [[file:/tmp/test.org::*src_elisp{"Hello"} world][world]] | TODO | B | | #+end: Note how inline src block is stripped from the link description. We should probably also change org-clock to use `org-columns--clean-item'. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at