emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Morgan Willcock <morgan@ice9.digital>
Cc: Lin Jian <me@linj.tech>, emacs-orgmode@gnu.org
Subject: Re: [BUG] What about excluding .dir-locals.el from GNU ELPA tarball?
Date: Mon, 16 Sep 2024 19:22:16 +0000	[thread overview]
Message-ID: <87zfo7mmjb.fsf@localhost> (raw)
In-Reply-To: <87tteg26rs.fsf@ice9.digital>

Morgan Willcock <morgan@ice9.digital> writes:

> I believe it is up to the file to opt-out of compilation.

That's true, but .dir-locals is a special file. So, I expected Emacs to
treat it specially during compilation as well. To not break old,
no-longer-maintained packages, if nothing.

> If the file is created with add-dir-local-variable there is a boiler
> plate header inserted which opts out:
>
>   ;;; Directory Local Variables            -*- no-byte-compile: t -*-
>   ;;; For more information see (info "(emacs) Directory Variables")
> ...
> ...  The solution would be to add
> the missing header to the .dir-locals.el file.

I do not see any downside of adding this to .dir-locals.el file.
Would you mind submitting a patch?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2024-09-16 19:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12 23:07 [BUG] What about excluding .dir-locals.el from GNU ELPA tarball? Lin Jian
2024-09-15  8:23 ` Ihor Radchenko
2024-09-15 16:58   ` Morgan Willcock
2024-09-16 19:22     ` Ihor Radchenko [this message]
2024-09-17 18:13       ` Morgan Willcock
2024-09-22  8:14         ` Ihor Radchenko
2024-09-16  0:58   ` Lin Jian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfo7mmjb.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=me@linj.tech \
    --cc=morgan@ice9.digital \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).