Re: need detailed instructions for submitting the patch

[Bernt Hansen <bernt@norang.ca>]

Juan <pechiar@computer.org> writes:

> On Tue, Aug 10, 2010 at 01:59:57AM +0400, Ivanov Dmitry wrote:
>> The http://orgmode.org/worg/org-contribute.php#sec-3 says:
>> "Git can be used to make patches and send them via email - this is
>> perfectly fine for minor changes. These patches will be
>> automatically registered at John Wiegley's patchwork server"
>>
>> Please, tell me, what commands should I run to create a patch,
>> upload it and get any feedback from the senior developers?
>
> The following command will make a patch between the staging area
> (in your computer), and the file you modified:
>
>     git diff -p org-whatever.el
>
> If you already committed your changes to your index (staging area),
> then you should compare against a particular branch (in this example,
> origin/master):
>
>     git diff -p origin/master org-whatever.el
>
> You email the output to this mailing list, adding [PATCH] to the
> subject, and description of what you fixed or changed.
>
> At least, this is how I do it.
>
> Regards,
> .j.

It's easier to make real commits on a topic branch and use either git
send-email or git format-patch to create the properly formatted patch
files.

I personally use git send-email --annotate -N (where N is the number of
commits I want to create patches for.  For example,
git send-email --annotate -1 if it is a single commit)

I have the following in my .git/config so that git send-email knows
where to send the resulting patches

,----[ .git/config ]
| [sendemail]
| 	to = emacs-orgmode@gnu.org
`----

Alternatively, git format-patch will create sequentially numbered files
which you can edit and mail manually from your email client.

HTH,
Bernt