Re: [ox-latex] Bad default value for image width?

[Rasmus <rasmus@gmx.us>]

Nicolas,

>> I don't like that tikz figures are wrapped in a resize box.  
>
> Set `org-latex-image-default-width' to "".

But as my second email shows this still doesn't work with
captions. . .

This exmample:

#+BEGIN_SRC org
#+BEGIN_SRC emacs-lisp
(make-local-variable 'org-latex-image-default-width)
(setq org-latex-image-default-width "")
#+END_SRC

#+NAME:firm-ts-fig
#+CAPTION: test
[[file:figs/test.tikz]]

no caption
[[file:figs/test.tikz]]
#+END_SRC

> That's not correct. It is always true because (:width "") means width
> becomes "\"\"", not "". IOW, `org-export-read-attribute' is unable to
> parse a real empty string.

I see. 

> This wouldn't help to solve the general problem. Though, you can change
> it in your config to something else, as suggested above.

I have.  But I don't think it's a sensible default.  It's against what
your usual stand of Org not trying to be too clever.  You would also
not put tables in resize boxes to make them "fit" on the page.


Here's another example where the default causes a non-sensible
behavior.

#+BEGIN_SRC org
#+BEGIN_SRC emacs-lisp :exports none
(url-copy-file "http://orgmode.org/img/org-mode-unicorn-logo.png" "logo.png")
#+END_SRC

* My raster picture

This is a low res. picture with the right size^{TM}

[[file:logo.png]]
#+END_SRC


>>   2. allow for a non-width (:width nil)
>>   3. make a better test for the resize box.
>>
>> Let me know and I might be able to look into it.



> I think the correct solution would be to fix `org-export-read-attribute'
> so it can read empty strings.

I think this is the solution to a general problem.  But I still find
the default width to be wrong.  It only works as intended when I have
a slightly too large picture.  And then, if anything, I'd want full
page width.  

It's a bad default for
  - Picture smaller than textwidth
  - Picture crafted to the document which shouldn't have a width.

It's a decent solution for 
  - pictures which are unintentionally larger than textwidth.  But IMO
    it's my responsibility, and not Org's, to fix these
    images/situations.


In usually exhibit good judgment of these matters, so I'll take your
word for it.  But I fail to see its usefulness as a default.

> If "" is really read as "", """" will still be read as "\"\"\"\"", and
> it will not be possible to obtain "\"\"".

Fine with me. 

> Another possibility is to read the empty string as the empty string
> instead of nil, that is
>
>   #+attr_latex: :prop1 :prop2 1

I like the "" better.  It works better with my "intuitive logic".


–Rasmus


-- 
Hvor meget poesi tror De kommer ud af et glas isvand?