emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: [RFC] Do not declare drawers to use them
Date: Thu, 31 Oct 2013 21:43:41 +0100	[thread overview]
Message-ID: <87y559yxvm.fsf@gmail.com> (raw)
In-Reply-To: <9A314B0A-5421-46F6-B56A-B801E0E77694@gmail.com> (Carsten Dominik's message of "Mon, 21 Oct 2013 12:21:26 +0200")

Hello,

Carsten Dominik <carsten.dominik@gmail.com> writes:

> On 21.10.2013, at 12:03, Nicolas Goaziou <n.goaziou@gmail.com> wrote:
>
>> Hello,
>> 
>> Carsten Dominik <carsten.dominik@gmail.com> writes:
>> 
>>> I think one objection agains this patch is that, I think, MobileOrg
>>> relies on #+DRAWERS lines to be present to define drawers.
>> 
>> The patch also contains org-mobile.el modifications.
>> 
>>> Maybe the MobileOrg maintainers for both Android and iOS can chime in
>>> here?
>> 
>> Obviously, a double check cannot hurt.
>> 
>>> Otherwise I don't have a significant objection against this change.
>>> I am wondering if it is going to introduce spurious drawers and
>>> parsing errors if someone happens to have a string :xxx: on a line by
>>> itself in the buffer. This might be unlikely, but I am not really
>>> sure.
>> 
>> Actually, as far as the parser goes, :xxx: is insufficient to define
>> a drawer. Indeed, the drawer has to be complete, i.e. it has to contain
>> the :END: part.
>> 
>> An incomplete drawer does not trigger a parsing error: it is parsed as
>> a mere paragraph.
>
> OK, sounds good to me, then.

Applied.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2013-10-31 20:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-20 13:38 [RFC] Do not declare drawers to use them Nicolas Goaziou
2013-10-20 18:13 ` Carsten Dominik
2013-10-21 10:03   ` Nicolas Goaziou
2013-10-21 10:21     ` Carsten Dominik
2013-10-31 20:43       ` Nicolas Goaziou [this message]
2013-10-21 17:37 ` Achim Gratz
2013-10-23 18:14   ` Nicolas Goaziou
2013-11-02 21:45 ` Samuel Wales
2013-11-02 21:48   ` Samuel Wales
2013-11-02 21:52     ` Nicolas Goaziou
2013-11-02 22:44       ` Samuel Wales
2013-11-02 22:47         ` Nicolas Goaziou
2013-11-02 22:56           ` Samuel Wales
2013-11-02 23:01             ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y559yxvm.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).