From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
Received: from mp1 ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms0.migadu.com with LMTPS
	id mna0MJ41R2FQOQEAgWs5BA
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sun, 19 Sep 2021 15:05:34 +0200
Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp1 with LMTPS
	id yOiqK541R2EEXAAAbx9fmQ
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sun, 19 Sep 2021 13:05:34 +0000
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 4200E147A9
	for <larch@yhetil.org>; Sun, 19 Sep 2021 15:05:33 +0200 (CEST)
Received: from localhost ([::1]:59274 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	id 1mRwVe-0007Od-SA
	for larch@yhetil.org; Sun, 19 Sep 2021 09:05:30 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:45716)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <tecosaur@gmail.com>)
 id 1mRwUz-0007ML-MV
 for emacs-orgmode@gnu.org; Sun, 19 Sep 2021 09:04:49 -0400
Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:33715)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <tecosaur@gmail.com>)
 id 1mRwUy-0007dE-56
 for emacs-orgmode@gnu.org; Sun, 19 Sep 2021 09:04:49 -0400
Received: by mail-pf1-x42c.google.com with SMTP id s16so5434202pfk.0
 for <emacs-orgmode@gnu.org>; Sun, 19 Sep 2021 06:04:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:date:references:user-agent:in-reply-to
 :message-id:mime-version;
 bh=Q/hB9jFBfZFLMSg5Fuv/zsKYuxiLQ6AUomEuBxFpdTs=;
 b=n+adfHuQ1janxBSkQ7rQwhrJ6GwkXeSZweHJxlIwz3EAjfFt4Fm1xNLAeNZiWv+6Rl
 W/R4rtETX5fh3Pb+NGaio+OIFKelNK9y6DX8HAzbFLr5cVSo/Vr0DjSZ7SrbGIcMkng9
 CFRQ5CWHKcyy+2U7ULxJeaDls1CwhfD5KvQPKU2mX5Kx5SextqAUtuBgSPLg6tdcbIPc
 x1ERrAA+o7ZYSBSAbG2G9RmPOYiDgGNosS0m0mfLzFqg6JFH1C1K65WFxREOikrDfMzt
 5PNJKZyd2GTFPhQUKj1MZ5fnXxi39RBUB9azqLag7Q1+EOzGvO2KQkbTtpDZ1czUjEq6
 O7lw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:date:references:user-agent
 :in-reply-to:message-id:mime-version;
 bh=Q/hB9jFBfZFLMSg5Fuv/zsKYuxiLQ6AUomEuBxFpdTs=;
 b=RQF64ha/AE+inwLGjtwgzgblaPr6jDx+J9sz9jO5mTnc7mryR3niHut4fgDP1ehhmz
 DkmTK8jsWDAx1rYRP2IoNbMxX4VwN/d4S1KrPHubH0ISKoZYJR05Ke7VGDlfZ3RhjE6A
 CceyFrvD5DE1rt0paGVr3f3BFrrc16vc05WFc8NTeTJ/AwQp+wIK61wFjc9mMhi7x9On
 o6xJGh2DBEyrmbdZpENtAjUu/F5miYLz50WiTGBiEjyoQRY7WzbqMbx9q9HI5y7nhtXe
 0uQUGY1u9Czn1CEY8WH3CNuTscnRcqLFtfykoVEE+PplEWdjkgf4ZzdNa4DCKndlCxKq
 +Thg==
X-Gm-Message-State: AOAM530qTdb1l5gBVXd882U4eThVmndgnIygFAzp2T4MbseXSIQ3GLr2
 zm11n4tfL/vB+xgb4SgbUeLfTiUzdSY=
X-Google-Smtp-Source: ABdhPJwwgCoJyclcBQ13JQWlLRcJkk3aiHKVdKRzb6gN/ZHFlmugK1g4FhiBQmVhPKLxixtfWf+x3Q==
X-Received: by 2002:a65:6288:: with SMTP id f8mr19029770pgv.81.1632056686554; 
 Sun, 19 Sep 2021 06:04:46 -0700 (PDT)
Received: from localhost (61-245-128-160.3df580.per.nbn.aussiebb.net.
 [61.245.128.160])
 by smtp.gmail.com with ESMTPSA id gk3sm15450843pjb.37.2021.09.19.06.04.45
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 19 Sep 2021 06:04:46 -0700 (PDT)
From: Timothy <tecosaur@gmail.com>
To: Karl Stump <karlstump@gmail.com>
Subject: Re: [PATCH] Fixed lstset where language= wipes out previous
 definitions
Date: Sun, 19 Sep 2021 21:02:36 +0800
References: <20210528224059.2972-1-karlstump@gmail.com>
User-agent: mu4e 1.6.5; emacs 28.0.50
In-reply-to: <20210528224059.2972-1-karlstump@gmail.com>
Message-ID: <87y27sd8d0.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2607:f8b0:4864:20::42c;
 envelope-from=tecosaur@gmail.com; helo=mail-pf1-x42c.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-orgmode@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Cc: emacs-orgmode@gnu.org
Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
Sender: "Emacs-orgmode" <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
X-Migadu-Flow: FLOW_IN
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1632056734;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=Q/hB9jFBfZFLMSg5Fuv/zsKYuxiLQ6AUomEuBxFpdTs=;
	b=lZ6gtkYcQ0AabmwTxVOAZP2sSz5FvimHrdsU4QuHr4M483KNBYAufsUIUCTbmoPklqQUcY
	S3t6aDs1syMsDuADv16CGTpLrp8yj/6JtT3cumaGbeXNZ8UAWeZFVHH0+cht8R0PgqC0rY
	ocaQujyDH22RRieYwEMUKgGY7O3TUdA/h6WnpMLOlcI/rjcZcI8THtrZ1IEM8D/v+3KLwq
	Zd2TifQZYduVAJKWWqQCQBQccbEsYsufi4t6w/TC3peeg0xRqaIWVsK4WoVG9i8Ch1sIm2
	9mvtZJlThxgGV5oRf8JZxXnuC8Bn9sAadU2u1gvltBiBM961OFfN86FP2XMZxQ==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632056734; a=rsa-sha256; cv=none;
	b=U7Kmo0xKafcdb1nXYAwj8V0IoHrj4R0gB+M+ZAI6bqjBIHRNQVpBGUJFrUfHQwNuZHOj2g
	TO6eelxrWmtqnrJO30stkod8UEgFyJH9XJ9ksF1YdWkWGMuXmu/JYwNYf4W4wUMV8WZWJQ
	ufFQ4+j9o0s8Yvc3HJ2du1CJoMjNElxUNsYjzT3vS/L1kha1P9kZ0WjwPLGNQt4kE/qAwl
	2fholITRee2/OHgzcGpb71rwgJpd2EhHe93z4yaQH529KogAuMrDL0WnPiv0SIEXclnrHZ
	w3IK6oVsq4C+if1C1BqPT0b2hnbOhF9D1AuTYYDdj2ljBMpFqaW7URZeoxPYFA==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=pass header.d=gmail.com header.s=20210112 header.b=n+adfHuQ;
	dmarc=pass (policy=none) header.from=gmail.com;
	spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org
X-Migadu-Spam-Score: -2.09
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=gmail.com header.s=20210112 header.b=n+adfHuQ;
	dmarc=pass (policy=none) header.from=gmail.com;
	spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org
X-Migadu-Queue-Id: 4200E147A9
X-Spam-Score: -2.09
X-Migadu-Scanner: scn0.migadu.com
X-TUID: I1x8BabJmSAI

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi  Karl,

Thanks for sending in this patch, and sorry it=E2=80=99s taken so long for =
someone to
get back to you. Would you mind explaining the issue here a bit more? I can=
=E2=80=99t
see at a glance how preceding definitions are wiped in the current
code.

Karl Stump <karlstump@gmail.com> writes:

> * ox-latex.el (org-latex-src-block): moved ((=E2=80=9Clanguage=E2=80=9D ,=
lst-lang)) to the head of the list.
> This fixes wiping out preceding definitions given in `org-latex-listings-=
options=E2=80=99.
> TINYCHANGE
> =E2=80=94
>  lisp/ox-latex.el | 4 ++=E2=80=93
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff =E2=80=93git a/lisp/ox-latex.el b/lisp/ox-latex.el
> index b9ecf070a..f956c851e 100644
> =E2=80=94 a/lisp/ox-latex.el
> +++ b/lisp/ox-latex.el
> @@ -3075,13 +3075,13 @@ contextual information.=E2=80=9C
>  	    (concat
>  	     (org-latex=E2=80=93make-option-string
>  	      (append
> -	       lst-opt
> +               `((=E2=80=9Dlanguage=E2=80=9C ,lst-lang))
> +               lst-opt
>  	       (cond
>  		((and (not float) (plist-member attributes :float)) nil)
>  		((string=3D =E2=80=9Dmulticolumn=E2=80=9C float) =E2=80=99((=E2=80=9Df=
loat=E2=80=9C =E2=80=9D*=E2=80=9C)))
>  		((and float (not (assoc =E2=80=9Dfloat=E2=80=9C lst-opt)))
>  		 `((=E2=80=9Dfloat=E2=80=9C ,(plist-get info :latex-default-figure-pos=
ition)))))
> -	       `((=E2=80=9Dlanguage=E2=80=9C ,lst-lang))
>  	       (if label
>  		   `((=E2=80=9Dlabel=E2=80=9C ,(org-latex=E2=80=93label src-block info=
)))
>  		 =E2=80=99((=E2=80=9Dlabel=E2=80=9C =E2=80=9D =E2=80=9C)))

All the best,
Timothy

--=-=-=--